Node.JS 12 deprecation on GitHub Actions #219

caizixian · 2022-10-08T05:25:54Z

Do the checklist before filing an issue:

Is this related to the actions-rs Actions?
If you think it's a problem related to Github Actions in general, use GitHub Community forum instead: https://github.saobby.my.eu.orgmunity
You've read the Contributing section about bugs reporting: https://github.com/actions-rs/.github/blob/master/CONTRIBUTING.md#reporting-bugs
Is this something you can debug and fix? Send a pull request! Bug fixes and documentation fixes are welcome.

Description

GitHub Action hosted runner is reporting the following warning.

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions-rs/toolchain

Workflow code

      - name: Install latest stable Rust toolchain
        uses: actions-rs/toolchain@v1
        with:
          profile: minimal
          toolchain: stable

Action output

See above.

Expected behavior

Migrate actions-rs/toolchain to Node.JS 16.

Additional context

N/A.

The text was updated successfully, but these errors were encountered:

Bromeon · 2022-10-25T22:30:01Z

We might wait a long time here, given that this project has been unmaintained for almost 2 years: #216

This is to fix warnings that pop up in Github Actions due to actions-rs/cargo and actions-rs/toolchain not being updated to the Node 16. actions-rs/cargo - [Node.js 12 actions are deprecated. Please use Node.js 16](actions-rs/cargo#216) actions-rs/toolchain - [Node.JS 12 deprecation on GitHub Actions](actions-rs/toolchain#219)

actions-rs is currently inactive and has an issue like actions-rs/toolchain#219

elibroftw · 2022-11-07T06:39:43Z

Non interactive install for anyone who only needs stable rust.

      - name: Install Rust (Stable)
        run:
          curl https://sh.rustup.rs -sSf | sh -s -- -y

dallin-ukralabs · 2022-12-06T09:28:44Z

Unfortunate the project seems abandoned, was using it daily.

* ci.yml to use Node16 * `actions/checkout@v3` * `actions/setup-python@v4` * `actions-rs` is unmaintained: * actions-rs/toolchain#219 * actions-rs/cargo#222 * Library Checker: Rust 1.60 * https://judge.yosupo.jp/help * clippy allow renamed-and-removed-lints * https://doc.rust-lang.org/rustc/lints/listing/warn-by-default.html#renamed-and-removed-lints * `cargo`, `rustup` execute from `$PATH` * uses dtolnay/rust-toolchain@master

a1ecbr0wn · 2023-04-17T15:57:45Z

Do you think this guy is dead? Is there a way to add other people to the project to maintain it without him given that he has been MIA for 2+ years? This action will cease to work in a couple of months and that would be a real shame given it's wide use.

Ujang360 · 2023-04-17T20:32:02Z

@svartalf are you OK?

The previous step used actions-rs which relies upon deprecated Node.js 12 actions. See: actions-rs/toolchain#219

milesj · 2023-05-05T04:52:43Z

Now that Node 12 is going to start breaking, and this action is dead, I've created a new one: https://github.com/moonrepo/setup-rust

mgeisler · 2023-05-08T09:55:56Z

Now that Node 12 is going to start breaking, and this action is dead, I've created a new one: https://github.com/moonrepo/setup-rust

May I ask what this action (and your new action) is for when the GitHub runners already include rustup?

The GitHub runners include rustup and a recent stable Rust. We only need to add the necessary target and we’re good to go. This removes a lot of warnings because the action used an outdated GitHub API: actions-rs/toolchain#219

* Remove unnecessary jobs names They are inconsistent with the rest of the jobs and they overflow the horizontal space in the GitHub UI. * Remove unnecessary toolchain action The GitHub runners include rustup and a recent stable Rust. We only need to add the necessary target and we’re good to go. This removes a lot of warnings because the action used an outdated GitHub API: actions-rs/toolchain#219 * Simplify job name The job is testing a single translation, so it should be singular. * Test English source with translations This simplifies the workflow a little and ensures that we get artifacts uploaded of the English version for every PR. * Avoid shell command chain GitHub actions supports setting the working directory directly. * Upload only the book artifact Right now, the artifacts all contain the same two top-level folders: html/ and exerciser/. The former is what we actually deploy, the second is a side-effect of the exerciser plugin. With this change, we only upload the HTML and we ensure the zip file for the xx language has a top-level comprehensive-rust-xx/ folder. This makes it much nicer to use the generated artifacts.

milesj · 2023-05-08T16:45:56Z

@mgeisler Just look at the readme.

mgeisler · 2023-05-09T08:52:21Z

@mgeisler Just look at the readme.

Thanks, I was expecting it to simply replace this action, but I see now that it also includes support for caching and installing binaries. That will allow me to further simplify my jobs, thanks.

226: Fix warnings in CI r=Aadamandersson a=Aadamandersson This fixes the warnings in our CI. We are currently using [action-rs/toolchain](https://github.com/actions-rs/toolchain) to install the Rust toolchain in Github Actions. But as it seems to be unmaintained (see actions-rs/toolchain#216) and needs to be replaced to fix some of the warnings (see actions-rs/toolchain#219) I have replaced it with [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain), which looks like a suitable replacement. Co-authored-by: Adam Andersson <adam.m.andersson@gmail.com>

Before this change, GitHub Actions would warn that actions-rs/toolchain@v1 uses deprecated functionality: The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/ and: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ Unfortunately, the development of this action is abandoned (the repo has not received any updates in the last 3 years and the author is unresponsive: actions-rs/toolchain#219). Fix the warning by manually invoking rustup commands since it turns out that GitHub Actions now bundle it in their runners by default.

* Remove unnecessary jobs names They are inconsistent with the rest of the jobs and they overflow the horizontal space in the GitHub UI. * Remove unnecessary toolchain action The GitHub runners include rustup and a recent stable Rust. We only need to add the necessary target and we’re good to go. This removes a lot of warnings because the action used an outdated GitHub API: actions-rs/toolchain#219 * Simplify job name The job is testing a single translation, so it should be singular. * Test English source with translations This simplifies the workflow a little and ensures that we get artifacts uploaded of the English version for every PR. * Avoid shell command chain GitHub actions supports setting the working directory directly. * Upload only the book artifact Right now, the artifacts all contain the same two top-level folders: html/ and exerciser/. The former is what we actually deploy, the second is a side-effect of the exerciser plugin. With this change, we only upload the HTML and we ensure the zip file for the xx language has a top-level comprehensive-rust-xx/ folder. This makes it much nicer to use the generated artifacts.

…ithub.com/dtolnay/rust-toolchain (actions-rs/toolchain#221 and actions-rs/toolchain#219)

istellino-chub · 2023-08-30T10:58:22Z

How can I replace this one?

        name: Install Rust
        uses: actions-rs/toolchain@v1
        with:
          toolchain: stable
          target: x86_64-unknown-linux-musl
          default: true

Finomnis · 2023-08-30T11:08:50Z

How can I replace this one?

        name: Install Rust
        uses: actions-rs/toolchain@v1
        with:
          toolchain: stable
          target: x86_64-unknown-linux-musl
          default: true

@istellino-chub

         name: Install Rust
         uses: dtolnay/rust-toolchain@stable
         with:
           targets: x86_64-unknown-linux-musl

More info here.

istellino-chub · 2023-08-30T11:11:16Z

thanks @Finomnis does that install rust? I though that it install the toolchain

Finomnis · 2023-08-30T11:15:10Z

@istellino-chub What's the difference between 'Rust' and the 'Rust toolchain'?

What dtolnay/rust-toolchain installs is rustc, cargo, and so on. Exactly what actions-rs/toolchain did as well.

istellino-chub · 2023-08-30T12:27:32Z

@istellino-chub What's the difference between 'Rust' and the 'Rust toolchain'?

What dtolnay/rust-toolchain installs is rustc, cargo, and so on. Exactly what actions-rs/toolchain did as well.

@Finomnis And what about the profile and override option

        name: Install Rust
        uses: actions-rs/toolchain@v1
        with:
          profile: minimal
          toolchain: nightly
          override: true

Finomnis · 2023-08-30T13:13:59Z

@istellino-chub What's the difference between 'Rust' and the 'Rust toolchain'?
What dtolnay/rust-toolchain installs is rustc, cargo, and so on. Exactly what actions-rs/toolchain did as well.

And what about the profile and override option
        name: Install Rust
        uses: actions-rs/toolchain@v1
        with:
          profile: minimal
          toolchain: nightly
          override: true

I'm not even sure what override did in actions-rs/toolchain. Same for profile. dtolnay says his tool has sane defaults; for the other settings it has, I'd forward you to its official documentation.

This PR supersedes actions-rs#220 and actions-rs#222 by applying both fixes at once Fixes actions-rs#219 Fixes actions-rs#221 You can now use this action (and cargo) without deprecations by using a workflow similar to this: on: [push] name: build jobs: check: name: Rust project runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - name: Install latest nightly uses: ThexXTURBOXx/toolchain@master with: toolchain: nightly override: true components: rustfmt, clippy # `cargo check` command here will use installed `nightly` # as it is set as an "override" for current directory - name: Run cargo check uses: richb-hanover/cargo@master with: command: check

caizixian added the bug Something isn't working label Oct 8, 2022

caizixian linked a pull request Oct 8, 2022 that will close this issue

Update the action to run on Node 16 #220

Open

FirelightFlagboy mentioned this issue Oct 12, 2022

Update github action actions-rs/toolchain when its update to using node-16 Scille/parsec-cloud#3261

Closed

This was referenced Oct 12, 2022

Updates for Node.js 12 deprecation stratis-storage/project#531

Closed

More updates for Node.js 12 deprecation stratis-storage/project#532

Closed

DMRobertson mentioned this issue Oct 18, 2022

Deal with Github Actions deprecation warnings matrix-org/synapse#14203

Closed

ja573 mentioned this issue Oct 25, 2022

Feature/upgrade GitHub actions thoth-pub/thoth#448

Merged

tgeoghegan mentioned this issue Oct 26, 2022

Update to actions that use recent Node.js divviup/janus#684

Closed

pyroraptor07 mentioned this issue Oct 30, 2022

Run cargo/rustup directly in CI pyroraptor07/interactsh-rs#2

Merged

miles170 added a commit to miles170/fd that referenced this issue Nov 2, 2022

CI: remove use of actions-rs/toolchain

a6f47ef

actions-rs is currently inactive and has an issue like actions-rs/toolchain#219

miles170 added a commit to miles170/fd that referenced this issue Nov 2, 2022

CI: remove use of actions-rs/toolchain

d08a2c3

actions-rs is currently inactive and has an issue like actions-rs/toolchain#219

miles170 added a commit to miles170/fd that referenced this issue Nov 2, 2022

CI: remove use of actions-rs/toolchain

0e2c8b1

actions-rs is currently inactive and has an issue like actions-rs/toolchain#219

miles170 added a commit to miles170/fd that referenced this issue Nov 2, 2022

CI: remove use of actions-rs/toolchain

2793cff

actions-rs is currently inactive and has an issue like actions-rs/toolchain#219

miles170 added a commit to miles170/fd that referenced this issue Nov 2, 2022

CI: remove use of actions-rs/toolchain

99a2028

actions-rs is currently inactive and has an issue like actions-rs/toolchain#219

miles170 added a commit to miles170/fd that referenced this issue Nov 2, 2022

CI: remove use of actions-rs/toolchain

7f7d082

actions-rs is currently inactive and has an issue like actions-rs/toolchain#219

miles170 mentioned this issue Nov 2, 2022

CI: update actions to run on Node 16 sharkdp/fd#1158

Merged

miles170 added a commit to miles170/fd that referenced this issue Nov 2, 2022

CI: remove use of actions-rs/toolchain

f52eaa9

actions-rs is currently inactive and has an issue like actions-rs/toolchain#219

sr-gi mentioned this issue Nov 4, 2022

Updates actions talaia-labs/rust-teos#141

Merged

mo-xiaoming mentioned this issue Nov 5, 2022

upgrade action versions to silent nodejs 12 deprecated warning KyleMayes/clang-rs#50

Open

ThexXTURBOXx linked a pull request Nov 5, 2022 that will close this issue

Properly remove all deprecations #224

Open

rusty-snake mentioned this issue Nov 6, 2022

CI Warnings and use of actions-rs actions libseccomp-rs/libseccomp-rs#188

Closed

pentamassiv mentioned this issue Nov 17, 2022

Replace actions-rs/toolchain with dtolnay/rust-toolchain antoyo/relm#301

Merged

miles170 mentioned this issue Nov 18, 2022

CI: update actions to run on Node 16 uutils/coreutils#4157

Merged

offa mentioned this issue Nov 24, 2022

Update actions to fix deprecations robbert-vdh/yabridge#216

Merged

kazie mentioned this issue Nov 24, 2022

New style for '::set-output' magello-group/joel-bot#90

Merged

denschub mentioned this issue Dec 8, 2022

Improvements to the release process/CI denschub/camo-rs#15

Closed

7 tasks

caolan added a commit to caolan/deno-argon2 that referenced this issue Apr 21, 2023

Replace install rust step in workflow

ec2cb2f

The previous step used actions-rs which relies upon deprecated Node.js 12 actions. See: actions-rs/toolchain#219

caolan mentioned this issue Apr 21, 2023

Replace install rust step in workflow fdionisi/deno-argon2#9

Open

jleibs mentioned this issue Apr 25, 2023

Replace actions-rs/toolchain rerun-io/rerun#1961

Closed

Aadamandersson mentioned this issue May 10, 2023

Fix warnings in CI dada-lang/dada#226

Merged

reubenmiller mentioned this issue Jun 1, 2023

ci: remove usage of actions-rs/toolchain@v1 as it is not actively maintained thin-edge/thin-edge.io#1999

Merged

11 tasks

thiagowfx mentioned this issue Jun 6, 2023

Move CDDL job from Node 12 to Node 16 due to deprecated features w3c/webdriver-bidi#444

Closed

atgraha mentioned this issue Jul 12, 2023

Use cached builds cerridwen-io/babyrs#1

Open

xingkong23333 added a commit to bilibili-shell/bilibili-shell that referenced this issue Aug 9, 2023

chore: replace https://github.com/actions-rs/toolchain with https://g…

d7d1259

…ithub.com/dtolnay/rust-toolchain (actions-rs/toolchain#221 and actions-rs/toolchain#219)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Node.JS 12 deprecation on GitHub Actions #219

Node.JS 12 deprecation on GitHub Actions #219

caizixian commented Oct 8, 2022

Bromeon commented Oct 25, 2022

elibroftw commented Nov 7, 2022 •

edited

Loading

dallin-ukralabs commented Dec 6, 2022

a1ecbr0wn commented Apr 17, 2023

Ujang360 commented Apr 17, 2023

milesj commented May 5, 2023

mgeisler commented May 8, 2023

milesj commented May 8, 2023

mgeisler commented May 9, 2023

istellino-chub commented Aug 30, 2023

Finomnis commented Aug 30, 2023 •

edited

Loading

istellino-chub commented Aug 30, 2023

Finomnis commented Aug 30, 2023 •

edited

Loading

istellino-chub commented Aug 30, 2023 •

edited

Loading

Finomnis commented Aug 30, 2023 •

edited

Loading

Node.JS 12 deprecation on GitHub Actions #219

Node.JS 12 deprecation on GitHub Actions #219

Comments

caizixian commented Oct 8, 2022

Description

Workflow code

Action output

Expected behavior

Additional context

Bromeon commented Oct 25, 2022

elibroftw commented Nov 7, 2022 • edited Loading

dallin-ukralabs commented Dec 6, 2022

a1ecbr0wn commented Apr 17, 2023

Ujang360 commented Apr 17, 2023

milesj commented May 5, 2023

mgeisler commented May 8, 2023

milesj commented May 8, 2023

mgeisler commented May 9, 2023

istellino-chub commented Aug 30, 2023

Finomnis commented Aug 30, 2023 • edited Loading

istellino-chub commented Aug 30, 2023

Finomnis commented Aug 30, 2023 • edited Loading

istellino-chub commented Aug 30, 2023 • edited Loading

Finomnis commented Aug 30, 2023 • edited Loading

elibroftw commented Nov 7, 2022 •

edited

Loading

Finomnis commented Aug 30, 2023 •

edited

Loading

Finomnis commented Aug 30, 2023 •

edited

Loading

istellino-chub commented Aug 30, 2023 •

edited

Loading

Finomnis commented Aug 30, 2023 •

edited

Loading