[fix][client] fix negative message re-delivery twice issue #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etrics` in Pulsar Loadbalancer (apache#16832)
Co-authored-by: Zixuan Liu <nodeces@gmail.com>
…wer Maven versions (apache#20198)
…t from deep build insights (apache#20187)
…rty (apache#20201) Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: Zike Yang <zike@apache.org>
… subscription type (apache#20210)
…ic stats (apache#20229) ### Motivation A producer of the remote cluster is automatically created when replication is turned on. But we can't see anything about it from the response of `(remote cluster) pulsar-admin topic stats` ### Modifications Make this producer displayed in the topic stats
…19027) Signed-off-by: tison <wander4096@gmail.com> Co-authored-by: tison <wander4096@gmail.com>
Fixes apache#20236 PIP: apache#19409 ### Motivation In the `AuthenticationService`, we are currently using the deprecated `authenticate` methods. As a result, we hit the `Not Implemented` exception when using the `AuthenticationProviderOpenID`. This PR updates the implementation so that we're able This solution isn't ideal for two reasons. 1. We are not using the `authenticationHttpRequest` method, which seems like the right method for the WebSocket proxy. However, this is not a viable option, as I documented in apache#20237. 2. We are calling `.get()` on a future. However, it is expected that the `AuthenticationProvider` not block forever, so I think this is acceptable for now. Please let me know if you disagree. ### Modifications * Replace `authenticate` with `authenticateAsync`. ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. ### Documentation - [x] `doc-not-needed` Note that I do have documentation showing that 3.0.x does not support OIDC in the WebSocket Proxy. The `next` docs don't need that limitation since this PR fixes that and targets 3.1.0. apache/pulsar-site#558 ### Matching PR in forked repository PR in forked repository: skipping for this trivial PR
…pluggable (apache#20537) Co-authored-by: Yunze Xu <xyzinfernity@163.com>
…age has any exception. (apache#20613)
Signed-off-by: tison <wander4096@gmail.com>
…hannel (apache#20677) ### Motivation When topic lookups race(and the first lookup returns too fast before the second request gets deduped), the later lookup requests can timeout because the skipped messages are ignored at the table view and do not notify the service unit state channel. ex: m1: assign to b1 -> m2: owned by b1 -> m3: assign to b2 // m3 is skipped at the tableview When m3 is skipped, we better get the channel notified to return the lookup request with the current owner(b1) instead of letting the request time out. ### Modifications - Added the `handleSkippedMessage` and `setSkippedMsgHandler` in `TopicCompactionStrategy`. - `ServiceUnitStateChannel` registers `ServiceUnitStateChannel.handleSkippedEvent` to `ServiceUnitStateCompactionStrategy` by `setSkippedMsgHandler`. - TableView calls `TopicCompactionStrategy.handleSkippedMessage` when messages are skipped.
…ntion exists (apache#20690) Motivation: When a retention policy exists, the command `pulsar-admin namespaces set-backlog-quota` does not take effect.In the PR apache#17383: it only checked the compatibility of `retention` and `backlog quota`, and it was not set. Modifications: Fix the bug.
…he#12599) Signed-off-by: tison <wander4096@gmail.com> Co-authored-by: shrathore <shrathore@fanatics.com> Co-authored-by: tison <wander4096@gmail.com>
Fixes: apache#20688 ### Motivation When a function throws an exception that ends processing, we should exit the JVM. ### Modifications * Update `JavaInstanceMain` so that an exception leads to exiting the JVM. Since the class does not use any dependencies (see the class's Javadoc), we use reflection to shutdown logging. ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. ### Documentation - [x] `doc-not-needed`
Motivation: apache#19880 (comment) When Kafka connector is closing, it waits for the `runnerThread` to stop, but the task-close is running at the same thread, so it will be stuck. Modifications: run `close` in another thread.
…e unnecessary zk metadata (apache#18222) Co-authored-by: fanjianye <fanjianye@bigo.sg>
Signed-off-by: zhangwd3 <zhangwd3@asiainfo.com>
Signed-off-by: tison <wander4096@gmail.com>
…nscryptProvider()` fails to find Conscrypt with unknown error (apache#20705)
Co-authored-by: 张浩 <zhanghao60@100.me>
…kerInterceptors is true apache#20422" (apache#20710)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for running tests for upstream PR apache#20750.