Snapshot release v4 #460
Snapshot release v4 #460
Conversation
* Initial revision of amppackager on gcloud deployment.
Reduce the size of the amppkg binary from 45M to 17M, by removing the dependency on the rarely-needed DNS-01 libraries, unless `go build -tags dns01` is specified.
For pages with amp-script max-age<=86400, this will return plain HTML rather than generating an already-expired SXG.
An old OCSP cache causes a parse error of ``` Error computing OCSP midpoint: Parsing OCSP: no response matching the supplied certificate ``` in case of cert renewal. Do not log it before initialization is completed.
* Updated Dockerfiles for consumer and renewer to use multi-stage and reduce docker image sizes from 2GB to 12.3MB * Added comments to sync up consumer file to renewer
PiperOrigin-RevId: 298721329
PiperOrigin-RevId: 300124264
If fetch param is required by config but missing from the request, respond with a 400 instead of panicking. Add tests for that and missing sign param.
The URI end-point for the CSP Collector used by AMP was changed recently. This commit changes the report-uri to match.
…eload tag PiperOrigin-RevId: 305138625
…in (#408) GCP. Also used a better link for picking compute engine zones.
…tag insertion for FixedLayer experiment PiperOrigin-RevId: 306951883
Co-authored-by: Naina Raisinghani <nainar@google.com>
Add mux tests.
Refactor mux. Will simplify adding Prometheus metrics endpoint (#357).
Update setup instructions in README.md.
PiperOrigin-RevId: 310025020
Another metric per request #357.
Another metric per request #357.
Go 1.15's net/url package changes the handling of escaped URL fragments to preserve the original escaping when possible.
For example,
fmt.Println(url.Parse("https://example.com/amp.html#htmlURL=http%3A%2F%2Fbar.com%2Fbaz"))
// Go 1.14: https://example.com/amp.html#htmlURL=http://bar.com/baz <nil>
// Go 1.15: https://example.com/amp.html#htmlURL=http%3A%2F%2Fbar.com%2Fbaz <nil>
Upstream change: https://go.googlesource.com/go/+/8c00e07#
Drop two test cases that depend on the exact behavior of Go 1.14, which will break when run with Go 1.15. These tests have comments indicating that the preferred result would be that of Go 1.15.
Since these tests appear to exist specifically to exercise the undesired path (there are other test cases exercising escaping URL fragments), dropping the tests seems simplest.
PiperOrigin-RevId: 312422252
Another metric per request #357.
…tags. Add dockerfile for init container for AMP Packager. Modify base image of renewer and consumer to use alpine instead of scratch. (#441)
Also, return in case of "Not packaging because of internal SelectVersion" error.
Remove some requirements of SXG payload Update the document and remove the requirement of Google AMP cache SXG payload to be unchanged after transform, and remove the UTF-8 related requirement.
GO111MODULES=on allows it to be tested with the exact version of the dependencies specified in go.mod for Go 1.11 and Go.12, and not the newest version of each such dep. This fixes a build failure caused by a commit to github.com/stretchr/testify 3 days ago; see https://travis-ci.org/github/ampproject/amppackager/builds/710522601. Go 1.10 did not support modules in any form. It did support vendored directories, but I'm not sure how to make Travis not run `go get` and update them. So, let's finally stop testing on Go 1.10. https://travis-ci.org/github/ampproject/amppackager/builds/710522601.
…re applied to all <img> tags, not just those inside <noscript>. This is relevant as of ampproject/amphtml#29025. PiperOrigin-RevId: 318935030
PiperOrigin-RevId: 322416564
PiperOrigin-RevId: 324688627
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
All commit authors have signed the CLA, as verified in the original commits to master. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
No description provided.