Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot release v4 #460

Merged
merged 46 commits into from
Aug 4, 2020
Merged

Snapshot release v4 #460

merged 46 commits into from
Aug 4, 2020

Commits on Feb 13, 2020

  1. Configuration menu
    Copy the full SHA
    3c2a3cf View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2020

  1. Initial revision of gcloud deployment (#392)

    * Initial revision of amppackager on gcloud deployment.
    banaag authored Feb 14, 2020
    Configuration menu
    Copy the full SHA
    cd24739 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. Make binary smaller by default, disabling DNS-01. (#394)

    Reduce the size of the amppkg binary from 45M to 17M, by removing the
    dependency on the rarely-needed DNS-01 libraries, unless
    `go build -tags dns01` is specified.
    twifkak authored Feb 24, 2020
    Configuration menu
    Copy the full SHA
    2f67266 View commit details
    Browse the repository at this point in the history
  2. Proxy unsigned if expires is in the past. (#396)

    For pages with amp-script max-age<=86400, this will return plain HTML
    rather than generating an already-expired SXG.
    twifkak authored Feb 24, 2020
    Configuration menu
    Copy the full SHA
    5d98f06 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2020

  1. Do not log an OCSP error in case of cert renewal (#399)

    An old OCSP cache causes a parse error of
    ```
    Error computing OCSP midpoint: Parsing OCSP: no response matching the supplied certificate
    ```
    in case of cert renewal.
    Do not log it before initialization is completed.
    shigeki authored Feb 28, 2020
    Configuration menu
    Copy the full SHA
    7b4e388 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. Configuration menu
    Copy the full SHA
    76a7195 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. Updated Dockerfiles for consumer and renewer (#402)

    * Updated Dockerfiles for consumer and renewer to use multi-stage and reduce docker image sizes from 2GB to 12.3MB
    
    * Added comments to sync up consumer file to renewer
    banaag authored Mar 9, 2020
    Configuration menu
    Copy the full SHA
    b3f27f4 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. AMP Cache Origin changes as described in ampproject/amphtml#26205

    PiperOrigin-RevId: 298721329
    Googler authored and twifkak committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    a0b1100 View commit details
    Browse the repository at this point in the history
  2. Internal change

    PiperOrigin-RevId: 300124264
    Googler authored and twifkak committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    80640f9 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2020

  1. Fix crash on missing fetch param. (#406)

    If fetch param is required by config but missing from the request,
    respond with a 400 instead of panicking. Add tests for that and missing
    sign param.
    twifkak authored Mar 31, 2020
    Configuration menu
    Copy the full SHA
    e63c36d View commit details
    Browse the repository at this point in the history
  2. Replace csp-collector.appspot.com with csp.withgoogle.com (#403)

    The URI end-point for the CSP Collector used by AMP was changed recently.
    
    This commit changes the report-uri to match.
    rsimha authored Mar 31, 2020
    Configuration menu
    Copy the full SHA
    0f7c4fb View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. Make amp-viewer-integration script render-delaying to add link rel=pr…

    …eload tag
    
    PiperOrigin-RevId: 305138625
    Googler authored and twifkak committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    03efa72 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2020

  1. Added more documentation to cover the case of domain scoped projects …

    …in (#408)
    
    GCP. Also used a better link for picking compute engine zones.
    banaag authored Apr 15, 2020
    Configuration menu
    Copy the full SHA
    8172a3a View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2020

  1. Fix amp-viewer-integration script tag detection for link rel=preload …

    …tag insertion for FixedLayer experiment
    
    PiperOrigin-RevId: 306951883
    Googler authored and banaag committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    ef15d4e View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2020

  1. Create CODE_OF_CONDUCT.md (#411)

    Co-authored-by: Naina Raisinghani <nainar@google.com>
    twifkak and nainar authored Apr 27, 2020
    Configuration menu
    Copy the full SHA
    efc9fb4 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2020

  1. Add mux tests.

    MichaelRybak committed May 1, 2020
    Configuration menu
    Copy the full SHA
    0fcd181 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2020

  1. Merge pull request #413 from MichaelRybak/muxt

    Add mux tests.
    MichaelRybak authored May 2, 2020
    Configuration menu
    Copy the full SHA
    1952ba3 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. Refactor mux - introduce the routing matrix. (#416)

    Refactor mux. Will simplify adding Prometheus metrics endpoint (#357).
    MichaelRybak authored May 6, 2020
    Configuration menu
    Copy the full SHA
    1015592 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2020

  1. Configuration menu
    Copy the full SHA
    015da4b View commit details
    Browse the repository at this point in the history
  2. Update README. (#414)

    Update setup instructions in README.md.
    MichaelRybak authored May 7, 2020
    Configuration menu
    Copy the full SHA
    106947c View commit details
    Browse the repository at this point in the history

Commits on May 11, 2020

  1. Absolutify URLs in form verify-xhr attributes in the AMP transformers.

    PiperOrigin-RevId: 310025020
    Greg Grothaus authored and MichaelRybak committed May 11, 2020
    Configuration menu
    Copy the full SHA
    f6bfb2d View commit details
    Browse the repository at this point in the history
  2. Add "metrics" Prometheus endpoint - total requests by type and code. (#…

    …417)
    
    Add "metrics" endpoint. Provide a Prometheus counter of # of request broken down by request type and HTTP response code.
    
    This partly implements request #357. More metrics to be added.
    MichaelRybak authored May 11, 2020
    Configuration menu
    Copy the full SHA
    00ed240 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2020

  1. Add end-to-end latency Prometheus metric. (#422)

    Another metric per request #357.
    MichaelRybak authored May 20, 2020
    Configuration menu
    Copy the full SHA
    f0eec2b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7162ed1 View commit details
    Browse the repository at this point in the history
  3. Add total gateway requests Prometheus metric. (#425)

    Another metric per request #357.
    MichaelRybak authored May 20, 2020
    Configuration menu
    Copy the full SHA
    aeca3fe View commit details
    Browse the repository at this point in the history

Commits on May 26, 2020

  1. Go 1.15: Drop tests cases depending on changing URL behavior

    Go 1.15's net/url package changes the handling of escaped URL fragments to preserve the original escaping when possible.
    
    For example,
    
    fmt.Println(url.Parse("https://example.com/amp.html#htmlURL=http%3A%2F%2Fbar.com%2Fbaz"))
    // Go 1.14: https://example.com/amp.html#htmlURL=http://bar.com/baz <nil>
    // Go 1.15: https://example.com/amp.html#htmlURL=http%3A%2F%2Fbar.com%2Fbaz <nil>
    
    Upstream change: https://go.googlesource.com/go/+/8c00e07#
    
    Drop two test cases that depend on the exact behavior of Go 1.14, which will break when run with Go 1.15. These tests have comments indicating that the preferred result would be that of Go 1.15.
    
    Since these tests appear to exist specifically to exercise the undesired path (there are other test cases exercising escaping URL fragments), dropping the tests seems simplest.
    
    PiperOrigin-RevId: 312422252
    Googler authored and banaag committed May 26, 2020
    Configuration menu
    Copy the full SHA
    25169c1 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2020

  1. Add gateway request latency Prometheus metric. (#429)

    Another metric per request #357.
    MichaelRybak authored May 30, 2020
    Configuration menu
    Copy the full SHA
    a974227 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Configuration menu
    Copy the full SHA
    fd8f3ec View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. FIXIT: fixes #188. Adds explicit -staging command line flag to use fo…

    …r development-mode cert url host. (#437)
    banaag authored Jun 8, 2020
    Configuration menu
    Copy the full SHA
    72682de View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ce10ebb View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. Configuration menu
    Copy the full SHA
    ec46ffd View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. Configuration menu
    Copy the full SHA
    24016e1 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. Update the docker images of consumer and renewer to have C2D_RELEASE …

    …tags. Add dockerfile for init container for AMP Packager. Modify base image of renewer and consumer to use alpine instead of scratch. (#441)
    banaag authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    70ecc12 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Configuration menu
    Copy the full SHA
    a224ce6 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2020

  1. Configuration menu
    Copy the full SHA
    c85b103 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. Configuration menu
    Copy the full SHA
    eca97fc View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. Configuration menu
    Copy the full SHA
    fbbb1e5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    abe58b4 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2020

  1. Signer: prefer proxying over responding with an error. (#448)

    Also, return in case of "Not packaging because of internal SelectVersion" error.
    MichaelRybak authored Jul 1, 2020
    Configuration menu
    Copy the full SHA
    dc88683 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2020

  1. Configuration menu
    Copy the full SHA
    8d92799 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. Remove some requirements of SXG payload (#452)

    Remove some requirements of SXG payload
    
    Update the document and remove the requirement of Google AMP cache
    SXG payload to be unchanged after transform, and remove the UTF-8
    related requirement.
    caoboxiao authored Jul 14, 2020
    Configuration menu
    Copy the full SHA
    6473ccf View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. Travis: GO111MODULES=on, disable Go 1.10 (#455)

    GO111MODULES=on allows it to be tested with the exact version of the
    dependencies specified in go.mod for Go 1.11 and Go.12, and not the
    newest version of each such dep.
    
    This fixes a build failure caused by a commit to
    github.com/stretchr/testify 3 days ago; see
    https://travis-ci.org/github/ampproject/amppackager/builds/710522601.
    
    Go 1.10 did not support modules in any form. It did support vendored
    directories, but I'm not sure how to make Travis not run `go get` and
    update them. So, let's finally stop testing on Go 1.10.
    https://travis-ci.org/github/ampproject/amppackager/builds/710522601.
    twifkak authored Jul 23, 2020
    Configuration menu
    Copy the full SHA
    04f1ac2 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2020

  1. Update urlrewrite transformer documentation to reflect that changes a…

    …re applied to all <img> tags, not just those inside <noscript>. This is relevant as of ampproject/amphtml#29025.
    
    PiperOrigin-RevId: 318935030
    twifkak committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    bcb781d View commit details
    Browse the repository at this point in the history
  2. Skip <a target> transformation for signed exchanges.

    PiperOrigin-RevId: 322416564
    twifkak committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    f98a458 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2020

  1. Configuration menu
    Copy the full SHA
    ff54f95 View commit details
    Browse the repository at this point in the history
  2. Release version 4 of AMP cache transforms. (#459)

    PiperOrigin-RevId: 324688627
    banaag authored Aug 3, 2020
    Configuration menu
    Copy the full SHA
    da8a000 View commit details
    Browse the repository at this point in the history