fix(ngOptions): override select option registration

[petebacondarwin]

When ngOptions is present on a select, the option directive should not be able to
register options on the selectCtrl since this may cause errors during the
ngOptions lifecycle.

This can happen in the following cases:

• there is a blank option below the select element, an ngModel
  directive, an ngOptions directive and some other directive on the select
  element, which compiles the children of the select
  (i.e. the option elements) before ngOptions is has finished linking.
• there is a blank option below the select element, an ngModel
  directive, an ngOptions directive and another directive, which uses
  templateUrl and replace:true.

What happens is:

• the option directive is compiled and adds an element $destroy listener
  that will call ngModel.$render when the option element is removed.
• when ngOptions processes the option, it removes the element, and
  triggers the $destroy listener on the option.
• the registered $destroy listener calls $render on ngModel.
• $render calls selectCtrl.writeValue(), which accesses the options
  object in the ngOptions directive.
• Since ngOptions has not yet completed linking the options has not
  yet been defined and we get an error.

This fix moves the registration code for the option directive into the
SelectController, which can then be easily overridden by the ngOptions
directive as a noop.

Fixes #11685
Closes #12972
Closes #12968

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

[Narretz]

can we call it registerOption?

[Narretz]

Also, we inject $scope into the selectController. It's possibly a bit confusing to have a parameter with the same name in this fn.

[petebacondarwin]

OK, so I'll change the function to:

replaceOption($optionScope, $optionElement, $optionAttrs, interpolateValueFn, interpolateTextFn) { ... }

OK?

[Narretz]

Is replaceOption a typo? Otherwise sgtm

[gkalpak]

Why the $-prefix in the first 3 args ?

[petebacondarwin]

Yes, I meant registerOption :-)

So in the Angular code, elements that are wrapped in jqLite are prefixed with a dollar, and I always prefer to do the same with the attributes and scope, since they are "Angular" things, not from the user's application space. I guess that this is not that common so I don't mind dropping them if they would cause confusion.

[godza]

Great news. Thanks!

[petebacondarwin]

Backported to 1.4 too