chore(lambda-nodejs): prepare code to reduce merge conflicts when deprecated APIs are stripped #13738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nija-at
changed the title
nija-at
changed the title
nija-at
force-pushed
the
nija-at/bundling-deprecated
branch
from
ce53fa0 to
c3c831f
Compare
…n CORS (#13313) API gateway expects `*` to represent `ANY` HTTP method. `HttpMethod` enum doesn't have a value for that, thus causing errors when passing `HttpMethod` 's `ANY` option. This commit introduces `CorsHttpMethod` enum which has a proper `ANY` mapping to `*`. Closes #13280. Closes #13643. BREAKING CHANGE: The type of `allowMethods` property under `corsPreflight` section is changed from `HttpMethod` to `CorsHttpMethod`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…onds results in an error (#13689) A previous change - b1449a1 - introduced a validation that should have been applied only when Duration is specified as a token. Instead, it was applied for non token values as well. Adjusting the validation so it only applies to when the duration is a token. fixes #13566 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ed" error (#13637) Previously access control lists for putObject was not called. This had led in getting access denied issue when trying to upload objects into the s3 bucket fixes #13557 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
nija-at
changed the title
jogold
reviewed
Mar 23, 2021
| @@ -11,7 +11,7 @@ import * as util from '../lib/util'; | |||
| jest.mock('@aws-cdk/aws-lambda'); | |||
|
|
|||
| // Mock BundlingDockerImage.fromAsset() to avoid building the image | |||
| let fromAssetMock = jest.spyOn(BundlingDockerImage, 'fromAsset'); | |||
| let fromAssetMock = jest.spyOn(DockerImage, 'fromBuild'); | |||
There was a problem hiding this comment.
nit: adapt the comment above
eladb
approved these changes
Mar 24, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Mar 24, 2021
…recated APIs are stripped (aws#13738) BUNDLING - The `BundlingDockerImage` class is deprecated, replaced by `DockerImage`. Remove all uses of this class across modules in a backwards compatible way. ECR ASSET - Change the way symbols are imported from '@aws-cdk/assets' so that they can be in-place replaced with their replacements from '@aws-cdk/core' module. The `IAsset` interface from the core module introduces the property `assetHash` instead of `sourceHash`. This change makes the code forwards compatible so as to be supportive on v2. Other small backwards compatible changes. BREAKING CHANGE: The type of `image` property in the `Bundling` class is changed from `BundlingDockerImage` to `DockerImage`. * **lambda-nodejs**: The type of `dockerImage` property in `BundlingOptions` is changed from `BundlingDockerImage` to `DockerImage`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…recated APIs are stripped (aws#13738) BUNDLING - The `BundlingDockerImage` class is deprecated, replaced by `DockerImage`. Remove all uses of this class across modules in a backwards compatible way. ECR ASSET - Change the way symbols are imported from '@aws-cdk/assets' so that they can be in-place replaced with their replacements from '@aws-cdk/core' module. The `IAsset` interface from the core module introduces the property `assetHash` instead of `sourceHash`. This change makes the code forwards compatible so as to be supportive on v2. Other small backwards compatible changes. BREAKING CHANGE: The type of `image` property in the `Bundling` class is changed from `BundlingDockerImage` to `DockerImage`. * **lambda-nodejs**: The type of `dockerImage` property in `BundlingOptions` is changed from `BundlingDockerImage` to `DockerImage`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUNDLING - The
BundlingDockerImageclass is deprecated,replaced by
DockerImage. Remove all uses of this classacross modules in a backwards compatible way.
ECR ASSET - Change the way symbols are imported from
'@aws-cdk/assets' so that they can be in-place replaced with
their replacements from '@aws-cdk/core' module.
The
IAssetinterface from the core module introduces theproperty
assetHashinstead ofsourceHash. This changemakes the code forwards compatible so as to be supportive
on v2.
Other small backwards compatible changes.
BREAKING CHANGE: The type of
imageproperty in theBundlingclass is changed fromBundlingDockerImagetoDockerImage.dockerImageproperty inBundlingOptionsis changed fromBundlingDockerImagetoDockerImage.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license