Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 1.56.0 #9379

Merged
merged 20 commits into from
Jul 31, 2020
Merged

chore(release): 1.56.0 #9379

merged 20 commits into from
Jul 31, 2020

Conversation

aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Jul 31, 2020

See CHANGELOG

mergify bot and others added 20 commits July 28, 2020 23:02
There is no point in doing the compatibility check when spinning up a new Gitpod workspace,
so add an option to build.sh to skip it,
and use it for the Gitpod build.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Change the Origin to an interface, from an abstract class, and change its `bind` protocol to return an `OriginBindConfig` interface.

This is in preparation for handling Origin Groups in #9109 - when time comes to handle Origin Groups, we will add a new (optional) property to `OriginBindConfig`, of type `CfnDistribution.OriginGroupProperty`, and handle it in `Distribution`.

BREAKING CHANGE: the property Origin.domainName has been removed

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…#9326)

Prior to this change, there were both HttpOrigin and S3Origin classes in both
the aws-cloudfront and aws-cloudfront-origins module. The behaviors of the
S3Origin classes were also slightly different.

This change removes the duplication by removing the aws-cloudfront versions of
the origins.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Implements #9336 
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
----

Closes  #9228 

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Collapse the PipelineAssetsRoleDefaultPolicy into a single up-front policy that
doesn't grow per-asset. This relaxes some of the permissions in exchange for
avoiding an O(N) policy size.

fixes #9316

_Testing notes:_ Successfully deployed a pipeline with 49 assets (25 file assets and 24 docker assets). 50 assets is the limit for a single stage of the pipeline. To scale out past 50 assets, we will need to segment the assets pipeline stage into multiple stages. I'm considering that out-of-scope for this bugfix.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
)

If a certificate with automatic (Route53) DNS validation contains both a base
domain name and the wildcard for that domain (e.g., `example.com` and
`*.example.com`), the corresponding DNS validation records are identical.
This seems to have caused problems for the automated CloudFormation DNS
validation.

Solving the problem by removing the redundant wildcard entries from the
DomainValidationOption.

fixes #9248


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
… examples in pipelines README (#9344)

Ran across some of these when preparing the How-To topic for the CDK Dev Guide; backporting to the README.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
name is the old name for actionName
…#8826)

**[ISSUE]**
Honestly, kind of miss being able to use `lerna` for any kind of npm test through parameters with the old `builddown`. Wanted to be able to run something like `builddown build+test` or `builddown test`.

**[APPROACH]**
Added a `-r | --reset` flag to allow the `foreach.sh` script to reset and run in one line like `builddown`/`buildup`.

**[NOTE]**
Won't change anyone's current workflow because `--reset` is still in codebase.

Also arguments for the script aren't restricted by order (i.e. `foreach.sh --reset --up yarn build ` and `builddown yarn build --up --reset` will produce the same results)!

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Making a small -- but useful -- README change as an excuse to capture the
breaking changes made in #9326, but that were missed in that commit message.

BREAKING CHANGE: Removed origin classes from the aws-cloudfront module.
* **aws-cloudfront:** Removed S3Origin and HttpOrigin from the aws-cloudfront module. Use the S3Origin and HttpOrigin classes in the aws-cloudfront-origins module instead.
* **aws-cloudfront:** Renamed Origin to OriginBase.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
**[ISSUE]**
schema definition mode is not strongly typed.

**[APPROACH]**
Make input prop `schemaDefinition` take a enum that allows users to choose between 2 modes: `CODE` and `FILE`. 

**[NOTE]**
This approach was taken in preparation for a code-first approach to schema generation with CDK. All of the functions tagged `@experimental` are subject to change.

BREAKING CHANGE: **appsync** prop `schemaDefinition` no longer takes string, instead it is required to configure schema definition mode.
- **appsync**: schemaDefinition takes param `SchemaDefinition.XXX` to declare how schema will be configured
  - **SchemaDefinition.CODE** allows schema definition through CDK
  - **SchemaDefinition.FILE** allows schema definition through schema.graphql file

Fixes #9301 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
----

Closes #9368 

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…#9359)

Expanding integ test coverage by ensuring there is one integ test per origin type.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes #9364 

----

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
@aws-cdk-automation aws-cdk-automation added the pr/no-squash This PR should be merged instead of squash-merging it label Jul 31, 2020
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 2b00bf5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c1c174d into release Jul 31, 2020
@mergify mergify bot deleted the bump/1.56.0 branch July 31, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-squash This PR should be merged instead of squash-merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants