Yearn linear pool integration #5

danielmkm · 2022-09-05T15:49:18Z

YearnLinearPool
YearnLinearPoolFactory
YearnWrapping

pkg/pool-linear/test/YearnLinearPool.test.ts

0xSkly · 2022-09-06T07:42:09Z

pkg/pool-linear/test/YearnLinearPoolFactory.test.ts

+      pool = await createPool();
+    });
+
+    it('sets the vault', async () => {


not sure what / if they have a standard for test names but on the other tests you used the should do x... notion and here without the should. might wanna have it consistent

these were copy pasted from another test set of theirs. not entirely sure how to name them using their pattern

pkg/standalone-utils/contracts/relayer/YearnWrapping.sol

0xSkly · 2022-09-06T07:53:28Z

pkg/standalone-utils/test/YearnWrapping.test.ts

+      expectTransferEvent(receipt, { from: user.address, to: relayer.address, value: amount }, dai);
+      expectTransferEvent(receipt, { from: ZERO_ADDRESS, to: user.address, value: yvDaiForAmount }, yvDAI);


isnt there a more explicit way to verify the token wrapping than checking against transfer events? i mean i guess its pretty reliable but couldnt you also check if dai.balanceOf(yvDAI).is.eq(amount) and yvDAI.balanceOf(user).is.eq(yvDaiForAmount)

hey, ya agree. did that originally but changed to this method as its how it's being used in other tests 🤷

pkg/standalone-utils/test/YearnWrapping.test.ts

0xSkly · 2022-09-06T07:59:51Z

pkg/standalone-utils/test/YearnWrapping.test.ts

+      await expectChainedReferenceContents(relayer, toChainedReference(0), daiForAmount);
+    });
+  });
+});


there are no tests to deposit / withdraw to a different user. i mean there is kinda with the relayer as a target but seems like also a bit of a different usecase

* feat: add semantic constants for different meanings of 1 and 0 * refactor: propagate to other helpers * refactor: use semantic FP constants in pool-linear * refactor: use semantic FP constants in pool-stable * refactor: use semantic FP constants in pool-utils * refactor: use semantic FP constants in pool-weighted * refactor: use semantic FP constants in vault/utils * fix: adjust remaining files to remove FP_SCALING_FACTOR * fix: import arrayFpMul * lint * refactor:use FP_100_PCT in expectedAUMFees Co-authored-by: Tom French <tom@tomfren.ch>

* Adding benchmark for relayer multicall. * Adding relayer benchmark to CI. * Update pvt/benchmarks/relayer.ts Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com> * Doing 32-byte jumps in relayer benchmark. Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>

…ences. (balancer#1763)

* refactor: push join type handlers into a library * refactor: push exit type handlers into a library

* refactor: flatten isOnlyOwnerAction function * test: add tests that ManagedPool implements _isOnlyOwnerAction correctly * fix: update to account for setSwapFeePercentage moving to ManagedPool * refactor: remove redundant super * style: lint

* Extend PoolRegLib * Add tests

…alancer#1772) * refactor: avoid double zero duration check in calculateValueChangeProgress * refactor: remove unnecessary safemath in interpolate value * docs: update comment

* IMport hardhat inlie * tom big brain nico smol brain

* refactor: cache token weight in _onSwapGivenIn/Out * refactor: reuse weightChangeProgress for both weights * refactor: pass tokens to _getNormalizedWeights * refactor: use poolId from arg rather than getter * refactor: reduce bytecode * style: reorder functions * refactor: make getInvariant external

* Adding basic Foundry support and test. * Importing skip foundry tests in base hh config. * Removing mock foundry tests. * Adding foundry tests to CI. * Moving forge-std to pvt. * Adding foundry.toml to remaining yarn workspaces. * Adding forge tests to CI in applicable packages. * Fix for asset managers CI. * WIP: CI test * Removing hardhat console from DoubleEntrypointFixRelayer (breaks forge build). * Fixing submodules. * forge-test --> test-fuzz. - -vv --> -vvv * Removing submodules from CI. * Using symlinks for foundry.toml.

* refactor: pull _poolState up into ManagedPool * refactor: remove virtual keyword from functions on ManagedPool * refactor: remove getters for min and max swap fees

* refactor: move swap fees functions into a separate module contract * refactor: pass poolState into ManagedPoolSwapFees * refactor: move swap fee validation into _startGradualSwapFeeChange * test: add test suite for ManagedPoolSwapFees * test: remove tests from ManagedPool.test.ts which is covered by new suite * refactor: remove some of the nasty overrides * refactor: move external getters onto ManagedPool * refactor: inline getters which are only used once * test: update tests to reflect that we don't expose min and max anymore * feat: enforce proper resolution of start time in ManagedPoolSwapFees * test: add time travel test * refactor: return updated pool state from ManagedPoolSwapFees This is opposed to directly writing to storage * docs: add natspec * test: add authentication tests on updateSwapFeeGradually * fix: set pool state properly in constructor * refactor: convert ManagedPoolSwapFees into a library * style: linting * chore: remove leftover console.log

Adding Foundry install instructions to README.

* Adding recursive submodules to CI for Forge tests. * Adding 'clone' step in main README to download submodules.

* refactor: remove warm read from swaps * fix: stack juggling * docs: add comment for stack issues

…alancer#1768)

…ncer#1779) * refactor: update _startGradualWeightChange to return updated pool state * docs: add a comment on the pool state variable.

* Add some fuzz tests * Improve input helpers test * Fix word codec tests

* test: replace ManagedPoolStorageLib tests with foundry fuzzing * test: restrict input range for swap fees * test: fix extra comma * refactor: use Test rather than DSTest * chore: add `pvt/lib/forge-std` to allows paths * test: replace usage of assetTrue with assertEq * test: recovered -> actual * test: make _MAX_SWAP_FEE check inclusive * chore: move fuzz tests into `test/foundry` * fix: ensure that amount of BPT to burn is less than LP balance

* Adding AaveWrapping test. * AaveWrapping test: senderUser --> user.

* refactor: remove asset manager setter * refactor: remove WordCodec from BasePool * refactor: remove unused imports * refactor: remove unused virtual function * refactor: rearrange functions in BasePool * refactor: remove mutableTokens argument from BaseWeightedPool constructor * refactor: remove _getMaxTokens() getter * refactor: remove setAssetManagerPoolConfig * style: fix linting

* chore: add new AaveLinearPool deployment * fix: add extra constructor arg to deploy script * chore: update comments * chore: deprecate old factory * chore: align markdown table * fix: update imports * docs: update readmes * test: update linear pool test to use USDT token rather than USDC * chore: add changelog entry * Update pkg/deployments/CHANGELOG.md Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com> * test: correct address for USDT holder * test: add test for malicious revert protection * test: remove `only` from fork test * fix: correct artifact name for MockAaveLendingPool * Revert "fix: correct artifact name for MockAaveLendingPool" This reverts commit 9f099e0. * Fix fork test CI build step * chore: remove formatting from build-info Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>

* refactor: move LBP storage handling to library * test: add test for error on token weight storage * style: linter * test: add tests for swaps and recovery mode * refactor: remove unused import * LBP explicit state refactor (balancer#2019) * refactor: avoid repeated storage reads by passing explicit state * refactor: inline swap fee helpers * Update pkg/pool-weighted/contracts/lbp/LiquidityBootstrappingPoolStorageLib.sol Co-authored-by: EndymionJkb <EndymionJkb@gmail.com> Co-authored-by: Jeffrey Bennett <endymionjkb@gmail.com>

* feat: move helpers to WordCodec * refactor: use new helpers * refactor: move test helpers from WordCodec to a new helper library * refactor: use new library in tests * refactor: remove double awaits * test: update LiquidityBootstrappingPoolStorageLibTest to use WordCodecHelpers Co-authored-by: Tom French <tom@tomfren.ch>

* Create recovery helper deployment * Add other networks

* Add tokens task * Use inputs * Add readme * Apply review comments

* Add Version for AaveLinearPool. * Add tests. * Adjust docs. * Using split pool / factory versions.

Co-authored-by: Tom French <tom@tomfren.ch>

* refactor: make unnecessarily async functions sync * docs: update readme to use new function signatures * chore: update changelog * Update pkg/deployments/CHANGELOG.md Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com> Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>

* Add Version unit test. * Replace foundry with TS.

- Update changelog.

* Deploy and verify pool on deployment * Oops

Add event for `performAction` in adaptor entrypoint.

…+ bytecode (balancer#2058) * feat: store artifacts rather than abi and bytecode separately * chore: extract artifact files for each contract * chore: delete contract abi and bytecode files * feat: expose contract artifacts to external users * feat: re-add a function to get a contract's ABI * docs: added changlog entries * fix: our artifacts weren't real artifacts * fix: use hardhat's linker rather than the workaround * style: the lintooor * refactor: remove redundant function * fix: correct remaining type issues * Update pkg/deployments/index.ts Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com> * Apply suggestions from code review Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com> Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>

…an abis (balancer#2061)

…2060) * Task rename. * Delete deployed transaction IDs / outputs (unused). * Update artifacts. * Update readme. * Update fork test block #.

0xSkly reviewed Sep 6, 2022

View reviewed changes

EndymionJkb and others added 29 commits September 14, 2022 09:59

refactor: remove BaseMinimalSwapInfoPool (balancer#1758)

3d1e814

Using the same storage slot for read-only and temporary chained refer…

6461702

…ences. (balancer#1763)

Removing unnecessary debug log from VaultActions test. (balancer#1764)

2e4a7ee

Push weighted join and exit types into a library (balancer#1759)

aa22d06

* refactor: push join type handlers into a library * refactor: push exit type handlers into a library

Flatten _isOnlyOwnerAction (balancer#1757)

feafc9e

* refactor: flatten isOnlyOwnerAction function * test: add tests that ManagedPool implements _isOnlyOwnerAction correctly * fix: update to account for setSwapFeePercentage moving to ManagedPool * refactor: remove redundant super * style: lint

Removing return values from VaultActions. (balancer#1765)

e66b5f2

refactor: flatten _doJoin (balancer#1760)

8fb97f2

Extend PoolRegLib (balancer#1770)

9e6aa98

* Extend PoolRegLib * Add tests

Avoid double zero duration check in calculateValueChangeProgress (b…

e261569

…alancer#1772) * refactor: avoid double zero duration check in calculateValueChangeProgress * refactor: remove unnecessary safemath in interpolate value * docs: update comment

Fix deployments package (balancer#1773)

da8a21e

* IMport hardhat inlie * tom big brain nico smol brain

Pull _poolState up into ManagedPool (balancer#1774)

c02afc7

* refactor: pull _poolState up into ManagedPool * refactor: remove virtual keyword from functions on ManagedPool * refactor: remove getters for min and max swap fees

Adding Foundry install instructions to README. (balancer#1775)

4f0ab44

Adding Foundry install instructions to README.

Recursive submodules ci (balancer#1780)

eec64ad

* Adding recursive submodules to CI for Forge tests. * Adding 'clone' step in main README to download submodules.

style: rearrange functions (balancer#1777)

c2b4c37

refactor: remove unused constants (balancer#1781)

dab7f2b

Inline getSwapEnabled() inside swap hooks (balancer#1778)

757b9ce

* refactor: remove warm read from swaps * fix: stack juggling * docs: add comment for stack issues

feat: automatically renormalize weight sum on gradual weight change (b…

611206b

…alancer#1768)

Update _startGradualWeightChange to return updated pool state (bala…

1f07236

…ncer#1779) * refactor: update _startGradualWeightChange to return updated pool state * docs: add a comment on the pool state variable.

refactor: rename WeightCompression to ValueCompression (balancer#1783)

0a26766

docs: typos and readability (balancer#1784)

ab6a15c

Add some random fuzz tests (balancer#1782)

0d62d62

* Add some fuzz tests * Improve input helpers test * Fix word codec tests

[Batch Relayer V4] AaveWrapping test (balancer#1715)

483b7f5

* Adding AaveWrapping test. * AaveWrapping test: senderUser --> user.

TomAFrench and others added 30 commits November 17, 2022 14:58

Create recovery helper deployment (balancer#2033)

89b815d

* Create recovery helper deployment * Add other networks

Add tokens task (balancer#2024)

6be4bfe

* Add tokens task * Use inputs * Add readme * Apply review comments

style: fix linter (balancer#2036)

552a311

Fix recovery readme (balancer#2037)

f1e452c

Aave linear pool versioning (balancer#2032)

6fd2dd9

* Add Version for AaveLinearPool. * Add tests. * Adjust docs. * Using split pool / factory versions.

Do deployment (balancer#2035)

0d155b6

Co-authored-by: Tom French <tom@tomfren.ch>

Update linear build info (balancer#2041)

7b0f617

Add Version unit test. (balancer#2038)

a7008b7

* Add Version unit test. * Replace foundry with TS.

docs: remove deprecated networks from jsdoc (balancer#2029)

d13ee43

Rename IPoolVersion --> IFactoryCreatedPoolVersion. (balancer#2045)

9f79fc1

- Update changelog.

Verify AaveLinearPool on deployment (balancer#2040)

09d147e

* Deploy and verify pool on deployment * Oops

Adaptor entrypoint events (balancer#2051)

9ef3ced

Add event for `performAction` in adaptor entrypoint.

Remove Protocol Fee Splitter task (balancer#2054)

368ba4d

chore: add missing action-ids (balancer#2025)

fd343fb

chore: update deployment readmes to point to artifact files rather th…

ac58b6c

…an abis (balancer#2061)

(Re) deployment preparation: AuthorizerAdaptorEntrypoint (balancer#…

ef70351

…2060) * Task rename. * Delete deployed transaction IDs / outputs (unused). * Update artifacts. * Update readme. * Update fork test block #.

Merge branch 'balancer-master' into yearn-linear-pool

82bb157

Add version support, port share value helper logic into contract

428d6b6

update YearnLinearPool tests to work with share value helper

6362799

fix lint errors

9ff001f

Add description note

3920ca6

Update docs to match the original implementation

3780b5b

add latest build-info

cad93a6

remove share value helper references

1054494

add versions to the deployment

7dd3620

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Yearn linear pool integration #5

Yearn linear pool integration #5

danielmkm commented Sep 5, 2022

0xSkly Sep 6, 2022

danielmkm Sep 6, 2022

0xSkly Sep 6, 2022

danielmkm Sep 6, 2022 •

edited

Loading

0xSkly Sep 6, 2022

		expectTransferEvent(receipt, { from: user.address, to: relayer.address, value: amount }, dai);
		expectTransferEvent(receipt, { from: ZERO_ADDRESS, to: user.address, value: yvDaiForAmount }, yvDAI);

Yearn linear pool integration #5

Are you sure you want to change the base?

Yearn linear pool integration #5

Conversation

danielmkm commented Sep 5, 2022

0xSkly Sep 6, 2022

Choose a reason for hiding this comment

danielmkm Sep 6, 2022

Choose a reason for hiding this comment

0xSkly Sep 6, 2022

Choose a reason for hiding this comment

danielmkm Sep 6, 2022 • edited Loading

Choose a reason for hiding this comment

0xSkly Sep 6, 2022

Choose a reason for hiding this comment

danielmkm Sep 6, 2022 •

edited

Loading