-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to block scripts individually #2449
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cezaraugusto
changed the title
Add option to block scripts individually
Add support for blocking scripts individually
May 15, 2019
cezaraugusto
changed the title
Add support for blocking scripts individually
Add support to block scripts individually
May 15, 2019
closing in favor of #2485 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#4336 (Too much bottom padding on scripts details view)
fix brave/brave-browser#4228 (Different number of scripts blocked in main view and detailed view)
fix brave/brave-browser#3431 (Change Shields numbers to count FQDNs rather than total requests)
fix brave/brave-browser#3367 (Show domain / subdomain not the full path for HTTPS detail view)
fix brave/brave-browser#3239 (Widen Shields panel to avoid text wrapping)
fix brave/brave-browser#2371 (Remove Block all text when there are no entries)
fix brave/brave-browser#3174 (Script blocked count included allowed scripts as well)
address brave/brave-browser#2996 (Surface script blocking shortcuts to "Allow once", fix scripts functionality, focus indicators, and scroll)
Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.