supply refactors #4604
Merged
supply refactors #4604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Account getters are removed from client context. x/auth has the queriers necessary for retrieving account information. These functions should be removed since they are currently redundant and don't provide any extra value. Closes: #4543
AccountDecoder is now entirely redundant. client package now does no longer depend on x/auth. Context: #4488
This flag isn't used anywhere and probably hasn't for quite some time.
rigelrozanski
requested review from
alessio,
alexanderbez and
jackzampolin
as code owners
|
@rigelrozanski is this R4R? It doesn't build. |
Added deadcode and unused linters to the repo, it helped find some unused code. Ref #4589
Cobra's new release made them redundant. Thanks: Juan Leni <juan.leni@zondax.ch> for the original patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactors for fede's supply module
closes #4546
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: