-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master to features/readonly-members #34629
Merged
170 commits merged into
features/readonly-members
from
merges/master-to-features/readonly-members
Apr 2, 2019
Merged
Merge master to features/readonly-members #34629
170 commits merged into
features/readonly-members
from
merges/master-to-features/readonly-members
Apr 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FI from master to features/DefaultInterfaceImplementation
… as part of its declaration. (#17927) Enable a default implementation of an interface method to be provided as part of its declaration.
…e provided as part of its declaration. (#18110)
…as part of its declaration. (#18183) Enable a default implementation of an interface event to be provided as part of its declaration.
Merge master into DefaultInterfaceImplementation
Enable implicit “this” in default interface implementations.
… extern and async modifiers with interface methods. (#18519)
Merge remote-tracking branch 'dotnet/master' into DefaultInterfaceImplementation
… and extern modifiers with interface properties and indexers. (#18892)
… and extern modifiers with interface events. (#19080)
**Protected** and **protected internal** accessibility is not supported.
Merge branch 'master' into 'DefaultInterfaceImplementation'
Merge remote-tracking branch 'dotnet/master' into DefaultInterfaceImplementation
…explicit implementation of inaccessible members. (#19549)
Merge 'dotnet/master' into DefaultInterfaceImplementation
…by using explicit implementation syntax. (#19876)
…at supports the feature.
Start running DefaultInterfaceImplementation tests against CoreCLR that supports the feature.
…e behavior when targeting CoreCLR. (#20097)
…s within interfaces. (#20165)
Merge 'dotnet/dev15.6' into DefaultInterfaceImplementation
Merge dev16.1-preview1 to master
Fix inverted condition in LegacyCompletionCondition
Fix Mono crash
* Implement pattern-matching in the nullable walker Fixes #29909 Fixes #31881 Fixes #30952 Fixes #33499 Fixes #30597 Fixes #32414 Fixes #23944 * Remove infinite recursion by using an empty struct cache. * Changes per code review comments. * Remove debugging code accidentally left behind. * Analysis of patterns-matching in the nullable walker requires valid (>0) slots. * Skip a flaky test * Patch after merge. * Make ctor private to force use of factory methods * Correct a typo. * Fixup after merge.
Move Powershell formatting to match arcade
Properly pass along cancellation token when calling OOP service during FAR.
Merge dev16.1-preview1 to master
Replace ArraySlice<T> with Span<T>
…features/readonly-members
…es/readonly-members
RikkiGibson
force-pushed
the
merges/master-to-features/readonly-members
branch
from
April 1, 2019 23:21
4720bb8
to
5ae1d00
Compare
ghost
approved these changes
Apr 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approval
ghost
deleted the
merges/master-to-features/readonly-members
branch
April 2, 2019 07:00
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into features/readonly-members.
git fetch --all git checkout merges/master-to-features/readonly-members git reset --hard upstream/features/readonly-members git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-features/readonly-members --force
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.