Merge release/dev16.3-preview1 to release/dev16.3-preview1-vs-deps #36808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code style settings we already had in a .editorconfig file supplied a set of terms to set different diagnostic severities. The terms don't match the underlying compiler enum, but we will adopt them for setting compiler diagnostic settings as well to keep the values consistent inside a .editorconfig file. Fixes #35690
…lized type of the same name
1. Make IDE0069 (DisposableFieldsShouldBeDisposed) conservative by bailing out on disposable types that don't have the Dispose implementation, but rely on base type implementing it and having virtual helper methods for dispose functionality 2. Make IDE0067 (DisposeObjectsBeforeLosingScope) conservative by bailing out on disposable objects that are passed as arguments to methods in metadata. Requires updating to a new FlowAnalysisUtilities version. Fixes #36498
…623.4 (#36701) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19323.4
…config-settings Change dotnet_diagnostic.*.severity settings to match code style
Make Dispose analyzers (IDE0067 and IDE0069) more conservative
Not sure why these are lowercase but makes the tests harder to read.
enabled the nullable feature, either on the command line or via a nullable enable directive.
razor added new @code block. add support for new code block in roslyn. for old razor version, IsCodeBlock won't get called since razor will not treat code in @code as C# code block, in new razor version where @code is added, razor will recognize it as C# code block and call us which we will in turn check new @code along with existing @ tags for code blocks.
This slipped through because we didn't have any tests at all for
the case where we are using the type-inferrer to infer the case like:
a = new A { B = { } }
where the inner one doesn't have a new B before it. The scenario wasn't
new but just happened to be the precise case that was broken.
Fixes #36702
Workaround for #32100 for Dev16.2
…mbols-to-lookupsymbols Unwrap nullability-wrapped symbols in object initializer completion
Conflicts: src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs
…3-preview1 Merge master to release/dev16.3-preview1
…isenseIsReady set "DeferUntilIntellisenseIsReady"=dword:00000000 for csharp and VB …
Fix GetHashCode on constructed types with annotated type arguments
…3-preview1 Merge master to release/dev16.3-preview1
…3-preview1 Merge master to release/dev16.3-preview1
…626.2 (#36779) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19326.2
make sure we only create OB when VS is running in IDE mode. all comma…
…m master to release\dev16.3-preview1 Not sure why the unit test failures were not caught by the merge PR, as these tests are failing consistently in CI for PRs targeting release\dev16.3-preview1
Add only LSP server projects without liveshare dependencies.
Bring in last compiler changes before snap
Fix couple of unit tests that started failing after #36566 merged fro…
…ev16.3-preview1-to-release/dev16.3-preview1-vs-deps
Member
|
@JoeRobich Thanks! |
Member
|
@agocke You should just make that legal syntax. ;) |
Member
|
@JoeRobich Actually it is, you removed the comma when the real problem was I missed a comma two lines up :) |
agocke
approved these changes
Jun 27, 2019
agocke
deleted the
merges/release/dev16.3-preview1-to-release/dev16.3-preview1-vs-deps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from release/dev16.3-preview1 into release/dev16.3-preview1-vs-deps.
git fetch --all git checkout merges/release/dev16.3-preview1-to-release/dev16.3-preview1-vs-deps git reset --hard upstream/release/dev16.3-preview1-vs-deps git merge upstream/release/dev16.3-preview1 # Fix merge conflicts git commit git push upstream merges/release/dev16.3-preview1-to-release/dev16.3-preview1-vs-deps --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.