Bring features/param-nullchecking up to date [Old] #46138
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-deps Merge master to master-vs-deps
…7-vs-deps LOC CHECKIN 20200709 | dotnet-roslyn release/dev16.7-vs-deps
…ix from deployment VSIX. (dotnet#45979) Fixes Roslyn preview installer.
Improve mention of IDE experience scenario so that it links to it. Acknowledge trailing JSON comma. Fix FileTransformGenerator example indent.
Classify ??= as an operator.
…osticAnalyzer Fixes dotnet#46047 dotnet#45765 enhance this analyzer to support detecting unnecessary inline SuppressMessageAttribute suppressions. This led to a regression when processing idToPragmasMap for unhandled IDs, which is fixed by this change.
…/target-typing Merge master to features/target-typing
…s-deps Merge master to master-vs-deps
…-master Merge release/dev16.7 to master
…rges/release/dev16.7-vs-deps-to-master-vs-deps
…walker (dotnet#45974) * Attempted Fix * PR Changes
Fix confusing use of GetService extensions with different behavior
…ase/dev16.7-vs-deps-to-master-vs-deps
Fix KeyNotFound exception in RemoveUnnecessaryInlineSuppressionsDiagn…
…/module-initializers Merge master to features/module-initializers
Implement compiler /warnversion flag and one "wave" warning
…-release/dev16.7-vs-deps Merge release/dev16.7 to release/dev16.7-vs-deps
Contributor
Author
Huh, it didn't seem to fix it. Are there any other scripts I should be running? |
Member
|
It did fix the correctness leg. |
Skip flaky test
…e-invisibleeditor Nullable annotate InvisibleEditor.cs
…eview1-to-master Merge release/dev16.8-preview1 to master
Update version of RichCodeNav.EnvVarDump
…sh-data-1 Update publish data for 16.8
* Update README Add links to NuGet feeds, reorder sections. * Feedback
Remove myget feeds from restore
Merge master in
Member
|
@kevinsun-dev CI is now green. You can merge (don't squash). |
jaredpar
force-pushed
the
features/param-nullchecking
branch
from
484f421 to
19c19ec
Compare
kevinsun-dev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
26 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of the absolute mess that has been made of this PR, I've decided to close it. Clean one at #46398.