Fire Window

[tomasstrba]

Task/Issue URL: https://app.asana.com/0/72649045549333/1203956617610891/f
Tech Design URL: https://app.asana.com/0/481882893211075/1204384679803788/f

Description:
Making Fire Window available to public

Steps to test this PR:

1. Make sure the UI of Fire Window follows the latest Figma design
2. Verify Fire Window does not use or add to website state used by regular windows.
3. Make sure Fire Window does not save website state beyond a single Fire Window session, which ends when closed.
4. Verify Fire Window doesn't add anything to user's browsing history.
5. Verify Fire Window does have access to existing autofill items but can't create new autofill items.

---

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

[tomasstrba]

@ayoy, there is a slight change in functionality based on feedback we collected in the ship review. If you'd like to verify it here is the list of things to test:

• Make sure each Fire Window has its own separate nonpersistant website data store
• Verify you can't open new Fire Windows using context menus in the existing Fire Window
• Make sure drag and drop to open a new tab doesn't work in Fire Window
• Make sure drag and drop doesn't work between Fire Windows and between one regular window and one Fire Window

[ayoy]

@tomasstrba all works great now, but I'm leaving an API naming comment for you to take into consideration. Thanks!

[ayoy]

I'm wondering about naming here – BurnerStatus can be pretty cryptic to people not familiar with the topic (especially with no documentation). The following example questions come to my mind:

• what's Burner?
• what is "status" really about?

How about calling the enum based on what it actually is, i.e. the type of Website Data Store? I think the following wouldn't even require docs as it's pretty obvious what's the purpose of it:

enum WebsiteDataStoreType: Equatable {
    case `default`
    case ephemeral(WKWebsiteDataStore)

    init(isEphemeral: Bool) {
        if isEphemeral {
            // Each Burner Window has it's own independent website data store that
            // stores website data in memory
            self = .ephemeral(.nonPersistent())
        } else {
            self = .default
        }
    }

    var isEphemeral: Bool {
        switch self {
        case .`default`: return false
        case .ephemeral: return true
        }
    }
}

[tomasstrba]

For future reference, Dominik and I discussed the naming on Zoom and agreed to go with BurnerMode.

The reason is, I prefer to keep data store logic encapsulated in Tab and keep the enum just for identification. Agree with Dominik that Status is slightly confusing as it doesn't change over time.