Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Conversation

@brindy
Copy link
Contributor

@brindy brindy commented Jul 18, 2023

Task/Issue URL: https://app.asana.com/0/392891325557410/1205078347359325
Tech Design URL:
CC:

Description:

Updates Sparkle to 2.4.2

Steps to test this PR:

  1. Launch the app and check for updates. Should be on a newer version than live.
  2. Set the app version to something older (e.g. 1.4.5). Launch and check for updates, should show latest public release. Reset the app version.
  3. Update InternalUserDeciderStore and hard code isInternalUser to true. Launch and check for updates. Should show latest internal version.

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@brindy brindy requested a review from tomasstrba July 18, 2023 10:28
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅ Works as expected!

@brindy brindy merged commit 7927b55 into develop Jul 26, 2023
@brindy brindy deleted the brindy/update-sparkle branch July 26, 2023 16:13
samsymons added a commit that referenced this pull request Jul 28, 2023
# By Dominik Kapusta (7) and others
# Via Sam Symons (2) and others
* develop:
  Modularize debug menu and login items logic #3 (#1397)
  Modularize debug menu and login items logic (#1378)
  Fixes of minor issues with Fire Button after the new logic release (#1395)
  Fire Window (#1357)
  Fix reordering favorites in the last row when it's not fully populated (#1401)
  Close the window when cmd+w is pressed on a pinned tab and there are no regular tabs (#1390)
  update sparkle to 2.4.2 (#1362)
  disable trailing_comma (#1394)
  Add support for per-model Sync Data Providers initialization (#1387)
  update favicon logic to fix gsuite icons (#1380)
  Update minor version by default in code_freeze lane (#1392)
  Upload dSYMs from release builds to S3 for Sentry (#1393)
  Set version to 1.48.2.
  Hide Cards UI on macOS Catalina (#1386)
  Hide Cards UI on macOS Catalina (#1386)
  update shield icon only after navigation ended and tab is selected (#1314)
  Add Debug menu option back in for resetting the Email Protection InContext prompt (#1373)
  Bump version to 1.49.0 (42)
  Update embedded files

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants