3 ➡️ 4 #866
Merged
3 ➡️ 4 #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
* Fix issue not configuring links added after start Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com> * Add a test checking the fix Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
* Change the diff_drive_system test to cover min_acceleration and min_velocity limits. Added those limits to the .sdf file. Signed-off-by: LolaSegura <lsegura@ekumenlabs.com> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Franco Cipollone <53065142+francocipollone@users.noreply.github.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
ahcorde
added
the
needs upstream release
ahcorde
requested changes
Jun 18, 2021
Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
7 tasks
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
chapulina
added a commit
that referenced
this pull request
Jun 22, 2021
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
force-pushed
the
chapulina/3_to_4
branch
from
6a960fc to
8357068
Compare
chapulina
force-pushed
the
chapulina/3_to_4
branch
from
8357068 to
f6a1a84
Compare
Codecov Report
@@ Coverage Diff @@
## ign-gazebo4 #866 +/- ##
===============================================
+ Coverage 65.68% 65.98% +0.29%
===============================================
Files 240 239 -1
Lines 17811 17657 -154
===============================================
- Hits 11700 11651 -49
+ Misses 6111 6006 -105
Continue to review full report at Codecov.
|
chapulina
removed
the
needs upstream release
|
Phew, all upstream releases are in, this is ready! Let's merge it before there are more breaking changes 😅 |
ahcorde
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-gazebo3toign-gazebo4Branch comparison: ign-gazebo4...ign-gazebo3
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸