Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9 ➡️ 10 #259

Merged
merged 9 commits into from
Sep 13, 2021
Merged

9 ➡️ 10 #259

merged 9 commits into from
Sep 13, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-transport9 to ign-transport10

Branch comparison: ign-transport10...ign-transport9

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 9 commits April 30, 2021 14:07
@chapulina
Remove deprecated test (#239)
d8a31da 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Remove tools/code_check and update codecov (#246)
5d88091 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@caguero
Consider all network interfaces when checking HOST option. (#245)
f083307 
* Consider all network interfaces when checking HOST option.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>

* Update localhost address.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero
Errno (#254)
5d0820a 
* Better error message.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Merge branch 'ign-transport8' into 8-to-9-aug2021
2451992
@nkoenig
Merge pull request #255 from ignitionrobotics/8-to-9-aug2021
11c22ea 
8 to 9 aug2021
9.1.1 prep
94ea79c 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig
Merge pull request #256 from ignitionrobotics/9-1-1-prep
2aafdc1 
9 1 1 prep
@chapulina
9 ➡️ 10
aea6cfa 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 10, 2021
@chapulina chapulina requested a review from caguero as a code owner September 10, 2021 17:10
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Sep 10, 2021
@chapulina chapulina mentioned this pull request Sep 10, 2021
Closed
@codecov
Copy link

codecov bot commented Sep 10, 2021 •
edited
Loading

Codecov Report

Merging #259 (6dd03b9) into ign-transport10 (222d4d6) will decrease coverage by 0.00%.
The diff coverage is 90.40%.

❗ Current head 6dd03b9 differs from pull request most recent head aea6cfa. Consider uploading reports for the commit aea6cfa to get more accurate results
Impacted file tree graph

@@                 Coverage Diff                 @@
##           ign-transport10     #259      +/-   ##
===================================================
- Coverage            89.07%   89.07%   -0.01%     
===================================================
  Files                   49       51       +2     
  Lines                 4678     4769      +91     
===================================================
+ Hits                  4167     4248      +81     
- Misses                 511      521      +10
Impacted Files Coverage Δ
include/ignition/transport/Publisher.hh 100.00% <ø> (ø)
src/Publisher.cc 100.00% <ø> (ø)
include/ignition/transport/Discovery.hh 87.06% <30.00%> (-0.68%) ⬇️
src/cmd/ign.cc 97.43% <87.50%> (ø)
src/cmd/service_main.cc 96.00% <96.00%> (ø)
src/cmd/topic_main.cc 96.49% <96.49%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7040522...aea6cfa. Read the comment docs.

@chapulina chapulina merged commit 9cd1e2d into ign-transport10 Sep 13, 2021
@chapulina chapulina deleted the chapulina/9_to_10 branch September 13, 2021 17:33
@chapulina chapulina mentioned this pull request Sep 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero approved these changes

Assignees
No one assigned
Labels
beta Targeting beta release of upcoming collection 🏢 edifice Ignition Edifice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chapulina @caguero @nkoenig