Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10 ➡️ 11 (main) #260

Merged
merged 11 commits into from
Sep 13, 2021
Merged

10 ➡️ 11 (main) #260

merged 11 commits into from
Sep 13, 2021

Conversation

chapulina
Copy link
Contributor

10 ➡️ main Forward port

Port ign-transport10 to main

Branch comparison: main...ign-transport10

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 11 commits April 30, 2021 14:07
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
* Consider all network interfaces when checking HOST option.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>

* Update localhost address.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
* Better error message.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 13, 2021
@chapulina chapulina requested a review from caguero as a code owner September 13, 2021 17:36
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 13, 2021
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #260 (af27746) into main (b6acc69) will decrease coverage by 0.04%.
The diff coverage is 30.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   89.13%   89.08%   -0.05%     
==========================================
  Files          51       51              
  Lines        4760     4766       +6     
==========================================
+ Hits         4243     4246       +3     
- Misses        517      520       +3     
Impacted Files Coverage Δ
include/ignition/transport/Discovery.hh 87.26% <30.00%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6acc69...af27746. Read the comment docs.

@caguero
Copy link
Collaborator

caguero commented Sep 13, 2021

Are the Homebrew warnings new?

@chapulina
Copy link
Contributor Author

Are the Homebrew warnings new?

I've seen them there for a while, they were also on #259. I think there's a new ZMQ version?

@caguero
Copy link
Collaborator

caguero commented Sep 13, 2021

It doesn't sound very critical but I'll try to take a look.

@chapulina chapulina merged commit e3a3ee7 into main Sep 13, 2021
@chapulina chapulina deleted the chapulina/10_to_11 branch September 13, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants