Add cache for common package queries #22491
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KN4CK3R
added
type/enhancement
|
Maybe we can wait #22294 |
GiteaBot
added
the
lgtm/need 2
|
I don't think this is related because this cache should only be valid within one request. If you cache these objects longer than that you may get problems with expired/updated values. |
Yes, it's the same. |
|
Oh, my mistake. I mixed up that PR with the global cache. |
|
I think this could be rewritten since #22294 merged. |
yardenshoham
added
the
outdated/backport/v1.19
yardenshoham
removed
the
outdated/backport/v1.19
pull-request-size
bot
added
the
size/M
techknowlogick
approved these changes
Sep 12, 2024
GiteaBot
added
lgtm/need 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a cache for common package queries in
GetPackageDescriptor. Code which needs to process a list of packages benefits from this change. This skips 350 queries in the package integration tests for example.