Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various Fomantic UI and htmx problems #33851

Merged
merged 4 commits into from
Mar 11, 2025
Merged

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Mar 11, 2025

Also fix #31328, fix #33854

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 11, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 11, 2025
@wxiaoguang wxiaoguang changed the title Fix varioius Fomantic UI problems Fix various Fomantic UI problems Mar 11, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 11, 2025
@silverwind
Copy link
Member

silverwind commented Mar 11, 2025

You are editing generated assets, so these changes will revert when make fomantic is being ran. How about commiting a few .patch files and apply them with git patch?

Fomantic build should ideally continue to work until we have completely removed (which I still strongly prefer instead of patching it again and again).

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Mar 11, 2025

You are editing generated assets, so these changes will revert when make fomantic is being ran. How about commiting a few .patch files and apply them with git patch?

No, they are not generated anymore. See previous PR. I have completely dropped "fomantic build". The code is ours now.

-> Drop fomantic build #33845

@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Mar 11, 2025
@wxiaoguang wxiaoguang changed the title Fix various Fomantic UI problems Fix various Fomantic UI and htmx problems Mar 11, 2025
wxiaoguang added a commit that referenced this pull request Mar 11, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 11, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 11, 2025
@lunny lunny merged commit 91610a9 into go-gitea:main Mar 11, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 11, 2025
@wxiaoguang wxiaoguang deleted the fix-fomantic branch March 11, 2025 23:01
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 12, 2025
* giteaofficial/main:
  Fix various Fomantic UI and htmx problems (go-gitea#33851)
  Add workflow_job webhook (go-gitea#33694)
  Fix file icon mapping (go-gitea#33855)
  Drop fomantic build (go-gitea#33845)
  Fix auto concurrency cancellation skips commit status updates (go-gitea#33764)
  Fix test code (go-gitea#33829)
  Remove "noscript" tag from html head (go-gitea#33846)
  Fix material icon & diff highlight (go-gitea#33844)
  Fix LFS URL (go-gitea#33840)
  Add material icons for file list (go-gitea#33837)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/internal size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
5 participants