Skip to content

Refactor commit message rendering and fix bugs (#34412) #34414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented May 9, 2025

Backport #34412 by wxiaoguang

Fix #34398, fix #33308

Remove all repo.ComposeCommentMetas from templates, only use repo to render commit message.

Fix go-gitea#34398, fix go-gitea#33308

Remove all `repo.ComposeCommentMetas` from templates,
only use `repo` to render commit message.
@GiteaBot GiteaBot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels May 9, 2025
@GiteaBot GiteaBot added this to the 1.24.0 milestone May 9, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 9, 2025
@GiteaBot GiteaBot requested review from delvh and lunny May 9, 2025 12:42
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 9, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 9, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) May 9, 2025 12:45
@wxiaoguang wxiaoguang merged commit b44175c into go-gitea:release/v1.24 May 9, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants