Draft: Fix: Go Gitlab Project Has Moved #448
Conversation
Fixes scripts for running go tests and git tests
feat: Automatically open fold under cursor, redraw screen with cursor at center
* fix: use body with /mr/draft_notes/publish endpoint * docs: notify about successfully building server
Fixed some bad warnings when the branch was out of date or ahead of the remote tracking branch. --------- Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
Fix: Show draft replies in the correct tree
Fix: Use correct name for emoji
fix: fixes wrong GET to gitlab when the URL includes namespacing. Fixes #413.
This required changing Go to 1.23, unless I'm mistaken, which will make this an unfortunate breaking change for downstream users.
harrisoncramer
force-pushed
the
develop
branch
2 times, most recently
from
3b57759 to
3b396a5
Compare
|
I was receiving 500 errors when trying to add comments to an MR, and changing to this branch fixed it. |
| local major, minor, _ = go_version:match("(%d+)%.(%d+)%.(%d+)") | ||
| if major and tonumber(major) >= 1 and tonumber(minor) >= 19 then | ||
| local major, minor, patch = go_version:match("(%d+)%.(%d+)%.(%d+)") | ||
| if major and tonumber(major) >= 1 and tonumber(minor) >= 23 and tonumber(patch) >= 4 then |
There was a problem hiding this comment.
My go version is go version go1.24.0 darwin/arm64
Which fails this logic check, because whilst 1 and 24 are ok 0 >= 4 fails, even though 1.24.0 is > 1.23.4
|
I've been testing |
|
Hi @harrisoncramer. I'd like to ask about your plans with this MR and with the plugin in general. I would appreciate if the |
|
@jakubbortlik The problem with updating to the latest Go version is that clients of the plugin would have to install later versions of Go, because that's used to compile the application locally. I'd rather not ship such a breaking change, or at least if we do, then make sure we do it carefully. Honestly, I'm rarely using Gitlab these days as my new employer doesn't use it, so if you're interested in taking on a PR that updates the Go version in a graceful way then go for it, but I'll probably only minimally contribute from here forward. |
|
I'll work on this migration shortly. We'll probably have to have a migration tool such that when someone upgrades, it prompts them to install the latest version of Go or something. Will think on it. |
This required changing Go to 1.23, unless I'm mistaken, which will make this an unfortunate breaking change for downstream users. To fix, users will have to update their local Go versions to 1.23.4, as the plugin requires this local version of Go in order to compile.
It's worth looking at shipping precompiled versions of the plugins moving forward to avoid this for end-users in the future.
Fixes #447.
Note: This is a #MAJOR breaking change, that will require users to update their versions of Go locally to latest (1.23.4)