Remove more workarounds for GHCs < 9.0 #4092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
reviewed
Feb 24, 2024
|
There is more cleanup that can be done w.r.t unsupported ghc versions (e.g. |
jhrcek
requested review from
santiweight,
fendor and
pepeiborra
as code owners
michaelpj
approved these changes
Feb 25, 2024
ghcide/test/exe/TestUtils.hs
Outdated
| @@ -306,8 +306,7 @@ defToLocation (InR (InR Null)) = [] | |||
|
|
|||
| -- | Ghc 9 doesn't include the $-sign in TH warnings like earlier versions did | |||
| thDollarIdx :: UInt | |||
| thDollarIdx | ghcVersion >= GHC90 = 1 | |||
| | otherwise = 0 | |||
| thDollarIdx = 1 | |||
jhrcek
force-pushed
the
jhrcek/remove-ghc-pre-0.9-workarounds
branch
from
a4650ab
to
03c2dcd
Compare
michaelpj
approved these changes
Feb 26, 2024
| @@ -9,23 +9,29 @@ main = defaultTestRunner $ testGroup "haskell-language-server-wrapper" [projectG | |||
|
|
|||
| projectGhcVersionTests :: TestTree | |||
| projectGhcVersionTests = testGroup "--project-ghc-version" | |||
| [ stackTest "9.2.8" | |||
| [ testCase "stack with global ghc" $ do | |||
| ghcVer <- ghcNumericVersion | |||
jhrcek
added a commit
to jhrcek/haskell-language-server
that referenced
this pull request
Feb 27, 2024
michaelpj
pushed a commit
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.