Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move ghcide-tests to haskell-language-server.cabal and make it depend on hls-test-utils #4176

Merged
merged 6 commits into from
Apr 17, 2024
Merged

move ghcide-tests to haskell-language-server.cabal and make it depend on hls-test-utils #4176

merged 6 commits into from
Apr 17, 2024

Conversation

soulomoon
Copy link
Collaborator

@soulomoon soulomoon commented Apr 14, 2024 •
edited
Loading

A part of the job that break the import cycle migrating the ghcide-tests to use hls-test-util #4173.

@soulomoon soulomoon linked an issue Apr 14, 2024 that may be closed by this pull request
Extracts ghcide-tests and migrate it to use hls-test-utils #4173
Closed
31 tasks
@soulomoon soulomoon mentioned this pull request Apr 14, 2024
Closed
31 tasks
@michaelpj
Copy link
Collaborator

Fine - do you want to do this by itself or also tweak a few tests?

@soulomoon
Copy link
Collaborator Author

soulomoon commented Apr 16, 2024 •
edited
Loading

I am going migrate the simple InitializeResponseTests.hs along in this PR.
And gradually migrate a test at a time in some other PRs, for more complex test migration, some modification to hls-tests-util would need to be shipped and discussed.

@soulomoon soulomoon marked this pull request as ready for review April 16, 2024 15:58
@soulomoon
Copy link
Collaborator Author

Done migrating the InitializeResponseTests.hs

@michaelpj michaelpj merged commit 9593d04 into master Apr 17, 2024
39 checks passed
@chenrui333 chenrui333 mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj approved these changes

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extracts ghcide-tests and migrate it to use hls-test-utils
2 participants
@soulomoon @michaelpj