-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another attempt at using the lsp API for some progress reporting #4218
Conversation
Okay, I think the tests should pass now. I had to get rid of some of the functional tests because they test the real HLS executable, so that now includes a delay on starting progress. So we can't observe it unless we can make things take long enough, and we can't make the delay shorter because we're using the real HLS (unlike the As far as I can tell, this seems to work reliably. I would also like to rewrite the other special progress reporter, not sure if I'll do that in this PR or not. |
Okay, many tests rely on waiting for progress notifications and are now somewhat broken. I shall continue on it. |
Ready for a look, perhaps @soulomoon ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
Just want to ask one thing, so we lose some of the notification tests since we now have 1 s delay for notification ? I wonder if we can set the shorter delay for testing and gain those test back?
Yes, so we have some special arguments for the |
So it is using
Maybe we can generalize the special arguments for the ghcide to the hls-exe ? |
Yeah, or maybe I can use an environment variable or something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as for Splice Plugin! 👍
34766bb
to
0e0a492
Compare
We already had a |
{ LSP.optCompletionTriggerCharacters = Just "." | ||
-- Generally people start to notice that something is taking a while at about 1s, so | ||
-- that's when we start reporting progress | ||
, LSP.optProgressStartDelay = 1_00_000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a weird number. Shouldn't this be 1_000_000
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦
No description provided.