eval: more robust way to extract comments from ParsedModule #4113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3500 and #3312
The problem in those issues can be illustrated by this simpler reproducer.
The issue is that in the present of multi-line function definition, the "end of line comment" we want to extract for eval plugin is associated with the 2nd match group of function definition (confirmed this by compiling with
-ddump-parsed-ast -dkeep-comments), which was part of AST that eval plugin was ignoring when extracting comments, thus it didn't create "Evaluate..." code lens.By using
biplatecombinator from lens we can more simply extract all occurrences of LEpaComment from the parsed source, wherever they might be.