Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete testUtil from ghcide-tests #4272

Merged
merged 3 commits into from
Jun 2, 2024
Merged

Delete testUtil from ghcide-tests #4272

merged 3 commits into from
Jun 2, 2024

Conversation

soulomoon
Copy link
Collaborator

@soulomoon soulomoon commented Jun 1, 2024 •
edited
Loading

After a serious of migration #4173
Only NonLspCommandLine use TestUtil, we can delete TestUtil now
And some more cleanup of unused function in ghcide-tests

@soulomoon soulomoon marked this pull request as ready for review June 1, 2024 17:04
@soulomoon soulomoon requested a review from wz1000 as a code owner June 1, 2024 17:04
fendor
fendor approved these changes Jun 2, 2024
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@soulomoon soulomoon merged commit 9f3e274 into master Jun 2, 2024
35 checks passed
@soulomoon soulomoon mentioned this pull request Jun 3, 2024
Closed
31 tasks
@BrewTestBot BrewTestBot mentioned this pull request Jun 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendor fendor fendor approved these changes

@wz1000 wz1000 Awaiting requested review from wz1000 wz1000 is a code owner

@jhrcek jhrcek Awaiting requested review from jhrcek

@michaelpj michaelpj Awaiting requested review from michaelpj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soulomoon @fendor