Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common stanza to completion data #4286

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

VeryMilkyJoe
Copy link
Collaborator

This allows fields and values to be completed correctly inside common stanzas
Fixes #4285.

fendor
fendor previously requested changes Jun 8, 2024
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for looking into this! There is no test for the completions in common sections, yet, could you perhaps add one?

@VeryMilkyJoe
Copy link
Collaborator Author

LGTM, thanks for looking into this! There is no test for the completions in common sections, yet, could you perhaps add one?

Will do, good catch!

This allows fields and values to be completed correctly inside common
stanzas
@michaelpj michaelpj enabled auto-merge (squash) June 9, 2024 09:48
@michaelpj michaelpj merged commit efe8913 into haskell:master Jun 9, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cabal file completion does not consider common stanzas
3 participants