Test3 #2

icfaust · 2024-12-11T20:08:47Z

Description

Add a comprehensive description of proposed changes

List associated issue number(s) if exist(s): #6 (for example)

Documentation PR (if needed): uxlfoundation#1340 (for example)

Benchmarks PR (if needed): IntelPython/scikit-learn_bench#155 (for example)

PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

I have reviewed my changes thoroughly before submitting this pull request.
I have commented my code, particularly in hard-to-understand areas.
I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
I have added a respective label(s) to PR if I have a permission for that.
I have resolved any merge conflicts that might occur with the base branch.

Testing

I have run it locally and tested the changes extensively.
All CI jobs are green or I have provided justification why they aren't.
I have extended testing suite if new functionality was introduced in this PR.

Performance

I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
I have provided justification why performance has changed or why changes are not expected.
I have provided justification why quality metrics have changed or why changes are not expected.
I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

* run legacy tests with pytest * add back pyargs to pytest call * more pyargs * try changing order of PYTHONPATH * try changing to relative imports instead of adding PYTHONPATH * missing delete * try executing non-mpi tests first to see if they also fail * try deleting __init__.py in test folder * try removing relative import * move patching test also to pytest, restore MPI on windows * fix unexecuted parametrization * remove unused import * better naming * add name of estimator being patched * account for platforms using non-standard process codes * correct fixture names * use yield instead of finalize * try removing pyargs to see what happens * add separate tests for global and module-specific * remove unused argument * remove global patching test * fixes for windows * try changing fixtures back to manual finalizers * add comment about the yield fixtures * Update .ci/scripts/test_global_patch.py Co-authored-by: Ian Faust <icfaust@gmail.com> --------- Co-authored-by: Ian Faust <icfaust@gmail.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…uxlfoundation#2102)

…nvention at class definition-level (uxlfoundation#2101) * Update test_common.py * formatting * re-orient to new ban * add hasattr * fixes for properties * Update test_common.py * Update _common.py * Update _common.py * fix IncrementalLinearRegression properties * fix mistake * formatting * copy over of change from uxlfoundation#2102 * Update logistic_regression.py * Update sklearnex/tests/test_common.py Co-authored-by: Samir Nasibli <samir.nasibli@intel.com> --------- Co-authored-by: Samir Nasibli <samir.nasibli@intel.com>

…fitted]``` conformance for gpu support (uxlfoundation#2109) * Update logistic_regression.py * Update logistic_regression.py

- Add 'Non-Scikit algorithms' part to the docs - Add info about IncrementalPCA - Add sphinx.napoleon extension to generate docs from docstrings. - Update docstrings for non-scikit algorithms

…g.yaml and CI check (uxlfoundation#2115) * Update .pre-commit-config.yaml * Update ci.yml * Update CONTRIBUTING.md * Update ci.yml * Update ci.yml * test failure in pipelines * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml

…L#2938 (uxlfoundation#2093) * Update ci.yml * Update activate_components.bat * Update ci.yml * Update ci.yml

* Delete .circleci/compare_runs.py * Delete .circleci/run_and_compare.sh * Update algorithms.rst

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…tion#2118) * [refactor] sort tests and fix typo in print statement * increase timeout of gradient_boosted_classification to 240

* increase memory threshold for tests to 25% * increase only for pandas * linter * fix comparison for values passed to parameter

* Conda recipe update * Remove compiler_c and icx-cl * Add numpy matrix for conda-recipe CI * Remove python req from build env for conda-recipe CI * Reorder and extend testing deps * Change numpy testing matrix * Remove daal4py/sklearn from test files * Update DPC compiler details for conda-build in INSTALL * Update CI matrix and add comments * Remove catboost; corrections for run_test.bat * Add git tag as package version * Add note about VS versions * Change variable in run_test.bat * Add recipe versioning comment * Reorder MPI test command * Remove extra dpcpp installation in CI

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* produce JSON logs from pytest runs * make json reports triggerable with cli argument * Update ci.yml * Update ci.yml * fix repeated argument on windows * avoid adding json-related arguments when not needed * generate json reports during CI runs * remove accidental spaces * fix incorrect file name checking * remove json report from non-nightly job --------- Co-authored-by: Ian Faust <icfaust@gmail.com>

* DOC: Array API suport * Example for DBSCAN array API

…one place (uxlfoundation#1936) * MAINT: do DPEP libs imports check in one place

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…hecking oneDAL support (uxlfoundation#2110) * Update test_common.py * formatting * change to fstrings * fix all but SVM algos * add SVM fixes * Update test_common.py * forgotten index switch after merge

…y inputs (uxlfoundation#2113) * FIX: update functional support fallback logic a little bit * host numpy copies of the inputs data will be used for the fallback cases, since stock scikit-learn doesn't support DPCTL usm_ndarray and DPNP ndarray * Added a clarifying comment * Enhanced patch message for data transfer

uxlfoundation#2121) * Update test_patching.py * formatting * path to sep * Update _launch_algorithms.py * Update _launch_algorithms.py * Update _launch_algorithms.py

…supported in fit_check_before_support_check (uxlfoundation#2124) * Update test_common.py * Update incremental_linear.py * Update incremental_covariance.py * Update k_means.py * Update linear.py * Update incremental_linear.py

…ations (uxlfoundation#1867) * TEST: moved checks for banned primitives into certain folder, out of pkgs * Generalized for further use of checker for banned primitives * some fixes * refactoring

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…ion#1751) * expand forest classes with hyperparams * fix build errors * add some version checks * black format * version check for hyperparameters backend * fixup * fixup * fixup * fixup * add version check for hyperparams * Add daal_require_version_wrapper * simplify obtaining hparams * fix version checks * Fix ONEDAL_VERSION in comment Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * Add version comment to endif Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com> * add block_size_multiplier hyperparam * fix argument name * add hyperparameter tests * review comments * fixup for registe_hyperparameters * simplify get_hyperparamters() definition * rename set_block_size * remove block size multiplier from testing * modify hyperparameters getattr/setattr for better debug output * instantiate hyperparams for entire task_list * rename df_infer_hp * instantiate hp only for classification * Retrieve hparams only for classification * change hyperparam values to %8 values * [workaround] use older artifacts to avoid pipeline error - revert before merge * Revert "[workaround] use older artifacts to avoid pipeline error - revert before merge" This reverts commit 294396c. * improve comment on hyperparameters __getattr__ * simplify hyperparameters retrieval * Revert adding of daal_require_version_wrapper * clean up imports * clean up unused type * fixup after renaming predict->infer * move get_hyperparameters API to sklearnex * move tests to sklearnex * fix test --------- Co-authored-by: Victoriya Fedotova <viktoria.nn@gmail.com>

…thm='brute'``` and fit with GPU (uxlfoundation#2056) * Update test_neighbors.py * Update neighbors.py * Update neighbors.py * Update neighbors.py * Update neighbors.py * Update neighbors.py * formatting * isort * Update onedal/neighbors/neighbors.py Co-authored-by: Samir Nasibli <samir.nasibli@intel.com> --------- Co-authored-by: Samir Nasibli <samir.nasibli@intel.com>

…dation#2127) * Provide additional explanation for checkboxes in PR template * Rephrasing

* Update dependency pandas to v2.2.3 * Pin compatible pandas version for py<3.11 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alexander Andreev <alexander.andreev@intel.com>

david-cortes-intel and others added 30 commits October 14, 2024 08:52

Update dependency MarkupSafe to v3 (uxlfoundation#2092)

c40884a

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update dependency sphinx_rtd_theme to v3 (uxlfoundation#2089)

adcd8cb

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[enhancement] ban runtime use of Python's property in sklearnex (…

dc20da8

…uxlfoundation#2102)

[fix] fix ```test_estimators[LogisticRegression()-check_estimators_un…

64d71cf

…fitted]``` conformance for gpu support (uxlfoundation#2109) * Update logistic_regression.py * Update logistic_regression.py

DOC: Add info about incremental algorithms and BS (uxlfoundation#2103)

89a37a8

- Add 'Non-Scikit algorithms' part to the docs - Add info about IncrementalPCA - Add sphinx.napoleon extension to generate docs from docstrings. - Update docstrings for non-scikit algorithms

switch to dict (uxlfoundation#2111)

2dd89cd

[enhancement] interface with compressed artifacts uxlfoundation/oneDA…

48cf043

…L#2938 (uxlfoundation#2093) * Update ci.yml * Update activate_components.bat * Update ci.yml * Update ci.yml

[enhancement] Remove unrun .circleci code (uxlfoundation#2117)

e07b6ca

* Delete .circleci/compare_runs.py * Delete .circleci/run_and_compare.sh * Update algorithms.rst

Update dependency setuptools to v75.2.0 (uxlfoundation#2116)

72679a8

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

TEST: increase timeout for gradient_boosted_classification (uxlfounda…

d9d000f

…tion#2118) * [refactor] sort tests and fix typo in print statement * increase timeout of gradient_boosted_classification to 240

TEST: increase threshold for memory usage on tests (uxlfoundation#2108)

b077b6c

* increase memory threshold for tests to 25% * increase only for pandas * linter * fix comparison for values passed to parameter

Update dependency array-api-strict to v2.1 (uxlfoundation#2119)

903fb2f

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

DOC: Array API support (uxlfoundation#1918)

cde94da

* DOC: Array API suport * Example for DBSCAN array API

MAINT: utility module for Intel data parallel libs; import checks in …

4cfca60

…one place (uxlfoundation#1936) * MAINT: do DPEP libs imports check in one place

Update dependency cmake to v3.30.5 (uxlfoundation#2073)

2ec180c

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[enhancement] enforce use of sklearn's check_is_fitted before c…

0809a3e

…hecking oneDAL support (uxlfoundation#2110) * Update test_common.py * formatting * change to fstrings * fix all but SVM algos * add SVM fixes * Update test_common.py * forgotten index switch after merge

[testing] Remove linux hardcoding from daal4py's _launch_algorithms.py (

2029a74

uxlfoundation#2121) * Update test_patching.py * formatting * path to sep * Update _launch_algorithms.py * Update _launch_algorithms.py * Update _launch_algorithms.py

MAINT: using common test primitive for banned primitives check in loc…

3936cb9

…ations (uxlfoundation#1867) * TEST: moved checks for banned primitives into certain folder, out of pkgs * Generalized for further use of checker for banned primitives * some fixes * refactoring

Update dependency xgboost to v2.1.2 (uxlfoundation#2129)

0f0348a

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Provide additional explanation for checkboxes in PR template (uxlfoun…

0aaff10

…dation#2127) * Provide additional explanation for checkboxes in PR template * Rephrasing

icfaust added 28 commits December 11, 2024 14:02

Update test.yml

b8c430b

Update codecov.yml

98b9cbf

Update test.yml

007a144

Update test.yml

3bf647a

Update test.yml

5f98478

Update test.yml

12d836b

Merge branch 'uxlfoundation:main' into master

15d0b00

Update ci.yml

ba67917

Update test.yml

58cfbd8

Update test.yml

99cb4d4

Update test.yml

7607c63

Update test.yml

47e4ed3

Update ci.yml

3b66f63

Update codecov.yml

a0f6df2

Update codecov.yml

f288952

Update codecov.yml

b057bf1

Update test.yml

791075a

Update test.yml

441f5cd

Update codecov.yml

ebf04c8

Update ci.yml

b80b2ba

Update test.yml

16a6efd

Update ci.yml

9dbf451

Update ci.yml

dc474d6

Update ci.yml

77b609d

Update codecov.yml

d244f32

Update test.yml

3dc9cf5

Update codecov.yml

28f1664

Update __init__.py

4f23e7c

icfaust closed this Dec 11, 2024

icfaust deleted the test3 branch December 11, 2024 20:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test3 #2

Test3 #2

icfaust commented Dec 11, 2024

Test3 #2

Test3 #2

Conversation

icfaust commented Dec 11, 2024

Description