Skip to content

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented Dec 6, 2024

Summary of Changes

This is a followup for #42530 which uses the existing functions of the MVC API and removes some duplicated code. Like that are all ACL checks done, the default events triggered and code looks more inline with the rest of the core.

Testing Instructions

  • Run a task
  • Open the new task history view
  • Delete a log entry
  • Clear the whole history

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.3-dev labels Dec 6, 2024
@laoneo laoneo changed the title Move to log model [5.3] Move code to log model in new scheduler history view Dec 6, 2024
@alikon
Copy link
Contributor

alikon commented Dec 7, 2024

just applied the pr and runned a default task

image

@laoneo
Copy link
Member Author

laoneo commented Dec 7, 2024

Please check the response of the ajax request in the browser console. What for an error did you get?

@alikon
Copy link
Contributor

alikon commented Dec 7, 2024

Call to undefined method Joomla\CMS\Document\JsonDocument::getToolbar()

@laoneo
Copy link
Member Author

laoneo commented Dec 7, 2024

Set your server into debug mode and post the whole stack trace please.

@alikon
Copy link
Contributor

alikon commented Dec 7, 2024

my fault there was an obsolete plugin listening onBeforeRender

@alikon
Copy link
Contributor

alikon commented Dec 7, 2024

I have tested this item ✅ successfully on 7bbfc2a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44587.

@HLeithner HLeithner added b/c break This item changes the behavior in an incompatible why. HEADS UP and removed b/c break This item changes the behavior in an incompatible why. HEADS UP labels Dec 16, 2024
@exlemor
Copy link

exlemor commented Dec 16, 2024

I have tested this item ✅ successfully on f9bfbdf

I have successfully tested this as instructed. Worked beautifully.

Thanks laoneo.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44587.

@laoneo
Copy link
Member Author

laoneo commented Dec 16, 2024

As I added only types, removed an obsolete string and alpha ordered the new strings, I mark this as RTC because it needs to go into an alpha.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44587.

@laoneo
Copy link
Member Author

laoneo commented Dec 16, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44587.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 16, 2024
@rdeutz rdeutz merged commit e038933 into joomla:5.3-dev Jan 7, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 7, 2025
@rdeutz
Copy link
Contributor

rdeutz commented Jan 7, 2025

Thanks.

richard67 added a commit to richard67/joomla-cms that referenced this pull request Jan 10, 2025
bembelimen pushed a commit that referenced this pull request Jan 10, 2025
@LadySolveig LadySolveig added this to the Joomla! 5.3.0 milestone Jan 18, 2025
Kostelano added a commit to JPathRu/localisation that referenced this pull request Apr 14, 2025
joomla/joomla-cms#41496 - (upmerge с 5.2х)
joomla/joomla-cms#42530 +
joomla/joomla-cms#43994 - (upmerge с 5.2х)
joomla/joomla-cms#44009 - (upmerge с 5.2х)
joomla/joomla-cms#44010 - (upmerge с 5.2х)
joomla/joomla-cms#44161 +
joomla/joomla-cms#44187 - (upmerge с 5.2х)
joomla/joomla-cms#44207 - (upmerge с 5.2х)
joomla/joomla-cms#44271 +
joomla/joomla-cms#44273 +
joomla/joomla-cms#44288 - (только для en-GB)
joomla/joomla-cms#44348 - (upmerge с 5.2х)
joomla/joomla-cms#44366 +
joomla/joomla-cms#44367 - (upmerge с 5.2х)
joomla/joomla-cms#44434 - (upmerge с 5.2х)
joomla/joomla-cms#44448 - (upmerge с 5.2х)
joomla/joomla-cms#44462 +
joomla/joomla-cms#44487 - (upmerge с 5.2х)
joomla/joomla-cms#44587 +
joomla/joomla-cms#44600 +
joomla/joomla-cms#44604 +
joomla/joomla-cms#44621 - (upmerge с 5.2х)
joomla/joomla-cms#44623 +
joomla/joomla-cms#44632 +
joomla/joomla-cms#44640 - (позже был REVERT joomla/joomla-cms#44845)
joomla/joomla-cms#44714 - (upmerge с 5.2х)
joomla/joomla-cms#44756 +
joomla/joomla-cms#44768 - (upmerge с 5.2х)
joomla/joomla-cms#44792 - (только для en-GB)
joomla/joomla-cms#44813 +
joomla/joomla-cms#44822 - (upmerge с 5.2х)
joomla/joomla-cms#44839 +
joomla/joomla-cms#44871 +
joomla/joomla-cms#44954 +
joomla/joomla-cms#45034 - (upmerge с 5.2х)
joomla/joomla-cms#45058 - (только для en-GB)
joomla/joomla-cms#45064 +
joomla/joomla-cms#45078 - (только для en-GB)
joomla/joomla-cms#45130 - (upmerge с 5.2х)
joomla/joomla-cms#45240 - (upmerge с 5.2х)
joomla/joomla-cms#45246 - (только для др. пакетов)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators PR-5.3-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants