Skip to content

Conversation

@brianteeman
Copy link
Contributor

Pull Request for Issue #41187 .

Summary of Changes

This PR removes the ability when using batch functions to set/change the linked user. As this loads all users on the site into a giant list it impacts performance of all functionality in the contact component list view. With enough users it can even prevent the page from loading.

I can't see a valid use case for even having the functionality to link multiple contacts to the same user.

The field to select the users is therefore removed from the batch modal and the related files and strings are therefore marked as deprecated without replacement

Testing Instructions

Open the batch modal for the contact manager

Actual result BEFORE applying this Pull Request

Option to mass set linked user

Expected result AFTER applying this Pull Request

Option no longer present

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Signed-off-by: BrianTeeman <brian@teeman.net>
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.3-dev labels Dec 10, 2024
@ghost
Copy link

ghost commented Dec 10, 2024

I have tested this item ✅ successfully on f5db2d4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44600.

@obuisard
Copy link
Contributor

I have tested this item ✅ successfully on f5db2d4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44600.

1 similar comment
@AndySDH
Copy link
Contributor

AndySDH commented Dec 10, 2024

I have tested this item ✅ successfully on f5db2d4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44600.

@joomla-cms-bot joomla-cms-bot removed Language Change This is for Translators PR-5.3-dev labels Dec 10, 2024
@alikon
Copy link
Contributor

alikon commented Dec 10, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44600.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 10, 2024
@richard67 richard67 added Language Change This is for Translators PR-5.3-dev labels Dec 11, 2024
@laoneo
Copy link
Member

laoneo commented Dec 12, 2024

I know this is more a user backwards compatibility break and doesn't fall into our bc policy. If necessary I would like to remove stuff only in a major version, except when it is urgent, which is here not the case. An admin can do a layout override now till 6.0 is released.

@brianteeman
Copy link
Contributor Author

I disagree. This is a bug fix. Telling someone to create an override to fix a bug is not the correct thing to do. As per the original bug report this useless function prevents the correct operation of anything in the com_contact list view as the query is run on page load and not just when the modal opens

@rdeutz rdeutz merged commit 67fa7f8 into joomla:5.3-dev Jan 7, 2025
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 7, 2025
@rdeutz
Copy link
Contributor

rdeutz commented Jan 7, 2025

Thanks

@brianteeman brianteeman deleted the batch_user branch January 7, 2025 09:23
@rdeutz rdeutz added this to the Joomla! 5.3.0 milestone Jan 7, 2025
heelc29 added a commit to heelc29/joomla that referenced this pull request Feb 2, 2025
heelc29 added a commit to heelc29/joomla that referenced this pull request Feb 2, 2025
Kostelano added a commit to JPathRu/localisation that referenced this pull request Apr 14, 2025
joomla/joomla-cms#41496 - (upmerge с 5.2х)
joomla/joomla-cms#42530 +
joomla/joomla-cms#43994 - (upmerge с 5.2х)
joomla/joomla-cms#44009 - (upmerge с 5.2х)
joomla/joomla-cms#44010 - (upmerge с 5.2х)
joomla/joomla-cms#44161 +
joomla/joomla-cms#44187 - (upmerge с 5.2х)
joomla/joomla-cms#44207 - (upmerge с 5.2х)
joomla/joomla-cms#44271 +
joomla/joomla-cms#44273 +
joomla/joomla-cms#44288 - (только для en-GB)
joomla/joomla-cms#44348 - (upmerge с 5.2х)
joomla/joomla-cms#44366 +
joomla/joomla-cms#44367 - (upmerge с 5.2х)
joomla/joomla-cms#44434 - (upmerge с 5.2х)
joomla/joomla-cms#44448 - (upmerge с 5.2х)
joomla/joomla-cms#44462 +
joomla/joomla-cms#44487 - (upmerge с 5.2х)
joomla/joomla-cms#44587 +
joomla/joomla-cms#44600 +
joomla/joomla-cms#44604 +
joomla/joomla-cms#44621 - (upmerge с 5.2х)
joomla/joomla-cms#44623 +
joomla/joomla-cms#44632 +
joomla/joomla-cms#44640 - (позже был REVERT joomla/joomla-cms#44845)
joomla/joomla-cms#44714 - (upmerge с 5.2х)
joomla/joomla-cms#44756 +
joomla/joomla-cms#44768 - (upmerge с 5.2х)
joomla/joomla-cms#44792 - (только для en-GB)
joomla/joomla-cms#44813 +
joomla/joomla-cms#44822 - (upmerge с 5.2х)
joomla/joomla-cms#44839 +
joomla/joomla-cms#44871 +
joomla/joomla-cms#44954 +
joomla/joomla-cms#45034 - (upmerge с 5.2х)
joomla/joomla-cms#45058 - (только для en-GB)
joomla/joomla-cms#45064 +
joomla/joomla-cms#45078 - (только для en-GB)
joomla/joomla-cms#45130 - (upmerge с 5.2х)
joomla/joomla-cms#45240 - (upmerge с 5.2х)
joomla/joomla-cms#45246 - (только для др. пакетов)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators PR-5.3-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants