Skip to content

Conversation

@LadySolveig
Copy link
Contributor

Pull Request followup of #39371 .

All the credits go @JackKellyUK and @dgrammatiko.

Summary of Changes

Update awesomplete package to new version and pass new language for title /aria-label attribute string to initalization.

Testing Instructions

  • Setup Smart Search > Search menu item (Smart Search > Search Suggestions global setting must be enabled)
  • Run axe browser plugin / find awesomplete list ul and check for title / aria-label attribute

Actual result BEFORE applying this Pull Request

No title / aria-label attribute present on Awesomplete list

Expected result AFTER applying this Pull Request

Title attribute present on Awesomplete list

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@LadySolveig LadySolveig requested a review from chmst as a code owner January 19, 2025 15:24
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev labels Jan 19, 2025
@richard67 richard67 added the a11y Accessibility label Jan 19, 2025
@QuyTon
Copy link
Contributor

QuyTon commented Jan 20, 2025

I have tested this item ✅ successfully on ec89bb3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44756.

@QuyTon
Copy link
Contributor

QuyTon commented Jan 22, 2025

Use Web Developer Tools to inspect the Search Terms field element on the frontend. See aria-label attribute.

Before PR:
44756-reults-list

After PR:
44756-search-results

@ghost
Copy link

ghost commented Jan 22, 2025

I have tested this item ✅ successfully on 9a59b04


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44756.

@QuyTon
Copy link
Contributor

QuyTon commented Jan 22, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44756.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 22, 2025
@richard67 richard67 merged commit efffa86 into joomla:5.3-dev Feb 8, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 8, 2025
@richard67
Copy link
Member

Thanks all who contributed and tested.

@richard67 richard67 added this to the Joomla! 5.3.0 milestone Feb 8, 2025
@LadySolveig LadySolveig deleted the 5.3/awesomeplete-update-fix-accessibility branch February 9, 2025 08:01
Kostelano added a commit to JPathRu/localisation that referenced this pull request Apr 14, 2025
joomla/joomla-cms#41496 - (upmerge с 5.2х)
joomla/joomla-cms#42530 +
joomla/joomla-cms#43994 - (upmerge с 5.2х)
joomla/joomla-cms#44009 - (upmerge с 5.2х)
joomla/joomla-cms#44010 - (upmerge с 5.2х)
joomla/joomla-cms#44161 +
joomla/joomla-cms#44187 - (upmerge с 5.2х)
joomla/joomla-cms#44207 - (upmerge с 5.2х)
joomla/joomla-cms#44271 +
joomla/joomla-cms#44273 +
joomla/joomla-cms#44288 - (только для en-GB)
joomla/joomla-cms#44348 - (upmerge с 5.2х)
joomla/joomla-cms#44366 +
joomla/joomla-cms#44367 - (upmerge с 5.2х)
joomla/joomla-cms#44434 - (upmerge с 5.2х)
joomla/joomla-cms#44448 - (upmerge с 5.2х)
joomla/joomla-cms#44462 +
joomla/joomla-cms#44487 - (upmerge с 5.2х)
joomla/joomla-cms#44587 +
joomla/joomla-cms#44600 +
joomla/joomla-cms#44604 +
joomla/joomla-cms#44621 - (upmerge с 5.2х)
joomla/joomla-cms#44623 +
joomla/joomla-cms#44632 +
joomla/joomla-cms#44640 - (позже был REVERT joomla/joomla-cms#44845)
joomla/joomla-cms#44714 - (upmerge с 5.2х)
joomla/joomla-cms#44756 +
joomla/joomla-cms#44768 - (upmerge с 5.2х)
joomla/joomla-cms#44792 - (только для en-GB)
joomla/joomla-cms#44813 +
joomla/joomla-cms#44822 - (upmerge с 5.2х)
joomla/joomla-cms#44839 +
joomla/joomla-cms#44871 +
joomla/joomla-cms#44954 +
joomla/joomla-cms#45034 - (upmerge с 5.2х)
joomla/joomla-cms#45058 - (только для en-GB)
joomla/joomla-cms#45064 +
joomla/joomla-cms#45078 - (только для en-GB)
joomla/joomla-cms#45130 - (upmerge с 5.2х)
joomla/joomla-cms#45240 - (upmerge с 5.2х)
joomla/joomla-cms#45246 - (только для др. пакетов)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Accessibility Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants