Skip to content

Conversation

@sdwjoomla
Copy link
Contributor

@sdwjoomla sdwjoomla commented Feb 12, 2025

Summary of Changes

This PR will:

  • add a tour that highlights new features introduced in Joomla 5.3
  • removes the autostart tour of the prior release

Testing Instructions

Download the update package, not the full install as the tour is only available on updates!

It is possible to find the tour in the list of tours at the top of the Joomla dashboard and run it manually.
Make sure you see images when running the tour (on the first step only) and when editing the tour (System -> Manage -> Guided tours).

Actual result BEFORE applying this Pull Request

No tour highlighting new features for Joomla 5.3.

Expected result AFTER applying this Pull Request

The What’s New in Joomla 5.3! tour is available.

whatnew53

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev labels Feb 12, 2025
@brianteeman
Copy link
Contributor

Template Override Plugin Comparison - adds the ability to compare custom plugins to original code

What is this new feature?

@sdwjoomla
Copy link
Contributor Author

Template Override Plugin Comparison - adds the ability to compare custom plugins to original code

What is this new feature?

Did I misunderstand #44588?

@heelc29
Copy link
Contributor

heelc29 commented Feb 13, 2025

#44161 have been reverted

@brianteeman
Copy link
Contributor

Template Override Plugin Comparison - adds the ability to compare custom plugins to original code

What is this new feature?

Did I misunderstand #44588?

Yes - A better description would be simply

Template Overrides - Adds compare functionality to plugin overrides

However it is a very minor bug fix, not sure it is significant enough to even be mentioned

@sdwjoomla
Copy link
Contributor Author

#44161 have been reverted

Ok, we will update the tour

@sdwjoomla
Copy link
Contributor Author

Template Override Plugin Comparison - adds the ability to compare custom plugins to original code

What is this new feature?

Did I misunderstand #44588?

Yes - A better description would be simply

Template Overrides - Adds compare functionality to plugin overrides

However it is a very minor bug fix, not sure it is significant enough to even be mentioned

Thanks will discuss with the team

Removed reverted PR44161
Updated description of PR44588
Updated to reflect the changes to the tour
@brianteeman
Copy link
Contributor

Does the image need to be so big? W: 2396px | H: 1540px

@sdwjoomla sdwjoomla marked this pull request as ready for review February 20, 2025 22:09
@ghost
Copy link

ghost commented Feb 21, 2025

I have tested this item ✅ successfully on 2567e2d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871.

@VaishnaviSidral
Copy link

I have tested this item 🔴 unsuccessfully on 2567e2d

I have tested and not working as expected


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871.

@ghost
Copy link

ghost commented Feb 22, 2025

I have tested and not working as expected

@VaishnaviSidral Please describe what you expect und what is not working so developer know what you mean.

@inforaghavms
Copy link

I have tested this item ✅ successfully on 2567e2d

Its tested and working fine as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871.

@inforaghavms
Copy link

I have tested this item ✅ successfully on 2567e2d

Test is working fine as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871.

obuisard and others added 5 commits March 4, 2025 09:24
@rdeutz
Copy link
Contributor

rdeutz commented Mar 9, 2025

@sdwjoomla could you make the requested changes as soon as possible, we need to merge this here before 18 March (beta3). Thanks.

@richard67
Copy link
Member

Requested changes have been made, RTC still valid.

@bembelimen bembelimen merged commit 8cad920 into joomla:5.3-dev Mar 14, 2025
0 of 2 checks passed
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 14, 2025
@bembelimen bembelimen added this to the Joomla! 5.3.0 milestone Mar 14, 2025
Kostelano added a commit to JPathRu/localisation that referenced this pull request Apr 14, 2025
joomla/joomla-cms#41496 - (upmerge с 5.2х)
joomla/joomla-cms#42530 +
joomla/joomla-cms#43994 - (upmerge с 5.2х)
joomla/joomla-cms#44009 - (upmerge с 5.2х)
joomla/joomla-cms#44010 - (upmerge с 5.2х)
joomla/joomla-cms#44161 +
joomla/joomla-cms#44187 - (upmerge с 5.2х)
joomla/joomla-cms#44207 - (upmerge с 5.2х)
joomla/joomla-cms#44271 +
joomla/joomla-cms#44273 +
joomla/joomla-cms#44288 - (только для en-GB)
joomla/joomla-cms#44348 - (upmerge с 5.2х)
joomla/joomla-cms#44366 +
joomla/joomla-cms#44367 - (upmerge с 5.2х)
joomla/joomla-cms#44434 - (upmerge с 5.2х)
joomla/joomla-cms#44448 - (upmerge с 5.2х)
joomla/joomla-cms#44462 +
joomla/joomla-cms#44487 - (upmerge с 5.2х)
joomla/joomla-cms#44587 +
joomla/joomla-cms#44600 +
joomla/joomla-cms#44604 +
joomla/joomla-cms#44621 - (upmerge с 5.2х)
joomla/joomla-cms#44623 +
joomla/joomla-cms#44632 +
joomla/joomla-cms#44640 - (позже был REVERT joomla/joomla-cms#44845)
joomla/joomla-cms#44714 - (upmerge с 5.2х)
joomla/joomla-cms#44756 +
joomla/joomla-cms#44768 - (upmerge с 5.2х)
joomla/joomla-cms#44792 - (только для en-GB)
joomla/joomla-cms#44813 +
joomla/joomla-cms#44822 - (upmerge с 5.2х)
joomla/joomla-cms#44839 +
joomla/joomla-cms#44871 +
joomla/joomla-cms#44954 +
joomla/joomla-cms#45034 - (upmerge с 5.2х)
joomla/joomla-cms#45058 - (только для en-GB)
joomla/joomla-cms#45064 +
joomla/joomla-cms#45078 - (только для en-GB)
joomla/joomla-cms#45130 - (upmerge с 5.2х)
joomla/joomla-cms#45240 - (upmerge с 5.2х)
joomla/joomla-cms#45246 - (только для др. пакетов)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Guided Tours Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.