-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[5.3] Guided Tours: What's New #44871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
initial version
initial version
updated file image
What is this new feature? |
Did I misunderstand #44588? |
|
#44161 have been reverted |
Yes - A better description would be simply
However it is a very minor bug fix, not sure it is significant enough to even be mentioned |
Ok, we will update the tour |
Thanks will discuss with the team |
Removed reverted PR44161 Updated description of PR44588
Updated to reflect the changes to the tour
|
Does the image need to be so big? W: 2396px | H: 1540px |
|
I have tested this item ✅ successfully on 2567e2d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871. |
|
I have tested this item 🔴 unsuccessfully on 2567e2d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871. |
@VaishnaviSidral Please describe what you expect und what is not working so developer know what you mean. |
|
I have tested this item ✅ successfully on 2567e2d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871. |
|
I have tested this item ✅ successfully on 2567e2d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44871. |
removed empty paragraph tag
administrator/language/en-GB/guidedtours.joomla_whatsnew_5_3.ini
Outdated
Show resolved
Hide resolved
administrator/language/en-GB/guidedtours.joomla_whatsnew_5_3.ini
Outdated
Show resolved
Hide resolved
administrator/language/en-GB/guidedtours.joomla_whatsnew_5_3.ini
Outdated
Show resolved
Hide resolved
administrator/language/en-GB/guidedtours.joomla_whatsnew_5_3_steps.ini
Outdated
Show resolved
Hide resolved
administrator/language/en-GB/guidedtours.joomla_whatsnew_5_3_steps.ini
Outdated
Show resolved
Hide resolved
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
…teps.ini Co-authored-by: Brian Teeman <brian@teeman.net>
…teps.ini Co-authored-by: Brian Teeman <brian@teeman.net>
|
@sdwjoomla could you make the requested changes as soon as possible, we need to merge this here before 18 March (beta3). Thanks. |
|
Requested changes have been made, RTC still valid. |
|
Thx |
joomla/joomla-cms#41496 - (upmerge с 5.2х) joomla/joomla-cms#42530 + joomla/joomla-cms#43994 - (upmerge с 5.2х) joomla/joomla-cms#44009 - (upmerge с 5.2х) joomla/joomla-cms#44010 - (upmerge с 5.2х) joomla/joomla-cms#44161 + joomla/joomla-cms#44187 - (upmerge с 5.2х) joomla/joomla-cms#44207 - (upmerge с 5.2х) joomla/joomla-cms#44271 + joomla/joomla-cms#44273 + joomla/joomla-cms#44288 - (только для en-GB) joomla/joomla-cms#44348 - (upmerge с 5.2х) joomla/joomla-cms#44366 + joomla/joomla-cms#44367 - (upmerge с 5.2х) joomla/joomla-cms#44434 - (upmerge с 5.2х) joomla/joomla-cms#44448 - (upmerge с 5.2х) joomla/joomla-cms#44462 + joomla/joomla-cms#44487 - (upmerge с 5.2х) joomla/joomla-cms#44587 + joomla/joomla-cms#44600 + joomla/joomla-cms#44604 + joomla/joomla-cms#44621 - (upmerge с 5.2х) joomla/joomla-cms#44623 + joomla/joomla-cms#44632 + joomla/joomla-cms#44640 - (позже был REVERT joomla/joomla-cms#44845) joomla/joomla-cms#44714 - (upmerge с 5.2х) joomla/joomla-cms#44756 + joomla/joomla-cms#44768 - (upmerge с 5.2х) joomla/joomla-cms#44792 - (только для en-GB) joomla/joomla-cms#44813 + joomla/joomla-cms#44822 - (upmerge с 5.2х) joomla/joomla-cms#44839 + joomla/joomla-cms#44871 + joomla/joomla-cms#44954 + joomla/joomla-cms#45034 - (upmerge с 5.2х) joomla/joomla-cms#45058 - (только для en-GB) joomla/joomla-cms#45064 + joomla/joomla-cms#45078 - (только для en-GB) joomla/joomla-cms#45130 - (upmerge с 5.2х) joomla/joomla-cms#45240 - (upmerge с 5.2х) joomla/joomla-cms#45246 - (только для др. пакетов)
Summary of Changes
This PR will:
Testing Instructions
Download the update package, not the full install as the tour is only available on updates!
It is possible to find the tour in the list of tours at the top of the Joomla dashboard and run it manually.
Make sure you see images when running the tour (on the first step only) and when editing the tour (System -> Manage -> Guided tours).
Actual result BEFORE applying this Pull Request
No tour highlighting new features for Joomla 5.3.
Expected result AFTER applying this Pull Request
The What’s New in Joomla 5.3! tour is available.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed