[5.3] display email address in contact

[brianteeman]

When mail templates are set to HTML it is not possible to SEE the senders email address as it sees the wrapping < > as html markup

This PR simply removes the < > from the string so that the email address is displayed.

The alternative would be to create a more complicated option that uses a different language string for the HTML version of the mail template

Pull Request for Issue #44791 .

Testing Instructions

Set the mail templates to use html and then send a test mail using a contact form

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[coolcat-creations]

I have tested this item ✅ successfully on 592eaf9

Thank you @brianteeman for this quick fix. I tested it and now it works as expected.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44792.}

[drmenzelit]

I have tested this item ✅ successfully on 592eaf9

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44792.}

[richard67]

System tests are failing for both MySQL and PostgreSQL, and it seems related:

  Running:  api/com_contact/Contacts.cy.js                                               (93 of 129)

  Test that contacts API endpoint
    ✓ can deliver a list of contacts (887ms)
    ✓ can deliver a single contact (754ms)
    ✓ can create a contact (503ms)
    ✓ can update a contact (1177ms)
    ✓ can delete a contact (379ms)

    1) can submit a contact form

  5 passing (9s)
  1 failing

  1) Test that contacts API endpoint
       can submit a contact form:
     AssertionError: Timed out retrying after 4000ms: expected 'This is an enquiry email via http://localhost/cmysql/api/ from:\njane doe admin@example.com\n\nautomated test message\n' to contain 'jane doe <admin@example.com>'
      at  (webpack://joomla/./tests/System/integration/api/com_contact/Contacts.cy.js:65:29)

It seems the system tests need some adjustment, too.

[richard67]

Back to pending as system tests need to be adjusted to the changes in this PR.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44792.}

[richard67]

@LadySolveig Could you help here with adjusting the system tests (see my previous comment)? Not needed anymore, Brian has done that.

[alikon]

i'm unable to replicate the issue ##44791 without the pr

[brianteeman]

System tests updated

[richard67]

RTC as previous human tests are still valid, only system tests were adjusted meanwhile.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44792.}

[Hackwar]

First of all thank you for working on this. Unfortunately I'm a bit unhappy with the approach you took, because with your approach we are relying on the transformation of the non-HTML text into HTML. At the same time we do have the possibility to create entirely different templates for HTML mails than for text mails.

What I'm trying to say here is, that I'd rather would want to see us introducing a new translation string and insert that into the htmlbody column of the template instead of modifying the existing templates. Could you please change this PR in that manner? Thank you! 😄

[brianteeman]

with your approach we are relying on the transformation of the non-HTML text into HTML.

what transformation?

[Hackwar]

If the HTML body is empty, it tries to convert the plain text content into an HTML content. See line 328 of /libraries/src/Mail/MailTemplate.php

[brianteeman]

yes but there is nothing special happening. the email address is just plain text now and its all it would be in an htmlbody template. So your reasoning is lost on me

[Hackwar]

When the email adress is wrapped in those brackets in a plaintext mail, at least in my program the content of the brackets is displayed as a link. With your change that is gone and I just get a plain text. There is a reason why we have the html body field and I would rather have a proper template in there than to convert the current plain text template into HTML, even if it is a simple conversion right now.

[brianteeman]

They're not a link in my email client.

Doing it your way has a lot of b/c issues for anyone that has customised their email and that's not something easily addressed and not something I am prepared to work on

[coolcat-creations]

I would make it a priority to get this fix, because websites can lose their leads without the fix. Afterward, you could discuss improving it.

[Hackwar]

UPDATE #__mail_templates SET htmlbody = 'COM_CONTACT_ENQUIRY_TEXT_HTML' WHERE template_id = 'com_contact.mail' AND htmlbody = '' AND language = '*'
That is fully b/c, doesn't break any existing modifications and is the correct solution to fixing this. I'm not going to merge this PR the way it is.

@coolcat-creations no, companies are not losing their leads. The data is still there. They can look at the source code of the mail and will see the address there. Yes, I know that this is cumbersome.

[brianteeman]

That is only b/c if the email has not been customised

[rdeutz]

I think this is a valid fix for the problem and I don't see why we cant't merge it, will add it to the Wednesday meeting document

[brianteeman]

I think this is a valid fix for the problem and I don't see why we cant't merge it, will add it to the Wednesday meeting document

has this been discussed yet?

[richard67]

has this been discussed yet?

@brianteeman Yes. We have rebased it to 5.3-dev because there will not be a 5.2.x release anymore (if no urgent security fix), so the next regular one will be 5.3.0. As it was a clean rebase, RTC is still valid, and we can merge it as soon as drone is happy.

[richard67]

Thanks all.

[brianteeman]

thanks