Merge 2025 #12
Open
Merge 2025 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You know... I made those charuco changes now I need to document how it works... basic stuff. --------- Co-authored-by: Matt <matthew.morley.ca@gmail.com>
Bump libcamera version to support new pi image.
* Bumps minimum NodeJS requirement to v18 (already used as part of official builds) * Prerequisite for latest VueJS
) Supercedes PhotonVision#1223 --------- Co-authored-by: vladb <vlad.bondar@frc5113.com>
Fixes the following issues with the client log viewer: - Inconsistent and excessive spacing between log entries - Lack of responsiveness to window size or scaling Adds the following features to the log viewer: - Auto-scroll if scrolled to the bottom - Ability to clear logs on button click - Search function to filter logs - Displays the time the frontend captured a log and displays that timestamp in hh::mm::ss in the log viewer - Allows logs to be filtered to be after a certain time - General styling refinements to increase usability --------- Co-authored-by: Sriman Achanta <68172138+srimanachanta@users.noreply.github.com>
Roll back to 2024.3.2 to get some good testing on actual robots.
This PR is for part 1 of PhotonVision#1354. It focuses on adding a model selection interface for models that exist in `photonvision_config/models/`. Upon completion we can ship more than 1 model and users could upload their own through `ssh` without deleting the shipped model. This PR also adds the abstractions need to support more DNN backends (say OpenCV, or RPI AI Kit) Up next is adding a CRUD interface for managing models through the UI.
…onVision#1429) Chrome prints an error to the console when you have `<img src="null" />` The path `//:0` can be used for an empty image and Chrome will not raise an error.
Initial framework for adding JNI libraries. Auto generated JNI headers and sticks native libraries into the JAR (and adds to class path for testing)
revised order to prevent some randomness around init
Co-authored-by: Matt <matthew.morley.ca@gmail.com> Co-authored-by: Chris Gerth <chrisgerth010592@gmail.com>
This space is the root cause of failures in PhotonVision#1437. RE: PhotonVision#1430
Link had ">" at the end of the URL causing a 404 error.
Don't return before we release the object.
Bring the UI setting changes in thread with the camera.
Ubuntu 24 borked for most of our CI. something to do with glibc https://discord.com/channels/725836368059826228/725846784131203222/1294138369177157832 it always should have been at a fixed version. Now it is.
There are no settings for solvePNPEnabled while in driver mode but the UI tries to set it. Let us not do that. Fixes PhotonVision#1377 Co-authored-by: Chris Gerth <gerth2@users.noreply.github.com>
The target list in networktables is limited to 127 items. When you capture more than 127 calibration images it breaks this limit and errors out and dies. Do not publish calibration targets to nt. And also move cal images into their own folder
Someone forgot to add the timestamp.
Supersedes PhotonVision#464 Co-authored-by: Ofir Siboni <050ofir@gmail.com>
Preserve common AdvancedPipelineSettings fields when switching pipeline types. This includes camera resolution, exposure settings, and stuff
Someone hard-coded the 16h5 model. Additionally, the April tag pipeline redistorts the points before drawing them, so let's do that as well.
We accidentally copied more settings then we wanted. This adds an annotation that we can mark variables with that will prevent them from being copied when we switch pipeline types.
Rotate camera calibration coefficients based on camera rotation. Probably. Seems to work. Maybe. --------- Co-authored-by: Matt <matthew.morley.ca@gmail.com>
This PR changes the way that photonvision interacts with nmcli to control networking on the coprocessor. Instead of modifying an existing connection, Photonvision adds new connections for DHCP and Static IP configurations. It then activiates the proper one at startup and any time that the network configuration is changed. It also now uses the interface name and not the connection name and checks that the interface is available before making any changes. If the saved interface is not found, it updates the stored interface name and applies the network settings to the current interface. This should minimize the failure to control the network if the network interface wasn't available when PhotonVision first booted. One other benefit of not altering the default configuration is that, if PhotonVision fails to run for any reason, the device can be accessed using the original networking configuration. The code has been tested on an OrangePi5 and and a Raspberry Pi 4. Addresses: PhotonVision#1261
Sliders for exposure and brightness would spam messages on the backend. This used to cause crashes and can cause it to get quite laggy / delayed. This will add a 20ms debounce which won't send the value to the backend until the value hasn't changed for 20ms. --------- Co-authored-by: Matt <matthew.morley.ca@gmail.com>
Previously NT would quietly drop readQueue changes.
This bug would only appear when there are cameras with the same naming. Old config matching would also match using the by-id this was problematic. When one camera is disconnected it would assign the by-id path to the other camera with the same name. When the camera is replugged in it would not be reassigned the by-id path and would fail the camerainfo equals check.
Also reworks OV9782 defaults. Probably doesn't work on windows. We should hide these sliders probably. Co-authored-by: Cameron (3539) <theforgelover@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.