Add support for modifying iov settings in ncproxy #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
reviewed
Mar 10, 2021
dcantah
reviewed
Mar 10, 2021
dcantah
reviewed
Mar 10, 2021
dcantah
reviewed
Mar 10, 2021
dcantah
reviewed
Mar 10, 2021
dcantah
reviewed
Mar 10, 2021
kevpar
reviewed
Mar 10, 2021
katiewasnothere
force-pushed
the
ncproxy-iov
branch
3 times, most recently
from
54bdbf5 to
c176d66
Compare
|
@microsoft/containerplat I was able to validate this again :) |
dcantah
reviewed
Mar 29, 2021
dcantah
reviewed
Mar 29, 2021
dcantah
reviewed
Mar 29, 2021
|
This needs a rebase I believe, it's still showing the appveyor ci |
dcantah
reviewed
Mar 29, 2021
dcantah
reviewed
Mar 29, 2021
|
Changes lgtm besides the logging/nits, but don't want to lgtm as I forget if it resets on push now with our new settings |
|
Can take the TODO out of the PR description now also as you re-validated |
katiewasnothere
force-pushed
the
ncproxy-iov
branch
2 times, most recently
from
de5a934 to
463f292
Compare
dcantah
reviewed
Apr 1, 2021
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
katiewasnothere
force-pushed
the
ncproxy-iov
branch
from
463f292 to
557915e
Compare
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
This PR updates our internal ADO repo to the github commit [d9474d2](microsoft@d9474d2). Related work items: microsoft#964, microsoft#965, microsoft#966, microsoft#967, microsoft#968, microsoft#969, microsoft#970, microsoft#971, microsoft#972, microsoft#974, microsoft#975, microsoft#976, microsoft#977, microsoft#978, microsoft#979, microsoft#980, microsoft#981, microsoft#982, microsoft#983, microsoft#984, microsoft#987, microsoft#990, microsoft#991, microsoft#992, microsoft#993, microsoft#995, microsoft#996, microsoft#997, microsoft#1000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to modify a network through ncproxy, particularly for disabling/enabling IOV on an endpoint. Thanks to @dcantah for writing a good chunk of the
ModifyNICflow.Currently we require that the caller passes in all values related to IOV settings. This is because there is a discrepancy between how HCS and HCN treats unset values, see comment in discussion.
Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com