Add test for ScaleCPULimitsToSandbox runtime config #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmaxvl
commented
Mar 23, 2021
anmaxvl
force-pushed
the
maksiman/tests/scale-cpu-limits
branch
from
726f2d9 to
9147985
Compare
|
Can the commit message/description describe what the test is doing also? |
|
The test assumes that we have that runtime config on as well, which afaik is hard to tell from here as we don't have access to it :(. |
anmaxvl
force-pushed
the
maksiman/tests/scale-cpu-limits
branch
from
9147985 to
8eb4863
Compare
anmaxvl
changed the title
anmaxvl
force-pushed
the
maksiman/tests/scale-cpu-limits
branch
from
8eb4863 to
7c283c4
Compare
Test does the following:
- calculate 1 core equivalent cpu limit based on the number of cores
the host has, i.e. 10,000/hostNumCPU
- set container CPU limit to the above value.
NOTE: There won't be any difference if the host has only 2 cores
(which is the default for a UVM), but this is unlikely to happen
- make 2 stats request with a 5 second interval and calculate
the CPU usage
- the CPU usage should be around 100% with acceptable error set to 10%
Add `requireBinary` wrapper to check if a binary with a given
name exists in the same directory as the test executable and
conditionally skips the tests if the binary doesn't exist
Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
maksiman/tests/scale-cpu-limits
branch
from
7c283c4 to
a83893c
Compare
dcantah
approved these changes
Mar 24, 2021
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
This PR updates our internal ADO repo to the github commit [d9474d2](microsoft@d9474d2). Related work items: microsoft#964, microsoft#965, microsoft#966, microsoft#967, microsoft#968, microsoft#969, microsoft#970, microsoft#971, microsoft#972, microsoft#974, microsoft#975, microsoft#976, microsoft#977, microsoft#978, microsoft#979, microsoft#980, microsoft#981, microsoft#982, microsoft#983, microsoft#984, microsoft#987, microsoft#990, microsoft#991, microsoft#992, microsoft#993, microsoft#995, microsoft#996, microsoft#997, microsoft#1000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test does the following:
the host has, i.e. 10,000/hostNumCPU
NOTE: There won't be any difference if the host has only 2 cores
(which is the default for a UVM), but this is unlikely to happen
the CPU usage
Add
requireBinarywrapper to check if a binary with a givenname exists in the same directory as the test executable and
conditionally skips the tests if the binary doesn't exist
Signed-off-by: Maksim An maksiman@microsoft.com