Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add utility method to read ext4 superblock from a VHD #971

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Mar 15, 2021

The change enables getting accurate information about ext4 fs on
a given VHD, rather than doing os.Stat or temp mounting the VHD.

Signed-off-by: Maksim An maksiman@microsoft.com

@anmaxvl anmaxvl requested a review from a team as a code owner March 15, 2021 04:11
@anmaxvl anmaxvl force-pushed the maksiman/read-ext4-superblock branch from 09477ce to 4bab6eb Compare March 15, 2021 04:12
ext4/tar2ext4/tar2ext4.go Outdated Show resolved Hide resolved
@anmaxvl anmaxvl force-pushed the maksiman/read-ext4-superblock branch from 4bab6eb to 245f230 Compare March 16, 2021 17:57
@katiewasnothere
Copy link
Contributor

Could you add a description to the PR about why this was added?

Copy link
Contributor

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a comment requesting description for the PR, but otherwise this looks good.

The change enables getting accurate information about ext4 fs on
a given VHD, rather than doing os.Stat or temp mounting the VHD.

Signed-off-by: Maksim An <maksiman@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants