-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch CI to GitHub Actions #970
Conversation
6d26d1c
to
5d150bd
Compare
This gives a comparison-point for RS5, as used by AppVeyor, compared to my 20H2 desktop machine. TODO: Actually integrate a proper test-suite run, possibly using GitHub Actions, per microsoft#936 and microsoft#970. Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
This gives a comparison-point for RS5, as used by AppVeyor, compared to my 20H2 desktop machine. TODO: Actually integrate a proper test-suite run, possibly using GitHub Actions, per microsoft#936 and microsoft#970. Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
Another thanks for working on this! This has been on our todo list for a while. |
+2 on the thanks for this. Much appreciated ❤️ |
171962e
to
0f6cb6c
Compare
Signed-off-by: Marat Radchenko <marat@slonopotamus.org>
0f6cb6c
to
d77c1c4
Compare
Updated PR, see new build run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll let others take a second look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too
This is a follow-up to microsoft#970
This is a follow-up to microsoft#970
This PR updates our internal ADO repo to the github commit [d9474d2](microsoft@d9474d2). Related work items: microsoft#964, microsoft#965, microsoft#966, microsoft#967, microsoft#968, microsoft#969, microsoft#970, microsoft#971, microsoft#972, microsoft#974, microsoft#975, microsoft#976, microsoft#977, microsoft#978, microsoft#979, microsoft#980, microsoft#981, microsoft#982, microsoft#983, microsoft#984, microsoft#987, microsoft#990, microsoft#991, microsoft#992, microsoft#993, microsoft#995, microsoft#996, microsoft#997, microsoft#1000
You can see example build run in my fork.
Note that current repo settings require AppVeyor build to pass for PR. This setting will need to be changed if you decide to merge.