-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support passing in propagation flags on scsi mounts for LCOW #987
Support passing in propagation flags on scsi mounts for LCOW #987
Conversation
c593d6b
to
a7fcef3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe revendor into /test and fix up the functional tests in a separate commit but this LGTM!
a7fcef3
to
6aacfd2
Compare
@kevpar Could you take another look? |
6aacfd2
to
c323550
Compare
internal/uvm/scsi.go
Outdated
@@ -222,8 +222,8 @@ func (uvm *UtilityVM) RemoveSCSI(ctx context.Context, hostPath string) error { | |||
// `readOnly` set to `true` if the vhd/vhdx should be attached read only. | |||
// | |||
// `vmAccess` indicates what access to grant the vm for the hostpath | |||
func (uvm *UtilityVM) AddSCSI(ctx context.Context, hostPath string, uvmPath string, readOnly bool, vmAccess VMAccessType) (*SCSIMount, error) { | |||
return uvm.addSCSIActual(ctx, hostPath, uvmPath, "VirtualDisk", readOnly, vmAccess) | |||
func (uvm *UtilityVM) AddSCSI(ctx context.Context, hostPath string, uvmPath string, readOnly bool, options []string, vmAccess VMAccessType) (*SCSIMount, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will be clearer if we call this guestOptions
instead of options
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed all instances in the scsi file. Does that work?
c323550
to
6b3229a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6b3229a
to
d0ff4d1
Compare
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
d0ff4d1
to
d5f4aee
Compare
This PR updates our internal ADO repo to the github commit [d9474d2](microsoft@d9474d2). Related work items: microsoft#964, microsoft#965, microsoft#966, microsoft#967, microsoft#968, microsoft#969, microsoft#970, microsoft#971, microsoft#972, microsoft#974, microsoft#975, microsoft#976, microsoft#977, microsoft#978, microsoft#979, microsoft#980, microsoft#981, microsoft#982, microsoft#983, microsoft#984, microsoft#987, microsoft#990, microsoft#991, microsoft#992, microsoft#993, microsoft#995, microsoft#996, microsoft#997, microsoft#1000
See microsoft/opengcs#398 for details.
This PR updates the fields for scsi disk attachment to match those in the PR mentioned above and adds a test for the expected behavior of
rshared
mount propagation for scsi disks.Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com