-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v3.3.0 II #2184
Merged
Release v3.3.0 II #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial streamlining of integration tests * formatting * Adding CMD example component integration test * Run int tests from deployment area
* (fix) rm useless f-string fmt * (feat) swap negation in if statement * (fix) rm unused imports
* updated screenshots for commanding, events, channels, and logs * more screenshots --------- Co-authored-by: Justine West <justine.a.west@jpl.nasa.gov>
* Adding updated BufferAccumulator files to public repo * Ported BufferAccumulator to FPv3 * Cleanup notes and todos * Cleanup old build system files * Updated format of code after a clang-format pass * Style changes in BufferAccumulator * Replace NULL with nullptr in BufferAccumulator * Removed unnecessary cast and void arguments * Construct initial version of the Fw::Buffer objects to prevent UBSAN error * Fixing incorrect variable in asser message * Removing superfluous parenthesis on the placement new * Adding header for placement new * Adding explicit operator to appease CPPlint * Added DRAINBUFFERS and NOBLOCK * Fixed Tester.cpp void arguments * Remove void * Remove void * remove void * Remove void * string header fix * Update comments in BufferAccumulator fdd * Update BufferAccumulator.fpp Fixed spelling error --------- Co-authored-by: M Starch <LeStarch@googlemail.com> Co-authored-by: Timothy Canham <timothy.canham@jpl.nasa.gov>
* Add sourcing the virtual environment to the right spot * Update HelloWorld.md for minor fixes * Fixing regressions * Update Deployments.md with minor fixes * Update HelloWorld.md to add In: to the instructions * sp
* Added a name only constructor to ComLogger * Minor fixup of CodeQL warnings * Fixing ctor warnings, checking arg * Reusing init_log_file in constructor * sp * NULL -> nullptr * Adding throttle --------- Co-authored-by: M Starch <LeStarch@googlemail.com>
* Update help messages of fprime-cli * Added zmq to admissible words * Adding non-existent in spelling exception * Substituting non-existent with nonexistent
* Removes 1-to-1 relation of deployments and projects * Fixing CMake UTs * Making deployment subject to toolchain * Fixing CI and minimum tools version * Python formatting and fixing integration test run * Fixing RPI CI path * Fixing RPI remote run integration test
* Fix missing coverage compilations for unit-test files * Cleaning up .gdca removal, fixing #2008
History sync (#2024)
* Rework tutorial index * Review suggestions
* Adds telemetry packet definition step. * Fixes typo in sample code * Fixes some main.cpp references * Changes incorrect `main.cpp` to `TestMain.cpp`
* Add codegen dependency * Remove repeated dependency
* Fixing template component base includes * Making CAssert match Assert * Fixing invalid template and missing header include
* AUTO: Svc/PassiveRateGroup transformed by copy_sources Copying fprime-open-source-review/Svc/PassiveRateGroup [revision: v3.2.0-20-gca5d909e9] to srh-fsw-base/lib/fprime/Svc/PassiveRateGroup * AUTO: Svc/PassiveRateGroup transformed by fppify Running fpp-from-xml on fprime-open-source-review/Svc/PassiveRateGroup/PassiveRateGroupComponentAi.xml to srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/PassiveRateGroup.fpp * AUTO: Svc/PassiveRateGroup transformed by fpp_formater Running fpp-format on srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/PassiveRateGroup.fpp * AUTO: Svc/PassiveRateGroup transformed by cpp_source_updater Rewriting C++ syntax of srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/PassiveRateGroupImpl.cpp Rewriting C++ syntax of srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/PassiveRateGroupImpl.hpp Rewriting C++ syntax of srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/test/ut/TesterBase.cpp Rewriting C++ syntax of srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/test/ut/GTestBase.cpp Rewriting C++ syntax of srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/test/ut/PassiveRateGroupTester.cpp Rewriting C++ syntax of srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/test/ut/PassiveRateGroupImplTester.cpp * AUTO: Svc/PassiveRateGroup transformed by cpp_format Formatting the following files: srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/PassiveRateGroupImpl.cpp srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/PassiveRateGroupImpl.hpp srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/test/ut/TesterBase.cpp srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/test/ut/GTestBase.cpp srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/test/ut/PassiveRateGroupTester.cpp srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/test/ut/PassiveRateGroupImplTester.cpp * AUTO: Svc/PassiveRateGroup transformed by cmakeify Writing fprime-open-source-review/Svc/PassiveRateGroup/mod.mk to srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/CMakeLists.txt Added srh-fsw-base/lib/fprime/Svc/PassiveRateGroup as subdirectory to: srh-fsw-base/lib/fprime/Svc/CMakeLists.txt srh-fsw-base/srh-fsw-base.cmake * AUTO: Svc/PassiveRateGroup transformed by clean_up_clean_up_everybody_clean_up Removing the following: srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/PassiveRateGroupComponentAi.xml srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/mod.mk srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/Makefile srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/ComponentReport.txt srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/test/ut/GTestBase.cpp srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/test/ut/GTestBase.hpp srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/test/ut/TesterBase.cpp srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/test/ut/TesterBase.hpp srh-fsw-base/lib/fprime/Svc/PassiveRateGroup/test/ut/output * Adding passive rate group * Fixing UT and review concerns * Fixing (void) arguments * Fixing (void) and broken links
* Added reusable-builder workflow * Added build-led-blinker * On push/PR * not running integration_tests yet * fix booleans * add optional target platform * For once, spelling was nice with me * misc formatting * Review recommendations * fix usage
Prevent prescan fails when the library has already been defined. This is normally not an issue, but affects some edge-cases. This allows users to avoid a nasty if-tree when using prevent-prescan.
…#2068) * Updated startIntTask in LinuxGpioDriver to take an optional stack size argument * Updated LinuxGpioDriver Stubs for startIntTask update
* ignore docs/ and **.md * always trigger python-format
* stream crossover component * Add StreamCrossover Documentation * Add unit tests, update expect.txt * Add coverage for send error * update test name from ToDo to TestBuffer * Check recvStatus, and deallocate on error * Check recvBuffer size, rename errorDeallocate
* Adding telemetry and event automatic processing for GenericHub * Fixes as suggested by review
* Initial commit for Svc::CmdSplitter * sp
Include fprime-arm-linux toolchain files
* Add SPI Mode Enum to LinuxSpiDriver SPI Modes specify the clock polarity for each transaction. The default Fprime LinuxSpiDriver assumed SPI Mode 0. This should be generalized to account for SPI devices with different clock polarity and phases. * Add default spiMode parameter value, assert check to ensure SPI Mode is in range * Use switch statement to set SPI Mode when opening SPI Device * Force-fail assert and print SPI Mode for invalid SPI modes * Redefined SpiMode enum variables, added missing break statements * Update SpiMode enum comments for each variable
…2098) * Updates to resolve "Complex multi-line /.../-style comment found. Lint may give bogus warnings. Consider replacing these with //-style comments, with #if 0...#endif, or with more clearly structured multi-line comments." alert. Fixed all - Except external libraries * Resolve "Storage-class specifier (static, extern, typedef, etc) should be at the beginning of the declaration." alert. All resolved. * Updated F Prime Cross Compilation Documentation Correct for most recent version of devel. * Spelling Fixes * Remove URL Pattern * Added `rancherdesktop` to expect.txt * cross-compile tutorial re-organization * add macos.md and add step for running executable * clean up command to run executable * change [...] to <...> --------- Co-authored-by: Justine West <justine.a.west@jpl.nasa.gov>
* Migrate MathComponent tutorial to fprime-community * update spelling
* Fix bug in Fw::Buffer * Revise null pointer check in Serializable.cpp
* Update STest * Code cleanup * Revise Pick.hpp
* Clarify valid buffers * Revise Buffer SDD
* Start functional tests for FPP component autocoder * Add test components and formal param template types * Create general formal param types and update test components * Fix FppTest utilities * Update test component and formal param types * Add telemetry tests for FPP components * Add macros to generate test code in FPP component autocoder tests * Add telemetry tests for queued and passive FPP components * Use formal param types in FPP port autocoder tests * Share a main test file between FPP component tests * Add empty FPP component test * Add event tests for active FPP components * Add event tests for all FPP component types * Start parameter tests for FPP components * Add parameter tests for FPP components * Update parameter tests for FPP components * Merge port tests into FPP component tests * Update port tests for FPP components * Format macros * Reorganize FPP tests * Add command tests for FPP components * Add parameter command tests for FPP components * Update FPP tests * Update FPP tests * Update FPP tests * Remove unnecessary ports * Add async FPP component tests * Revise FPP port tests * Reorganize FPP tests * Format macros * Update FPP tests * Add headers * Fix typo * Update expected words for spell checker * Update expected words for spell checker * Run clang format * Update fprime-fpp version * Update FPP version --------- Co-authored-by: bocchino <bocchino@jpl.nasa.gov>
This avoids a pernicious behavior where EVR timestamps lie about their sub-second values. I have this test program: #include <stdio.h> #include <inttypes.h> void main(void) { printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 12); printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 123); printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 1234); printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 12356); printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 123456); } It produces this output: 01:02:03.012 01:02:03.123 01:02:03.1234 01:02:03.12356 01:02:03.123456 so prior to this patch, if we were 1 hour, 2 minutes, 3 seconds, 123 microseconds past midnight, this was printed as "01:02:03.123" instead of "01:02:03.000123". Any reasonable human looking at "01:02:03.123" would see a value of "123000" microseconds. Co-authored-by: Dima Kogan <Dmitriy.Kogan@jpl.nasa.gov>
…ters" Page in the F' User's Guide (#2147) * Update cmd-evt-chn-prm.md Changed "pipes" to "ports" early in the Commands section, because I've never heard pipes used as a term in F Prime and ports make sense in the context of component-to-component communication. * Update cmd-evt-chn-prm.md Changed the last line two lines of "Command Dispatching" to more clearly reflect the operational flow described in the next section, "Command Sequencing" * Update cmd-evt-chn-prm.md Changed the 3rd sentence under "Events" to say that components defining events, rather than commands, should hook up to the Svc::ActiveLogger. This should maybe actually say "defining events AND commands"--I forget if the system always sends out an event for a completed command--but the log ports are definitely required for events * Update cmd-evt-chn-prm.md Changed the sixth sentence under the events header to be more parsable; this may also mean the sentence now communicates incorrect information, but it should definitely should looked at because it doesn't quite make sense right now * Update cmd-evt-chn-prm.md Changed the last lines under the "Event" to more accurately reflect where the different log output ports store their event logs, assuming that these binary and text log ports line up with the "Fw.Log" and "Fw.TextLog" ports respectively as described in the FPP User's Guide in section 9.3.2 * Update cmd-evt-chn-prm.md Updated the second property under the header "Telemetry" to say that the name is prepended with the name of the component instance, and not just the component. This is both consistent with the other data constructs on this page, with how telemetry is usually packetized--"channel name="[componentInstance].[TELEMETRY_CHANNEL]""--and how telemetry coming from two different instances of the same component should intuitively be distinguishable. * Update cmd-evt-chn-prm.md Changed the second sentence under the "Telemetry Database" header for grammatical and semantic clarity. * Update cmd-evt-chn-prm.md Changed the last sentence in the figure 8 description to reflect how the parameter manager changes parameter values through the auto-generated set and save commands; my details might be a little fuzzy, so feel free to correct the specifics, but I think this section deserves a little more fleshing out. I'm also unsure of if the line before this should be expanded upon? Simply saying "Components can set and retrieve parameters" might appear rather opaque to folks who are newer to F' (like myself), even with the context of the Svc::PrmDb which one can look into further in the official F Prime repository. * Fixing minor regression --------- Co-authored-by: M Starch <LeStarch@googlemail.com>
* Bump tools and GDS to 3.3.0 * Update FALLBACK_VERSION * Update requirements.txt
* Add visualization tools to requirements.txt * Alphabetical order * fix
* A note on sudo for virtual environments * Highlighting mac note * Update HelloWorld link * Bootstrapping hints. --------- Co-authored-by: thomas-bc <thomas.boyerchammard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Trying to un bork master and devel