Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add note about --expose-internals #52861

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

doc: add note about --expose-internals #52861

wants to merge 2 commits into from

Conversation

RedYetiDev
Copy link
Member

This PR adds a note about --expose-internals, as the flag allows the internal/ directory to be require()ed.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 6, 2024
@RedYetiDev RedYetiDev added doc Issues and PRs related to the documentations. and removed needs-ci PRs that need a full CI run. labels May 6, 2024
@RedYetiDev RedYetiDev added the review wanted PRs that need reviews. label Jul 2, 2024
@RedYetiDev
Copy link
Member Author

No objections in months, this should be landable, given the tiny change.

@RedYetiDev RedYetiDev added the meta Issues and PRs related to the general management of the project. label Aug 23, 2024
@targos
Copy link
Member

targos commented Aug 24, 2024

@RedYetiDev It's good when PRs have no objections. But nothing is landable without approvals.

jkrems
jkrems approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@jkrems jkrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems handy to mention that flag here and it's also mentioned elsewhere in the (internal) markdown documents.

jasnell
jasnell reviewed Sep 10, 2024
View reviewed changes
lib/internal/README.md Outdated Show resolved Hide resolved
@RedYetiDev RedYetiDev added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed review wanted PRs that need reviews. labels Sep 11, 2024
@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@jkrems jkrems jkrems approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RedYetiDev @targos @jasnell @jkrems @nodejs-github-bot