src: update clang-tidy and focus on modernization

[anonrig]

Rules are available at https://clang.llvm.org/extra/clang-tidy/checks/list.html.

This doesn't impact CI since we don't run clang-tidy, but hints IDEs to use more modern syntax.

cc @nodejs/cpp-reviewers

[mhdawson]

LGTM

[jasnell]

PR is currently blocked from landing due to unreliable CI. Likely needs a rebase.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62632/

[RedYetiDev]

I'm pretty confident this doesn't need a CI, correct? The src/.clang-tidy file isn't used anywhere in the CI?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62746/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/53757
✔  Done loading data for nodejs/node/pull/53757
----------------------------------- PR info ------------------------------------
Title      src: update clang-tidy and focus on modernization (#53757)
Author     Yagiz Nizipli <yagiz@nizipli.com> (@anonrig)
Branch     anonrig:update-clang-tidy -> nodejs:main
Labels     c++, author ready
Commits    1
 - src: update clang-tidy and focus on modernization
Committers 1
 - Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: https://github.com/nodejs/node/pull/53757
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53757
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - src: update clang-tidy and focus on modernization
   ℹ  This PR was created on Mon, 08 Jul 2024 00:27:30 GMT
   ✔  Approvals: 3
   ✔  - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/53757#pullrequestreview-2164256790
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53757#pullrequestreview-2191777029
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/53757#pullrequestreview-2194397584
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-09-24T20:37:57Z: https://ci.nodejs.org/job/node-test-pull-request/62746/
- Querying data for job/node-test-pull-request/62746/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/11029906195

[aduh95]

RSLGTM

[nodejs-github-bot]

Landed in 6fb9f56