Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make test-runner-assert more robust #55036

Merged
merged 1 commit into from
Sep 22, 2024
Merged

test: make test-runner-assert more robust #55036

merged 1 commit into from
Sep 22, 2024

Conversation

RedYetiDev
Copy link
Member

@RedYetiDev RedYetiDev commented Sep 20, 2024 •
edited
Loading

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 20, 2024
@RedYetiDev RedYetiDev mentioned this pull request Sep 20, 2024
Open
@RedYetiDev RedYetiDev added assert Issues and PRs related to the assert subsystem. test_runner Issues and PRs related to the test runner subsystem. labels Sep 20, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.23%. Comparing base (8b8fc53) to head (8450ce4).
Report is 33 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55036      +/-   ##
==========================================
- Coverage   88.23%   88.23%   -0.01%     
==========================================
  Files         652      652              
  Lines      183855   183855              
  Branches    35856    35850       -6     
==========================================
- Hits       162227   162221       -6     
  Misses      14909    14909              
- Partials     6719     6725       +6

see 30 files with indirect coverage changes

@cjihrig
Copy link
Contributor

cjihrig commented Sep 21, 2024

Fixes! rather than Fixes to prevent this from closing that PR. This fixes the specific comment.

FWIW, in cases like that you can use Refs: https://github.com/nodejs/node/pull/54630#issuecomment-2358197506. It doesn't have any significant meaning to GitHub, but still has the advantage of making the git history more useful.

cjihrig
cjihrig approved these changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI passes.

@cjihrig cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62651/

@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 21, 2024
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 22, 2024
@cjihrig cjihrig removed the needs-ci PRs that need a full CI run. label Sep 22, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 22, 2024
@nodejs-github-bot nodejs-github-bot merged commit 8b70e6b into nodejs:main Sep 22, 2024
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8b70e6b

targos pushed a commit that referenced this pull request Oct 4, 2024
@RedYetiDev @targos
test: make test-runner-assert more robust
43bbca2 
PR-URL: #55036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@RedYetiDev @louwers
test: make test-runner-assert more robust
f406ec5 
PR-URL: nodejs#55036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test_runner Issues and PRs related to the test runner subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RedYetiDev @nodejs-github-bot @cjihrig @jasnell @atlowChemi @aduh95