test: deflake test-http-header-overflow #54978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip the network and push the data directly to the receiving socket so that it is guaranteed to be received as a single chunk. Fixes: nodejs#46291
nodejs-github-bot
added
needs-ci
|
The stress test CI runs the test sequentially. It would be nice to have a parallel variant. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54978 +/- ##
==========================================
- Coverage 88.06% 88.06% -0.01%
==========================================
Files 652 652
Lines 183546 183546
Branches 35860 35862 +2
==========================================
- Hits 161648 161640 -8
+ Misses 15149 15145 -4
- Partials 6749 6761 +12 |
ronag
approved these changes
Sep 18, 2024
github-actions
bot
removed
the
request-ci
jakecastelli
added
the
author ready
jasnell
approved these changes
Sep 21, 2024
|
Landed in a9677db |
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
Skip the network and push the data directly to the receiving socket so that it is guaranteed to be received as a single chunk. Fixes: nodejs#46291 PR-URL: nodejs#54978 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the network and push the data directly to the receiving socket so that it is guaranteed to be received as a single chunk.
Fixes: #46291