Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6.6.0 Proposal (old) #8457

Closed
wants to merge 70 commits into from
Closed

v6.6.0 Proposal (old) #8457

wants to merge 70 commits into from

Conversation

Fishrock123
Copy link
Contributor

@Fishrock123 Fishrock123 commented Sep 8, 2016 •
edited
Loading

Moving from #8428

Hopefully I'm doing this right with staging branches? @nodejs/release & @thealphanerd

CI: https://ci.nodejs.org/job/node-test-pull-request/3980/

addaleax and others added 30 commits September 8, 2016 10:27
@addaleax
deps: cherry-pick 8ed65b97 from V8's upstream
f829660 
Original commit message:

    Make FieldType::None() non-nullptr value to avoid undefined behaviour

    When FieldType::None() returns a cast Smi::FromInt(0), which translates
    as nullptr, the FieldType::IsNone() check becomes equivalent to
    `this == nullptr` which is not allowed by the standard and
    therefore optimized away as a false constant by GCC 6.

    This has lead to crashes when invoking methods on FieldType::None().

    Using a different Smi constant for FieldType::None() makes the compiler
    always include a comparison against that value. The choice of these
    constants has no effect as they are effectively arbitrary.

    BUG=#8310

    Review-Url: https://codereview.chromium.org/2292953002
    Cr-Commit-Position: refs/heads/master@{#39023}

Fixes: #8310
PR-URL: #8411
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@Trott @Fishrock123
test: refactor test-util-inspect
6f269be 
* favor `assert.strictEqual()` and friends of `assert.equal()` etc.
* favor `.includes()` over `.indexOf()` for existence checks

PR-URL: #8189
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: #8437
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@addaleax @Fishrock123
util: allow symbol-based custom inspection methods
954eeb1 
Add a `util.inspect.custom` Symbol which can be used to customize
`util.inspect()` output. Providing `obj[util.inspect.custom]`
works like providing `obj.inspect`, except that the former allows
avoiding name clashes with other `inspect()` methods.

Fixes: #8071
PR-URL: #8174
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

Refs: #8437
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@addaleax @Fishrock123
fixup for v6 by adding missing require()
9d4698c 
steal a line from #7207 to make things work

PR-URL: #8437
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@addaleax @Fishrock123
util: allow returning this from custom inspect
c21bfae 
If a custom inspection function returned `this`, use that value
for further formatting instead of going into infinite recursion.

This is particularly useful when combined with `util.inspect.custom`
because returning `this` from such a method makes it easy to
have an `inspect()` function that is ignored by `util.inspect` without
actually having to provide an alternative for custom inspection.

PR-URL: #8174
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

Refs: #8437
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@imyller @Fishrock123
url: url.format() encodes all # in search
13da7f1 
This commit fixes an error where only the first occurrence of `#` in
`search` parameter is URL encoded, and subsequent occurrences are not.

Also added a test for the case.

Fixes: #8064
PR-URL: #8072
Reviewed-By: James M Snell <jasnell@gmail.com>

 Conflicts:
	test/parallel/test-url.js
@imyller @Fishrock123
url: keep auth in url.resolve() if host matches
7307367 
Fixes: #8165

PR-URL: #8215
Reviewed-By: James M Snell <jasnell@gmail.com>
@thefourtheye @Fishrock123
doc: include the optional options parameter
60060e2 
`mkdtemp` functions accept an optional `options` parameter, which can
be either a String specifying encoding, or an Object with an `encoding`
property.

PR-URL: #7842
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
@hefangshi @Fishrock123
doc: fix "timout" typo in timeout
e0f29d6 
Corrected to `timeout`

PR-URL: #8231
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@mozkeeler @Fishrock123
doc: fix buf.readUIntBE, buf.readUIntLE examples
f3014cd 
The documentation describing the output from the examples for
buf.readUIntBE and buf.readUIntLE were switched in terms of what the
code would actually output. This patch addresses this by switching the
two lines of example code to be in the same order as the functions are
listed earlier in the documentation.

PR-URL: #8240
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
@rvagg @Fishrock123
doc: add Myles Borins to the CTC
ab0889a 
PR-URL: #8260
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@lpinca @Fishrock123
doc: add added: information for dgram
aa07e7f 
PR-URL: #8196
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@yorkie @Fishrock123
async_wrap: add a missing case to test-async-wrap-throw-no-init
60cc9cb 
PR-URL: #8198
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@richardlau @Fishrock123
build: add missing files to zip and 7z packages
252cafa 
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages.

PR-URL: #8069
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@mhdawson @Fishrock123
build: fix dependencies on AIX
fbb59b2 
Addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to avoid
this.

Fixes: #8239
PR-URL: #8272
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@mhdawson @Fishrock123
test: mark test-child-process-fork-dgram as flaky
1bb46bf 
PR-URL: #8274
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@thefourtheye @Fishrock123
util: improve function signature of util._extend
39d1ee3 
The function signature of `util._extend` is not intuitive and the
documentation doesn't specify the necessary second parameter. This
patch changes the parameter names in the code and the function params
in doc.

PR-URL: #8187
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell @Fishrock123
test: clean up / refactor buffer tests, remove duplication
fdb81a0 
Remove duplication of buffer tests, separate out into separate
files, update and cleanup code, move to using strictEqual where
possible.

PR-URL: #8256
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

 Conflicts:
	test/parallel/test-buffer-alloc.js
	test/parallel/test-buffer.js
	test/parallel/test-buffer-no-negative-allocation.js
@mscdex @Fishrock123
http: fix connection upgrade checks
1348e6a 
This commit fixes connection upgrade checks, specifically when headers
are passed as an array instead of a plain object to http.request()

Fixes: #8235
PR-URL: #8238
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott @Fishrock123
test: add check in test-signal-handler
a7c440f 
* Check that the removed listener is not called.
* Opportunistic `==` -> `===` change.

PR-URL: #8248
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Fishrock123
doc: fix onReadable reentry after unshift called
0134494 
In example parseHeader, stream listen **readable** event,
if call stream.unshift(buf) before stream.removeListener('readable',
onReadable), readable event will be emited before removeListener,
so callback will not been called correctlly.
After change to
```js
stream.removeListener('error', callback);
stream.removeListener('readable', onReadable);
if (buf.length)
stream.unshift(buf);
```
It solves this problem.

PR-URL: #8200
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@princejwesley @Fishrock123
repl: Auto alignment for .editor mode
2d10aa3 
When in `.editor` mode, current line whitespace prefixes
are preserved in the subsequent line. User can hit backspace
to clean the whitespace

```js
node 🙈 ₹ node
> .editor
// Entering editor mode (^D to finish, ^C to cancel)
function test() {
  console.log('tested!'); //On enter, cursor will be after 2 spaces
  _
```

PR-URL: #8241
Reviewed-By: James M Snell <jasnell@gmail.com>

 Conflicts:
	lib/readline.js
@addaleax @Fishrock123
net: make holding the buffer in memory more robust
ca9c1b9 
Set the `req.buffer` property, which serves as a way of keeping
a `Buffer` alive that is being written to a stream, on the C++
side instead of the JS side.

This closes a hole where buffers that were temporarily created
in order to write strings with uncommon encodings (e.g. `hex`)
were passed to the native side without being set as `req.buffer`.

Fixes: #8251
PR-URL: #8252
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@lpinca @Fishrock123
doc: add added: information for modules
6ccb8be 
PR-URL: #8250
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@thefourtheye @Fishrock123
test: make sure over truncation of file zero fills
8e6fdef 
If the file is over truncated, then the rest of the file should be
filled with null bytes. These tests ensure the same.

PR-URL: #7648
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@thefourtheye @Fishrock123
doc: improve fs.truncate functions' documentation
8813779 
The default value of the `len` parameter is zero and it is included in
the documenetation.

This patch also has examples of how `ftruncate` can be used.

PR-URL: #7648
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mhdawson @Fishrock123
build: fix dependencies on AIX
faa7700 
Addon tests were still starting to run before the node exp file
creation was complete.

- remove process_outputs_as_sources as it did not fix the
  problem
- update create_expfile.sh so that exp file is created in a
  temporary file and then renamed to final name so that
  file is only visible once it is complete
- update target used in building Addons so that for
  AIX it depends on the exp file being available

PR-URL: #8285
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@jasnell @Fishrock123
test: add known issue test for path parse issue #6229
0e26031 
Refs: #6229
PR-URL: #8293
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@jasnell @Fishrock123
doc: 'ipc' is required with fork stdio option
ca0fe5d 
Fixes: #8167
PR-URL: #8290
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@jasnell @Fishrock123
test: additional refactoring/cleanup of buffer tests
a54e961 
* Favor use of strictEqual where possible
* Use const as appropriate
* Other miscellaneous cleanups

PR-URL: #8283
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Trott and others added 6 commits September 8, 2016 19:20
@Trott @Fishrock123
doc: update CI content in onboarding doc
49bce0d 
* add node-test-pull-request link
* minor formatting improvements

PR-URL: #8374
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
@danbev @Fishrock123
src: moving f function call comment
7d2e27e 
The comment about calling the f function seems to have drifted
a little. Moving it to be closer to the actual call.

PR-URL: #8405
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@bnoordhuis @Fishrock123
src: unbreak build when compiling against uclibc
850ce1d 
It seems that it is possible with some toolchains for both `__GLIBC__`
and `__UCLIBC__` to be defined, confusing our "do we have execinfo.h?"
logic.

Assume that when `__UCLIBC__` is defined, we are dealing with a libc
that does not have execinfo.h.

Fixes: #8233
PR-URL: #8308
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mhdawson @Fishrock123
test: mark pseudo-tty/no_dropped_stdio as flaky
34aee0d 
We've determined there is a test issue related to python as
opposed to node, mark as flaky until we can resolve

PR-URL: #8385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@joshgav @Fishrock123
doc: add 2016-08-10 CTC meeting minutes
e822f8b 
PR-URL: #8229
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@Fishrock123
2016-09-08, Version 6.6.0 (Current)
3698e88 
Refs: #8428
@Fishrock123 Fishrock123 added meta Issues and PRs related to the general management of the project. v6.x labels Sep 8, 2016
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Sep 8, 2016
@Fishrock123 Fishrock123 mentioned this pull request Sep 8, 2016
Closed
@Fishrock123 Fishrock123 changed the base branch from master to v6.x September 8, 2016 23:41
@Fishrock123
Copy link
Contributor Author

Also I guess this will be out... I don't even know when since I'm away part of next week 😞

@addaleax
Copy link
Member

addaleax commented Sep 8, 2016

9d4698c should be squashed into its parent commit, sorry for not marking that more clearly

@jasnell
Copy link
Member

jasnell commented Sep 9, 2016

the process with the staging branches is pretty straight forward. Land in the staging branch, cherry-pick the specific set of commits for the release into your proposal branch, open the pr against v6.x. When ready to land, it should just be a matter of landing the PR and tagging. Then, after, rebase the v6.x-staging against v6.x so that any commits that weren't landed get staged after the release commit for the next round.

@Fishrock123
Copy link
Contributor Author

the process with the staging branches is pretty straight forward.

As a first time use of it it's actually pretty confusing as to where what should go. 😐

Fishrock123 added a commit that referenced this pull request Sep 9, 2016
@Fishrock123
2016-09-08, Version 6.6.0 (Current)
9ddfb45 
Refs: #8428
Refs: #8457
@Fishrock123 Fishrock123 changed the title v6.6.0 Proposal v6.6.0 Proposal (old) Sep 9, 2016
@Fishrock123 Fishrock123 mentioned this pull request Sep 9, 2016
Merged
@Fishrock123
Copy link
Contributor Author

Moving to #8466...

@Fishrock123 Fishrock123 closed this Sep 9, 2016
Fishrock123 added a commit that referenced this pull request Sep 9, 2016
@Fishrock123
2016-09-08, Version 6.6.0 (Current)
1a183ce 
Refs: #8428
Refs: #8457
PR-URL: #8466
Fishrock123 added a commit that referenced this pull request Sep 14, 2016
@Fishrock123
2016-09-14, Version 6.6.0 (Current)
0a3ad92 
Notable changes:

* crypto: Added `crypto.timingSafeEqual()`. (not-an-aardvark)
#8304
* events: Made the "max event listeners" memory leak warning more
accessible. (Anna Henningsen) #8298
* promises: Unhandled rejections now emit a process warning after the
first tick. (Benjamin Gruenbaum)
#8223
* repl: Added auto alignment for `.editor` mode. (Prince J Wesley)
#8241
* util: Some functionality has been added to `util.inspect()`:
- Returning `this` from a custom inspect function now works. (Anna
Henningsen) #8174
- Added support for Symbol-based custom inspection methods. (Anna
Henningsen) #8174

Refs: #8428
Refs: #8457
PR-URL: #8466
Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 15, 2016
@Fishrock123
2016-09-14, Version 6.6.0 (Current)
ea2a309 
Notable changes:

* crypto: Added `crypto.timingSafeEqual()`. (not-an-aardvark)
nodejs#8304
* events: Made the "max event listeners" memory leak warning more
accessible. (Anna Henningsen) nodejs#8298
* promises: Unhandled rejections now emit a process warning after the
first tick. (Benjamin Gruenbaum)
nodejs#8223
* repl: Added auto alignment for `.editor` mode. (Prince J Wesley)
nodejs#8241
* util: Some functionality has been added to `util.inspect()`:
- Returning `this` from a custom inspect function now works. (Anna
Henningsen) nodejs#8174
- Added support for Symbol-based custom inspection methods. (Anna
Henningsen) nodejs#8174

Refs: nodejs#8428
Refs: nodejs#8457
PR-URL: nodejs#8466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.