SAI Egress DSCP action behavior #2049
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siqbal1986
force-pushed
the
SAI_proposla_egress_dscp
branch
from
bf580a1
to
d92303d
Compare
Add intermediate container object for outbound routing entries to attach them in all together to ENI. Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
…lect the changes in the document. Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
…uteproject#2028) * [meta][sai] Move extensions SAI and API to 0x20000000 range To make this binary backward comparible for extension enums, instead of starting form _ATTR_END and prevent enum shift each time new attribute is added * [meta] Update saisanitycheck to not use object type as index Since we will move object type extensions to separate range we will need to update many shorcuts taken by sisanitych check when it was using obejct type as index to fast access arrays Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
These counters are recently added for checking drops in DASH pipeline. It follows the DASH HLD here: https://github.com/sonic-net/DASH/blob/main/documentation/high-avail/ha-api-hld.md. Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
This PR is intended to update the current comments of DASH SAI APIs. Previously, all DASH SAI API comments are generated from P4 code using very simple rule, such as all words to upper case to pass the SAI checks. Now, we switched to python for better comment generation, which makes the comment more meaningful and readable. Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
…t#2033) Create a new port attribute to get the max size of the port debug data. This can be read by the NOS to determine the size of the buffer to allocate before reading the port debug data. Signed-off-by: Mike Beresford <mberes@google.com> Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
Add DPU acronym Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
) Bring in SAI API changes from this DASH PR sonic-net/DASH#605 Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
Signed-off-by: Junyi Chen <1162369186@qq.com> Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
…pencomputeproject#2041) * Add new Next Hop Type and allow Next Hop to be an IPMC Group Member Signed-off-by: Manali Holankar <manali.holankar@gmail.com> Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
Signed-off-by: JaiOCP <jai.kumar@broadcom.com> Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
Add Dash DPU scope DPU driven HA attributes (opencomputeproject#2055) Brings in SAI API changes from these DASH PRs sonic-net/DASH#599 sonic-net/DASH#604 Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
Signed-off-by: JaiOCP <jai.kumar@broadcom.com> Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
Signed-off-by: Prasanna Yuvarajan <y.prasanna@gmail.com> Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
…2064) DASH Flow SAI APIs - Add API definitions, type extensions and object key of DASH Flow SAI APIs. The following files are modified: experimental/saiexperimentaldashflow.h: DASH flow specific API definitions. experimental/saiextensions.h: Add SAI_API_DASH_FLOW to sai_api_extensions_t. experimental/saitypesextensions.h: Add type extensions of DASH flow. inc/saiobject.h: Add sai_flow_entry_t flow_entry to sai_object_key_entry_t. Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
Add DASH appliance object APIs (opencomputeproject#2073) Bring in SAI API changes from sonic-net/DASH#616 Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
Support truncation for SAI_SAMPLEPACKET_TYPE_SLOW_PATH. Signed-off-by: rck-innovium <rck@marvell.com> Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
…uteproject#2069) This allows access to functions that indicate what object type an OID represents as well as metadata of an attribute. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
…teproject#2060) Port status change notification now adds additional field to indicate various port error/fault status that caused the port operational status to go down. A capability attribute is added to query the Switch's capability that can be used to know if the new fault/error status are supported in the port status change notification. sai_port_error_status_t bitmap can indicate more than one port error conditions by setting the corresponding error bit indicating why the port went down. Ideally, when the port operational status goes UP, the bitmap value should be ZERO i.e no errors. Adding the error status as part of the port link status change notification allows better correlation of port operational status with various port error/fault conditions events that may have caused the port down event. Signed-off-by: Prince George <prgeor@microsoft.com> Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
Signed-off-by: Shahzad Iqbal <shahzad.iqbal@microsoft.com> Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
siqbal1986
force-pushed
the
SAI_proposla_egress_dscp
branch
from
ac9021a
to
a753d25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document des not define any new behavior for the SAI DSCP change capabilty. It only solidifies the existing the behavior of the packet pipelines observed.
This document lists different places in the packet pipeline where the Packet DSCP value can be changed. It further clearifies how changing of the DSCP value at one stage may be overridden by the next stage and shows how changing this value at different stages may have impact on the final packet egressing the pipeline.