Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[teslapowerwall] Initial contribution #16667

Closed
wants to merge 198 commits into from
Closed

[teslapowerwall] Initial contribution #16667

wants to merge 198 commits into from

Conversation

psmedley
Copy link
Contributor

No description provided.

@psmedley psmedley added the new binding If someone has started to work on a binding. For a new binding PR. label Apr 20, 2024
@psmedley psmedley requested a review from a team as a code owner April 20, 2024 09:13
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/tesla-powerwall-2-integration/63516/280

@lolodomo lolodomo added the work in progress A PR that is not yet ready to be merged label May 25, 2024
@lolodomo
Copy link
Contributor

I added the tag "work in progress" as "WIP" is still in the PR title.
Let us know when this is no more "work in progress".

@psmedley
Copy link
Contributor Author

I think the code is as good as it's going to get, the readme perhaps still needs some work

@lolodomo
Copy link
Contributor

If it is ready/finished, please remove "WIP" from PR title.

@lolodomo lolodomo removed the work in progress A PR that is not yet ready to be merged label May 26, 2024
@psmedley psmedley changed the title [teslapowerwall] [WIP] Initial Contribution [teslapowerwall] Initial Contribution May 27, 2024
@lsiepel lsiepel changed the title [teslapowerwall] Initial Contribution [teslapowerwall] Initial contribution Jun 2, 2024
lsiepel
lsiepel requested changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution. I did a full review. There are some things to fix.
Please also fix any remaining SAT errors and compile warnings.

bundles/org.openhab.binding.teslapowerwall/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.teslapowerwall/README.md Show resolved Hide resolved
bundles/org.openhab.binding.teslapowerwall/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.teslapowerwall/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.teslapowerwall/README.md Outdated Show resolved Hide resolved
...werwall/src/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java Show resolved Hide resolved
...werwall/src/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java Outdated Show resolved Hide resolved
...werwall/src/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java Outdated Show resolved Hide resolved
...werwall/src/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java Outdated Show resolved Hide resolved
...werwall/src/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java Outdated Show resolved Hide resolved
@psmedley
Copy link
Contributor Author

psmedley commented Jun 3, 2024

Thank you for this contribution. I did a full review. There are some things to fix. Please also fix any remaining SAT errors and compile warnings.

I fixed most of the warnings - will investigate the "Redundant null check" ones later in the week.

@psmedley
Copy link
Contributor Author

psmedley commented Jun 4, 2024

All warnings resolved, I believe this is ready for re-review now.

@psmedley psmedley requested a review from lsiepel June 4, 2024 02:55
lsiepel
lsiepel requested changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response. Found some more issues, also some comments from the previous round are not fixed. I guess those are missed becase they are behind the 'show more' button.

bundles/org.openhab.binding.teslapowerwall/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.teslapowerwall/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.teslapowerwall/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.teslapowerwall/README.md Show resolved Hide resolved
bundles/org.openhab.binding.teslapowerwall/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.teslapowerwall/README.md Outdated Show resolved Hide resolved
...werwall/src/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java Outdated Show resolved Hide resolved
...werwall/src/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java Outdated Show resolved Hide resolved
...werwall/src/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java Outdated Show resolved Hide resolved
...werwall/src/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java Outdated Show resolved Hide resolved
jlaur
jlaur reviewed Jun 5, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems I have some old pending comment, I'll take the chance and post it to publish my new comment. :)

bundles/org.openhab.binding.teslapowerwall/src/main/resources/OH-INF/update/instructions.xml Outdated Show resolved Hide resolved
...wall/src/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallWebTargets.java Outdated Show resolved Hide resolved
@psmedley
Copy link
Contributor Author

psmedley commented Jun 6, 2024

OK - I think I've resolved all concerns.

@psmedley psmedley requested a review from lsiepel June 6, 2024 07:23
@psmedley psmedley mentioned this pull request Jun 6, 2024
Merged
lsiepel
lsiepel requested changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are my final comments. Thanks for addressing all issues quick. With this pace we can merge this binding before next stable.

bundles/org.openhab.binding.teslapowerwall/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.teslapowerwall/README.md Outdated Show resolved Hide resolved
...rc/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallBindingConstants.java Outdated Show resolved Hide resolved
...werwall/src/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java Outdated Show resolved Hide resolved
...werwall/src/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java Outdated Show resolved Hide resolved
...wall/src/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallWebTargets.java Show resolved Hide resolved
bundles/org.openhab.binding.teslapowerwall/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.teslapowerwall/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.teslapowerwall/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.teslapowerwall/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
@psmedley psmedley requested a review from lsiepel June 15, 2024 09:28
@psmedley
Make it build
00eb270 
Signed-off-by: Paul Smedley <paul@smedley.id.au>
@psmedley
add missing addon.xml
a67c935 
Signed-off-by: Paul Smedley <paul@smedley.id.au>
@psmedley
Reinstate binding/binding.xml
fd3e60f 
Signed-off-by: Paul Smedley <paul@smedley.id.au>
@psmedley
Add support for degradation and battery capacity
aae36f9 
Signed-off-by: Paul Smedley <paul@smedley.id.au>
@psmedley
Update pom.xml for OH 4.2.0
a40536c 
Signed-off-by: Paul Smedley <paul@smedley.id.au>
@psmedley
Fix copyright date
32793f4 
Signed-off-by: Paul Smedley <paul@smedley.id.au>
@psmedley
update bom/openhab-addons/pom.xml
66e9ae1 
Signed-off-by: Paul Smedley <paul@smedley.id.au>
@psmedley
Fix Warnings
6ab1ac7 
Signed-off-by: Paul Smedley <paul@smedley.id.au>
@psmedley
Fix units for Battery Capacity
6639c11 
Signed-off-by: Paul Smedley <paul@smedley.id.au>
J-N-K and others added 5 commits June 16, 2024 18:35
@J-N-K @psmedley
[mqtt] Fix certificate pinning (openhab#16857)
1ed0635 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@andrewfg @psmedley
[hdpowerview] Improvements to SDDP discovery (openhab#16853)
854ddbb 
* [hdpowerview] add SDDP thing discovery

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@weymann @psmedley
[solarforecast] wait 1 hour after http 429 error (openhab#16819)
836b8d9 
* wait 1 hour after 429 error

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@jlaur @psmedley
[sonos] Fix warnings (openhab#15708)
4e3cdba 
* Fix warnings
* Fix discovery error logging for offline devices

Fixes openhab#6793

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@maihacke @psmedley
Use device.Id instead of device.DiscoveryId to fix playsound (openhab…
5e2efda 
…#16846)

Signed-off-by: Simon Spielmann <simon.spielmann@gmx.de>
@psmedley
Revert "Use device.Id instead of device.DiscoveryId to fix playsound (o…
a8700df 
…penhab#16846)"

This reverts commit 5e2efda.
@psmedley
Revert "[sonos] Fix warnings (openhab#15708)"
e8e4ab1 
This reverts commit 4e3cdba.
@psmedley
Revert "[solarforecast] wait 1 hour after http 429 error (openhab#16819…
eeadc13 
…)"

This reverts commit 836b8d9.
@psmedley
Revert "[hdpowerview] Improvements to SDDP discovery (openhab#16853)"
1bc7c1e 
This reverts commit 854ddbb.
@psmedley
Revert "[mqtt] Fix certificate pinning (openhab#16857)"
3def373 
This reverts commit 1ed0635.
@psmedley
Revert "[epsonprojector] Incorporate review suggestions from other PRs (
380f039 
openhab#16860)"

This reverts commit e6780da.
@psmedley
Revert "Fix UoM in documentation example (openhab#16859)"
d4d8522 
This reverts commit d8e2ee1.
@psmedley
Revert "[senechome] Add additional states (openhab#16842)"
9290fd0 
This reverts commit 4c82598.
@psmedley
Revert "govee docs: remove device type (openhab#16854)"
261d6b3 
This reverts commit e02fb92.
@psmedley
Revert "[atlona] Replace discovery service with core SDDP discovery (o…
7f858d7 
…penhab#16832)"

This reverts commit 64b4c92.
@psmedley
Revert "[benqprojector] Add SDDP discovery and missing menu options (o…
e092627 
…penhab#16848)"

This reverts commit b280eaf.
@psmedley
Revert "[systeminfo] Reduce code complexity as well garbage collection (
98961fe 
openhab#16838)"

This reverts commit 6e77a49.
@psmedley
Revert "[snmp] SNMP v3 fixes and improvements (openhab#16803)"
dcc58b1 
This reverts commit 51da65b.
@psmedley
Revert "Fix state and timestamp being discarded on store with alias (o…
c172129 
…penhab#16845)"

This reverts commit 6aa1caa.
@psmedley
Revert "[epsonprojector] Add SDDP discovery (openhab#16802)"
93a4b76 
This reverts commit d3a884d.
@psmedley
Revert "[MercedesMe] Switch to Mercedes App SDK (openhab#15628)"
26b3e54 
This reverts commit 8eb99ee.
@psmedley
Fix conflict in CODEOWNERS
104fe46 
Signed-off-by: Paul Smedley <paul@smedley.id.au>
@psmedley
Copy link
Contributor Author

Sorry, I've completely messed this up trying to rebase :(

@psmedley
Copy link
Contributor Author

Closing this and will raise new PR :(

@psmedley psmedley closed this Jun 16, 2024
@psmedley psmedley mentioned this pull request Jun 16, 2024
Merged
@psmedley
Copy link
Contributor Author

#16876 is the new PR

@psmedley psmedley deleted the teslapowerwall-main branch June 28, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur left review comments

@lsiepel lsiepel Awaiting requested review from lsiepel

@hmerk hmerk Awaiting requested review from hmerk hmerk is a code owner

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

@mherwege mherwege Awaiting requested review from mherwege mherwege is a code owner

@marcelrv marcelrv Awaiting requested review from marcelrv marcelrv is a code owner

@ssalonen ssalonen Awaiting requested review from ssalonen ssalonen is a code owner

@antroids antroids Awaiting requested review from antroids antroids is a code owner

@BjoernLange BjoernLange Awaiting requested review from BjoernLange BjoernLange is a code owner

@gerrieg gerrieg Awaiting requested review from gerrieg

@wborn wborn Awaiting requested review from wborn wborn is a code owner

@GiviMAD GiviMAD Awaiting requested review from GiviMAD GiviMAD is a code owner

@miloit miloit Awaiting requested review from miloit miloit is a code owner

@mlobstein mlobstein Awaiting requested review from mlobstein mlobstein is a code owner

@cedricboon cedricboon Awaiting requested review from cedricboon cedricboon is a code owner

@J-N-K J-N-K Awaiting requested review from J-N-K J-N-K is a code owner

@andrewfg andrewfg Awaiting requested review from andrewfg andrewfg is a code owner

@MikeTheTux MikeTheTux Awaiting requested review from MikeTheTux MikeTheTux is a code owner

@lolodomo lolodomo Awaiting requested review from lolodomo lolodomo is a code owner

@octa22 octa22 Awaiting requested review from octa22 octa22 is a code owner

@weymann weymann Awaiting requested review from weymann weymann is a code owner

@monnimeter monnimeter Awaiting requested review from monnimeter monnimeter is a code owner

@markus7017 markus7017 Awaiting requested review from markus7017 markus7017 is a code owner

@MikeJMajor MikeJMajor Awaiting requested review from MikeJMajor MikeJMajor is a code owner

@tisoft tisoft Awaiting requested review from tisoft tisoft is a code owner

@dougculnane dougculnane Awaiting requested review from dougculnane dougculnane is a code owner

@peuter peuter Awaiting requested review from peuter peuter is a code owner

@nils nils Awaiting requested review from nils nils is a code owner

@mvalla mvalla Awaiting requested review from mvalla mvalla is a code owner

@pail23 pail23 Awaiting requested review from pail23 pail23 is a code owner

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

@clinique clinique Awaiting requested review from clinique clinique is a code owner

@ntruchsess ntruchsess Awaiting requested review from ntruchsess ntruchsess is a code owner

@ccutrer ccutrer Awaiting requested review from ccutrer ccutrer is a code owner

@Skinah Skinah Awaiting requested review from Skinah Skinah is a code owner

@bruestel bruestel Awaiting requested review from bruestel bruestel is a code owner

@andylintner andylintner Awaiting requested review from andylintner andylintner is a code owner

@matchews matchews Awaiting requested review from matchews matchews is a code owner

@andrasU andrasU Awaiting requested review from andrasU andrasU is a code owner

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

@florian-h05 florian-h05 Awaiting requested review from florian-h05 florian-h05 is a code owner

@sibbi77 sibbi77 Awaiting requested review from sibbi77 sibbi77 is a code owner

@Hilbrand Hilbrand Awaiting requested review from Hilbrand Hilbrand is a code owner

@soenkekueper soenkekueper Awaiting requested review from soenkekueper soenkekueper is a code owner

@jwveldhuis jwveldhuis Awaiting requested review from jwveldhuis jwveldhuis is a code owner

@pravussum pravussum Awaiting requested review from pravussum pravussum is a code owner

@david-pace david-pace Awaiting requested review from david-pace david-pace is a code owner

@GerdZanker GerdZanker Awaiting requested review from GerdZanker GerdZanker is a code owner

@morph166955 morph166955 Awaiting requested review from morph166955 morph166955 is a code owner

@aurelio1 aurelio1 Awaiting requested review from aurelio1 aurelio1 is a code owner

@fwolter fwolter Awaiting requested review from fwolter fwolter is a code owner

@vctender vctender Awaiting requested review from vctender

@stefan-hoehn stefan-hoehn Awaiting requested review from stefan-hoehn

Assignees
No one assigned
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.