feat(oxlint,oxfmt): Allow comments and also commas for vscode-json-ls #15612

leaysgur · 2025-11-12T00:49:56Z

Fixes #15588

Add vscode specific extension of allowComments and allowTrailingCommas for both oxlint and oxfmt.

leaysgur · 2025-11-12T00:50:12Z

feat(oxlint,oxfmt): Allow comments and also commas for vscode-json-ls #15612 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This pull request adds support for trailing commas in JSON configuration files for oxlint and oxfmt by enabling the allowTrailingCommas extension field in their JSON schemas. This is a VS Code-specific extension that allows the vscode-json-languageservice to accept trailing commas without showing errors.

Updated JSON schema generation code to include allowTrailingCommas: true
Updated corresponding JSON schema files and test snapshots
Added clarifying comments referencing the VS Code JSON language service

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
npm/oxlint/configuration_schema.json	Added `allowTrailingCommas: true` to JSON schema
npm/oxfmt/configuration_schema.json	Added `allowTrailingCommas: true` to JSON schema
crates/oxc_linter/src/snapshots/schema_json.snap	Updated snapshot to include `allowTrailingCommas`
crates/oxc_linter/src/config/oxlintrc.rs	Added code to insert `allowTrailingCommas` extension with improved comments
crates/oxc_formatter/tests/snapshots/schema_json.snap	Updated snapshot to include `allowTrailingCommas`
crates/oxc_formatter/tests/schema.rs	Added code to insert `allowTrailingCommas` extension with improved comments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/oxc_linter/src/config/oxlintrc.rs

crates/oxc_formatter/tests/schema.rs

leaysgur · 2025-11-12T00:55:08Z

Will merge it after CI, just ping @camc314 FYI.

leaysgur · 2025-11-12T00:55:14Z

Merge activity

Nov 12, 12:55 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 12, 12:55 AM UTC: leaysgur added this pull request to the Graphite merge queue.
Nov 12, 1:00 AM UTC: Merged by the Graphite merge queue.

…#15612) Fixes #15588 Add vscode specific extension of `allowComments` and `allowTrailingCommas` for both `oxlint` and `oxfmt`.

codspeed-hq · 2025-11-12T00:56:00Z

CodSpeed Performance Report

Merging #15612 will not alter performance

_{Comparing 11-12-feat_oxlint_oxfmt_allow_comments_and_also_commas_for_vscode-json-ls (7699013) with main (fc439ed)¹}

Summary

✅ 33 untouched
⏩ 4 skipped²

No successful run was found on main (3aabfac) during the generation of this report, so fc439ed was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

# Oxlint ### 🚀 Features - c199e38 linter: Implement config for all tsgolint rules supporting options (#15659) (camchenry) - 7598b3e linter: Allow configuring tsgolint rules (#15286) (camchenry) - e77f2ce vscode: Support `oxlint --lsp` (#15680) (Sysix) - e01c551 oxlint: Add `--lsp` flag to run the language server (#15611) (Sysix) - ac5c2ab lsp/fmt: Support ignore files & patterns (#15647) (Sysix) - e50a9bf linter: Add unicorn/prefer-response-static-json rule (#15692) (Mikhail Baev) - f5d9abb oxlint: Add enabled? column to --rules cli output (#15213) (Wren) - 6b5205c linter/plugins: Implement deprecated `SourceCode#getJSDocComment` method (#15653) (overlookmotel) - 5eccff1 linter/plugins: Implement deprecated `SourceCode` tokens methods (#15645) (overlookmotel) - 4c62ffa language_server: Add `run_server` helper for CLI tools (#15609) (Sysix) - 0d52a5e linter/plugins: Implement `Context#parserOptions` getter (#15632) (overlookmotel) - 287a538 linter/plugins: Implement `Context#get*` deprecated methods (#15606) (overlookmotel) - 84de1ca oxlint,oxfmt: Allow comments and also commas for vscode-json-ls (#15612) (leaysgur) - e763919 linter: Add test to enforce schema documentation for rules with configuration options (#15234) (Connor Shea) - 6cd0b5f linter/no-callback-in-promise: Add support for `timeoutsErr` option (#15507) (Li Wei) ### 🐛 Bug Fixes - 1decd57 linter/no-empty-named-blocks: Only search within node for comma token (#15751) (camc314) - 17c3d6d linter: Improve docs, diagnostic message, and implementation of typescript/consistent-indexed-object-style rule. (#15750) (connorshea) - 78a6df2 linter/no-empty-named-blocks: Skip comments when searching for token (#15735) (camc314) - 042befd linter/require-await: Skip comments when searching for token (#15734) (camc314) - 7a78220 linter/no-async-await: Skip comments when searching for token (#15733) (camc314) - 23b9ad1 linter/consistent-type-specifier-style: Skip comments when searching for token (#15732) (camc314) - 440a977 ast: Include rest properties when using `get_binding_identifiers` (#15710) (camc314) - 516d14e linter/no-namespace: Skip comments when searching for token (#15716) (camc314) - b5aaace linter/prefer-namespace-keyword: Skip comments when searching for token (#15715) (camc314) - 4eb9fa6 editor: Execute `oxc.path.server` in win32 with shell (#14203) (Sysix) - 9f991a4 linter: Reverse extends overrides priority (#14939) (Peter Wagenet) - 7c4a916 linter: Restores `oxlint --rules -f=json` functionality. (#15689) (Wren) - 24d00f4 linter/plugins: Add types for suggested fixes (#15636) (overlookmotel) - 257360f linter/plugins: Fill in TS type def for `RuleMeta` (#15629) (overlookmotel) - 81e179c linter: Allow file extensions without a dot in react/jsx-filename-extension rule (#15574) (Connor Shea) - 7a0e931 linter: Update the unicorn/prefer-add-event-listener rule with new JavaScript APIs (#15581) (connorshea) - bb5f8ca oxlint: Fix type annotation for big-endian (#15561) (Sysix) ### ⚡ Performance - e2a0997 linter/plugins: Recycle empty visitor object in ESLint compat mode (#15693) (overlookmotel) - 7528db4 language_server: Pass file content as a referenced `String` (#15568) (Sysix) - 54061e9 linter/plugins: Avoid implicit boolean coercion in `initLines` (#15641) (overlookmotel) - ccfd935 language_server: Avoid `Mutex` in `ServerLinter` (#15516) (Sysix) ### 📚 Documentation - 3ab750a linter: Clarify react-in-jsx-scope rule docs. (#15749) (connorshea) - a5feebc linter: `oxlint-disable` not `eslint-disable` (#15672) (overlookmotel) - 3d15805 linter: Reformat doc comments (#15670) (overlookmotel) - 16fcba6 linter: Remove "experimental" from description of stable features (#15669) (overlookmotel) - e62fd98 linter: Correct comment on what `EnablePlugins` does (#15668) (overlookmotel) - a25d31e linter: Fix grammar (#15666) (overlookmotel) - f5f452f linter: Add missing `perf` category (#15667) (overlookmotel) - 2c58952 linter: Add config docs for no-restricted-globals rule. (#15662) (connorshea) - a210b12 linter/plugins: Improve JSDoc comment for `RuleOptionsSchema` (#15642) (overlookmotel) - 3aabfac linter/plugins: Alter comments on `FILE_CONTEXT` used in ESLint-compat `Context` shim (#15605) (overlookmotel) - fd58aea linter: Fix a typo in the docs for react/no-is-mounted. (#15575) (Connor Shea) # Oxfmt ### 🚀 Features - 84de1ca oxlint,oxfmt: Allow comments and also commas for vscode-json-ls (#15612) (leaysgur) - 99823ad oxfmt: Print nothing for default(write) mode (#15583) (leaysgur) - 25a0163 formatter/sort_imports: Sort imports by `Array<Array<string>>` groups (#15578) (leaysgur) ### 🐛 Bug Fixes - bf20cf5 formatter: `CRLF` issue in the member chain (#15764) (Dunqing) - 5d688a0 formatter: Measuring multiline text in `fits_text` is incorrect (#15762) (Dunqing) - e306958 formatter: Regression case for test call (#15760) (Dunqing) - c42d983 formatter: Re-fix all cases that fail after `AstNode::Argument` was removed (#15676) (Dunqing) ### ⚡ Performance - d99a83f oxfmt: Use simdutf8 based read_to_string (#15614) (leaysgur) - 128e186 formatter/sort_imports: Precompute import metadata (#15580) (leaysgur) - cd31cc1 formatter/sort_imports: Use `Vec::with_capacity` for `next_elements` (#15579) (leaysgur) ### 📚 Documentation - 3d15805 linter: Reformat doc comments (#15670) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

Copilot AI review requested due to automatic review settings November 12, 2025 00:49

leaysgur requested review from Dunqing and camc314 as code owners November 12, 2025 00:49

github-actions bot added A-linter Area - Linter A-formatter Area - Formatter C-enhancement Category - New feature or request labels Nov 12, 2025

Copilot started reviewing on behalf of leaysgur November 12, 2025 00:50 View session

Copilot finished reviewing on behalf of leaysgur November 12, 2025 00:52

Copilot AI reviewed Nov 12, 2025

View reviewed changes

crates/oxc_linter/src/config/oxlintrc.rs Show resolved Hide resolved

crates/oxc_formatter/tests/schema.rs Show resolved Hide resolved

leaysgur mentioned this pull request Nov 12, 2025

oxfmt: allow trailing commas in .oxfmtrc.jsonc #15588

Closed

leaysgur added the 0-merge Merge with Graphite Merge Queue label Nov 12, 2025

feat(oxlint,oxfmt): Allow comments and also commas for vscode-json-ls (…

84de1ca

…#15612) Fixes #15588 Add vscode specific extension of `allowComments` and `allowTrailingCommas` for both `oxlint` and `oxfmt`.

graphite-app bot force-pushed the 11-12-feat_oxlint_oxfmt_allow_comments_and_also_commas_for_vscode-json-ls branch from 7699013 to 84de1ca Compare November 12, 2025 00:55

graphite-app bot merged commit 84de1ca into main Nov 12, 2025
20 checks passed

graphite-app bot deleted the 11-12-feat_oxlint_oxfmt_allow_comments_and_also_commas_for_vscode-json-ls branch November 12, 2025 01:00

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 12, 2025

Boshen mentioned this pull request Nov 17, 2025

release(apps): oxlint v1.29.0 && oxfmt v0.14.0 #15772

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(oxlint,oxfmt): Allow comments and also commas for vscode-json-ls #15612

feat(oxlint,oxfmt): Allow comments and also commas for vscode-json-ls #15612

Uh oh!

leaysgur commented Nov 12, 2025 •

edited

Loading

Uh oh!

leaysgur commented Nov 12, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

leaysgur commented Nov 12, 2025

Uh oh!

leaysgur commented Nov 12, 2025 •

edited by graphite-app bot

Loading

Uh oh!

codspeed-hq bot commented Nov 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

feat(oxlint,oxfmt): Allow comments and also commas for vscode-json-ls #15612

feat(oxlint,oxfmt): Allow comments and also commas for vscode-json-ls #15612

Uh oh!

Conversation

leaysgur commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leaysgur commented Nov 12, 2025

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

leaysgur commented Nov 12, 2025

Uh oh!

leaysgur commented Nov 12, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

codspeed-hq bot commented Nov 12, 2025

CodSpeed Performance Report

Merging #15612 will not alter performance

Summary

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

leaysgur commented Nov 12, 2025 •

edited

Loading

leaysgur commented Nov 12, 2025 •

edited by graphite-app bot

Loading