-
-
Notifications
You must be signed in to change notification settings - Fork 733
fix(linter): Improve docs, diagnostic message, and implementation of typescript/consistent-indexed-object-style rule. #15750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the diagnostic messages and documentation for the typescript/consistent-indexed-object-style linter rule to make them more grammatically correct and actionable.
Key Changes:
- Fixed grammar in diagnostic messages ("A index signature" → "An index signature")
- Enhanced help messages to provide concrete examples of what to use
- Improved documentation examples with better formatting and clearer configuration examples
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
crates/oxc_linter/src/rules/typescript/consistent_indexed_object_style.rs |
Updated diagnostic function to provide better messages with examples, improved documentation comments, and removed redundant parameters |
crates/oxc_linter/src/snapshots/typescript_consistent_indexed_object_style.snap |
Updated test snapshots to reflect new diagnostic and help messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
crates/oxc_linter/src/rules/typescript/consistent_indexed_object_style.rs
Outdated
Show resolved
Hide resolved
crates/oxc_linter/src/rules/typescript/consistent_indexed_object_style.rs
Outdated
Show resolved
Hide resolved
CodSpeed Performance ReportMerging #15750 will not alter performanceComparing Summary
Footnotes
|
Merge activity
|
…typescript/consistent-indexed-object-style rule. (#15750) Diagnostic messages are grammatically correct and also tell the user what to actually do now. And the implementation of the rule has been refactored a bit to ensure the enum is used for the config options rather than a boolean, which was confusing (especially in the generated docs). Docs now look like this: ### What it does Choose between requiring either `Record` type or indexed signature types. These two types are equivalent, this rule enforces consistency in picking one style over the other: ```ts type Foo = Record<string, unknown>; type Foo = { [key: string]: unknown; } ``` ### Why is this bad? Inconsistent style for indexed object types can harm readability in a project. ### Examples Examples of **incorrect** code for this rule with `consistent-indexed-object-style: ["error", "record"]` (default): ```ts interface Foo { [key: string]: unknown; } type Foo = { [key: string]: unknown; }; ``` Examples of **correct** code for this rule with `consistent-indexed-object-style: ["error", "record"]` (default): ```ts type Foo = Record<string, unknown>; ``` Examples of **incorrect** code for this rule with `consistent-indexed-object-style: ["error", "index-signature"]`: ```ts type Foo = Record<string, unknown>; ``` Examples of **correct** code for this rule with `consistent-indexed-object-style: ["error", "index-signature"]`: ```ts interface Foo { [key: string]: unknown; } type Foo = { [key: string]: unknown; }; ``` ## Configuration This rule accepts a configuration object with the following properties: ### preferredStyle type: `"record" | "index-signature"` default: `"record"` When set to `record`, enforces the use of a `Record` for indexed object types, e.g. `Record<string, unknown>`. When set to `index-signature`, enforces the use of indexed signature types, e.g. `{ [key: string]: unknown }`.
5234b12 to
17c3d6d
Compare
# Oxlint ### 🚀 Features - c199e38 linter: Implement config for all tsgolint rules supporting options (#15659) (camchenry) - 7598b3e linter: Allow configuring tsgolint rules (#15286) (camchenry) - e77f2ce vscode: Support `oxlint --lsp` (#15680) (Sysix) - e01c551 oxlint: Add `--lsp` flag to run the language server (#15611) (Sysix) - ac5c2ab lsp/fmt: Support ignore files & patterns (#15647) (Sysix) - e50a9bf linter: Add unicorn/prefer-response-static-json rule (#15692) (Mikhail Baev) - f5d9abb oxlint: Add enabled? column to --rules cli output (#15213) (Wren) - 6b5205c linter/plugins: Implement deprecated `SourceCode#getJSDocComment` method (#15653) (overlookmotel) - 5eccff1 linter/plugins: Implement deprecated `SourceCode` tokens methods (#15645) (overlookmotel) - 4c62ffa language_server: Add `run_server` helper for CLI tools (#15609) (Sysix) - 0d52a5e linter/plugins: Implement `Context#parserOptions` getter (#15632) (overlookmotel) - 287a538 linter/plugins: Implement `Context#get*` deprecated methods (#15606) (overlookmotel) - 84de1ca oxlint,oxfmt: Allow comments and also commas for vscode-json-ls (#15612) (leaysgur) - e763919 linter: Add test to enforce schema documentation for rules with configuration options (#15234) (Connor Shea) - 6cd0b5f linter/no-callback-in-promise: Add support for `timeoutsErr` option (#15507) (Li Wei) ### 🐛 Bug Fixes - 1decd57 linter/no-empty-named-blocks: Only search within node for comma token (#15751) (camc314) - 17c3d6d linter: Improve docs, diagnostic message, and implementation of typescript/consistent-indexed-object-style rule. (#15750) (connorshea) - 78a6df2 linter/no-empty-named-blocks: Skip comments when searching for token (#15735) (camc314) - 042befd linter/require-await: Skip comments when searching for token (#15734) (camc314) - 7a78220 linter/no-async-await: Skip comments when searching for token (#15733) (camc314) - 23b9ad1 linter/consistent-type-specifier-style: Skip comments when searching for token (#15732) (camc314) - 440a977 ast: Include rest properties when using `get_binding_identifiers` (#15710) (camc314) - 516d14e linter/no-namespace: Skip comments when searching for token (#15716) (camc314) - b5aaace linter/prefer-namespace-keyword: Skip comments when searching for token (#15715) (camc314) - 4eb9fa6 editor: Execute `oxc.path.server` in win32 with shell (#14203) (Sysix) - 9f991a4 linter: Reverse extends overrides priority (#14939) (Peter Wagenet) - 7c4a916 linter: Restores `oxlint --rules -f=json` functionality. (#15689) (Wren) - 24d00f4 linter/plugins: Add types for suggested fixes (#15636) (overlookmotel) - 257360f linter/plugins: Fill in TS type def for `RuleMeta` (#15629) (overlookmotel) - 81e179c linter: Allow file extensions without a dot in react/jsx-filename-extension rule (#15574) (Connor Shea) - 7a0e931 linter: Update the unicorn/prefer-add-event-listener rule with new JavaScript APIs (#15581) (connorshea) - bb5f8ca oxlint: Fix type annotation for big-endian (#15561) (Sysix) ### ⚡ Performance - e2a0997 linter/plugins: Recycle empty visitor object in ESLint compat mode (#15693) (overlookmotel) - 7528db4 language_server: Pass file content as a referenced `String` (#15568) (Sysix) - 54061e9 linter/plugins: Avoid implicit boolean coercion in `initLines` (#15641) (overlookmotel) - ccfd935 language_server: Avoid `Mutex` in `ServerLinter` (#15516) (Sysix) ### 📚 Documentation - 3ab750a linter: Clarify react-in-jsx-scope rule docs. (#15749) (connorshea) - a5feebc linter: `oxlint-disable` not `eslint-disable` (#15672) (overlookmotel) - 3d15805 linter: Reformat doc comments (#15670) (overlookmotel) - 16fcba6 linter: Remove "experimental" from description of stable features (#15669) (overlookmotel) - e62fd98 linter: Correct comment on what `EnablePlugins` does (#15668) (overlookmotel) - a25d31e linter: Fix grammar (#15666) (overlookmotel) - f5f452f linter: Add missing `perf` category (#15667) (overlookmotel) - 2c58952 linter: Add config docs for no-restricted-globals rule. (#15662) (connorshea) - a210b12 linter/plugins: Improve JSDoc comment for `RuleOptionsSchema` (#15642) (overlookmotel) - 3aabfac linter/plugins: Alter comments on `FILE_CONTEXT` used in ESLint-compat `Context` shim (#15605) (overlookmotel) - fd58aea linter: Fix a typo in the docs for react/no-is-mounted. (#15575) (Connor Shea) # Oxfmt ### 🚀 Features - 84de1ca oxlint,oxfmt: Allow comments and also commas for vscode-json-ls (#15612) (leaysgur) - 99823ad oxfmt: Print nothing for default(write) mode (#15583) (leaysgur) - 25a0163 formatter/sort_imports: Sort imports by `Array<Array<string>>` groups (#15578) (leaysgur) ### 🐛 Bug Fixes - bf20cf5 formatter: `CRLF` issue in the member chain (#15764) (Dunqing) - 5d688a0 formatter: Measuring multiline text in `fits_text` is incorrect (#15762) (Dunqing) - e306958 formatter: Regression case for test call (#15760) (Dunqing) - c42d983 formatter: Re-fix all cases that fail after `AstNode::Argument` was removed (#15676) (Dunqing) ### ⚡ Performance - d99a83f oxfmt: Use simdutf8 based read_to_string (#15614) (leaysgur) - 128e186 formatter/sort_imports: Precompute import metadata (#15580) (leaysgur) - cd31cc1 formatter/sort_imports: Use `Vec::with_capacity` for `next_elements` (#15579) (leaysgur) ### 📚 Documentation - 3d15805 linter: Reformat doc comments (#15670) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Diagnostic messages are grammatically correct and also tell the user what to actually do now. And the implementation of the rule has been refactored a bit to ensure the enum is used for the config options rather than a boolean, which was confusing (especially in the generated docs).
Docs now look like this:
What it does
Choose between requiring either
Recordtype or indexed signature types.These two types are equivalent, this rule enforces consistency in picking one style over the other:
Why is this bad?
Inconsistent style for indexed object types can harm readability in a project.
Examples
Examples of incorrect code for this rule with
consistent-indexed-object-style: ["error", "record"](default):Examples of correct code for this rule with
consistent-indexed-object-style: ["error", "record"](default):Examples of incorrect code for this rule with
consistent-indexed-object-style: ["error", "index-signature"]:Examples of correct code for this rule with
consistent-indexed-object-style: ["error", "index-signature"]:Configuration
This rule accepts a configuration object with the following properties:
preferredStyle
type:
"record" | "index-signature"default:
"record"When set to
record, enforces the use of aRecordfor indexed object types, e.g.Record<string, unknown>.When set to
index-signature, enforces the use of indexed signature types, e.g.{ [key: string]: unknown }.